You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(theme): ignored files in the explorer meet 4.5:1 in the built-in themes - #37355
Git-ignored files in the File Explorer are drawn in italic --git-decoration-ignored. The built-in values were #8c8c8c (light) and #6e6e6e (dark), which is 3.22:1 and 3.52:1 against the explorer surface (--sidebar). Both are below WCAG AA for text (4.5:1), so an ignored folder you work in every day was hard to read.
Root cause: the two built-in token values, nothing else. The fix raises only those values, to the smallest grey step that meets 4.5:1 on the explorer surface:
Theme
Before
After
Ratio on --sidebar before → after
Still dimmer than
Light
#8c8c8c
#737373
3.22 → 4.54
muted text #696969 (5.26), normal text #0a0a0a (18.97)
Dark
#6e6e6e
#808080
3.52 → 4.54
muted text #acacac (7.90), normal text #f0f0f0 (15.73)
One step smaller fails in both themes: #747474 is 4.48:1 and #7f7f7f is 4.48:1.
Themes that set --git-decoration-ignored keep their own value. The plugin theme pipeline paints it inline on the root, which overrides these class defaults, and the theme contrast gate is unchanged. Theme plugins can set the token (#36578), and that's the supported route for anyone who wants a different look. As requested in the triage, no new setting was added. The existing theme-token-contrast.test.ts now also guards this pair against regressing. A stale comment in plugin-theme-tokens.ts cited the old 3.3:1 built-in value and is updated.
These were computed from rendered colors in a dev build on a throwaway profile, driven over CDP. The row is output/ in a repo that ignores it.
Mode
Surface
Before
After
Light
#fafafa
3.22
4.54
Dark
#171717
3.52
4.54
Match Terminal, light (Tango Light)
#ffffff
3.36
4.74
Match Terminal, dark (Ghostty Default Dark)
#282c34
2.75
3.54 (improved, still under 4.5; see tradeoffs)
Visual proof (File Explorer, output/ and debug.log are ignored)
Before
After
Light
Dark
Match Terminal light
Match Terminal dark
Merge-risk assessment: Low
Two hex values in main.css, one comment, and one test row. No schema, settings, IPC or migration changes.
The token's only readers are FileExplorerRow.tsx (the name and the ignored icon). No mobile, docs or other copies of these hex values exist.
Plugin themes that set the token are unaffected. Mixed client/server versions don't matter, because this is renderer CSS only.
Negative user-facing tradeoffs
Ignored files look slightly less dim than before, so they stand out a little less from tracked files. They still read clearly dimmer than both muted and normal text.
4.5:1 holds on the resting row only. Hovered rows paint --accent: light is 4.35:1 (was 3.08) and dark is 2.63:1 (was 2.03). Reaching 4.5:1 on dark hover would need about #9a9a9a, which no longer reads as dimmed, so I left that out of scope.
Match Terminal derives its surfaces from the terminal theme and does not set this token. On a dark terminal background like #282c34, ignored text improves from 2.75 to 3.54 but stays under 4.5:1.
Validation
pnpm test src/renderer/src/assets/theme-token-contrast.test.ts passes (16 tests, including the new ignored/sidebar pair in light and dark).
oxlint and pnpm format are clean (run by the pre-commit hook).
Real app: ORCA_BACKGROUND_LAUNCH=1 dev build, CDP port 9361, throwaway HOME and user-data dir. I added a demo repo whose .gitignore ignores output/ and *.log, then measured and screenshotted Light, Dark, and Match Terminal light/dark on origin/main and on this branch.
Review: an Opus sub-agent review confirmed the values are the smallest passing step, there are no other consumers or copies, and plugin overrides still win. It flagged hover contrast, which is now documented above. Codex (gpt-6.1-sol, xhigh) reported no correctness, perf, cross-platform or back-compat findings.
Perf
Scanned: the full diff vs origin/main (perf-scan questions 1–6). The only runtime change is two CSS custom-property values that are already declared, so there are no new selectors, declarations, rules, subscriptions or work of any kind. Style recalculation is unchanged: the same token, read by the same rule, with the same invalidation.
Bundle: the CSS byte size is identical (hex values of the same length).
The light and dark theme values for --git-decoration-ignored change. The contrast-pair test adds a check against --sidebar. A comment clarifies that status hues tint file names while the theme’s Git palette remains effective.
Severity of issue fixed: Low
Merge Risk: Minimal · previous review 0f6a5
The token updates and contrast checks introduce no established merge-blocking risk.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the main change: the built-in ignored-file token in the explorer is raised so ignored files meet 4.5:1 contrast in the built-in themes. The changeset matches this. It edits the two tok…
Description check
The description follows the template well. It has a Summary with root cause, What Changed in a before/after table, Why (the WCAG contrast problem and the alternatives considered), a linked issue (Clos…
Linked Issues check
Issue #35910 requires Git-ignored items to remain visible and become easier to read. The PR raises the built-in --git-decoration-ignored values from #8c8c8c to #737373 in light theme and from `#…
Out of Scope Changes check
The changes are limited to the two built-in token values, one related comment, and contrast tests. The comment and tests support the contrast objective. The PR does not add unrelated settings, schema …
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Title check
Explanation
The title names the main change: the built-in ignored-file token in the explorer is raised so ignored files meet 4.5:1 contrast in the built-in themes. The changeset matches this. It edits the two token values in main.css, adds an ignored/sidebar contrast pair to the test, and updates a comment.
Full details: Description check
Explanation
The description follows the template well. It has a Summary with root cause, What Changed in a before/after table, Why (the WCAG contrast problem and the alternatives considered), a linked issue (Closes #35910), visual proof for before and after in light and dark, testing steps and results, a merge-risk assessment with a Low level, and negative tradeoffs. It omits the ELI5 section, the explicit Testing platform list, the Risk backout instructions, the AI Disclosure, and the checklist, and it does not fill in the Review and Agent skill sections. These gaps are non-critical, so the description is mostly complete.
Full details: Linked Issues check
Explanation
Issue #35910 requires Git-ignored items to remain visible and become easier to read. The PR raises the built-in --git-decoration-ignored values from #8c8c8c to #737373 in light theme and from #6e6e6e to #808080 in dark theme. The reported contrast reaches 4.54:1 against --sidebar. The added theme-token-contrast.test.ts checks cover both themes. The implementation uses the issue's proposed default-value approach and does not require a new setting.
Full details: Out of Scope Changes check
Explanation
The changes are limited to the two built-in token values, one related comment, and contrast tests. The comment and tests support the contrast objective. The PR does not add unrelated settings, schema changes, IPC changes, migrations, or unrelated product behavior. The documented hover and Match Terminal limitations remain outside the stated objective.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
23-23: Minor · Maintainability & Code Quality · Quick win
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Correct the contrast rationale.
--git-decoration-ignored also colors the CircleSlash icon in src/renderer/src/components/right-sidebar/FileExplorerRow.tsx:264-272, not only file names. Update this comment to mention filenames and status icons, or state the non-text contrast rationale. (raw.githubusercontent.com)
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 2c129bbb-6d3c-47c7-95a2-c3d2e81bf1a6
Commits
Reviewing files that changed from the base of the PR and between 60e25bd and 0f6a572.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Git-ignored files in the File Explorer are drawn in italic
--git-decoration-ignored. The built-in values were#8c8c8c(light) and#6e6e6e(dark), which is 3.22:1 and 3.52:1 against the explorer surface (--sidebar). Both are below WCAG AA for text (4.5:1), so an ignored folder you work in every day was hard to read.Root cause: the two built-in token values, nothing else. The fix raises only those values, to the smallest grey step that meets 4.5:1 on the explorer surface:
--sidebarbefore → after#8c8c8c#737373#696969(5.26), normal text#0a0a0a(18.97)#6e6e6e#808080#acacac(7.90), normal text#f0f0f0(15.73)One step smaller fails in both themes:
#747474is 4.48:1 and#7f7f7fis 4.48:1.Themes that set
--git-decoration-ignoredkeep their own value. The plugin theme pipeline paints it inline on the root, which overrides these class defaults, and the theme contrast gate is unchanged. Theme plugins can set the token (#36578), and that's the supported route for anyone who wants a different look. As requested in the triage, no new setting was added. The existingtheme-token-contrast.test.tsnow also guards this pair against regressing. A stale comment inplugin-theme-tokens.tscited the old 3.3:1 built-in value and is updated.Closes #35910
Contrast, measured in the running app
These were computed from rendered colors in a dev build on a throwaway profile, driven over CDP. The row is
output/in a repo that ignores it.#fafafa#171717#ffffff#282c34Visual proof (File Explorer,
output/anddebug.logare ignored)Merge-risk assessment: Low
main.css, one comment, and one test row. No schema, settings, IPC or migration changes.FileExplorerRow.tsx(the name and the ignored icon). No mobile, docs or other copies of these hex values exist.Negative user-facing tradeoffs
--accent: light is 4.35:1 (was 3.08) and dark is 2.63:1 (was 2.03). Reaching 4.5:1 on dark hover would need about#9a9a9a, which no longer reads as dimmed, so I left that out of scope.#282c34, ignored text improves from 2.75 to 3.54 but stays under 4.5:1.Validation
pnpm test src/renderer/src/assets/theme-token-contrast.test.tspasses (16 tests, including the new ignored/sidebar pair in light and dark).pnpm formatare clean (run by the pre-commit hook).ORCA_BACKGROUND_LAUNCH=1dev build, CDP port 9361, throwawayHOMEand user-data dir. I added a demo repo whose.gitignoreignoresoutput/and*.log, then measured and screenshotted Light, Dark, and Match Terminal light/dark onorigin/mainand on this branch.gpt-6.1-sol, xhigh) reported no correctness, perf, cross-platform or back-compat findings.Perf
origin/main(perf-scan questions 1–6). The only runtime change is two CSS custom-property values that are already declared, so there are no new selectors, declarations, rules, subscriptions or work of any kind. Style recalculation is unchanged: the same token, read by the same rule, with the same invalidation.