Repository navigation
test(plugins): add statusBarItems to the RPC approval test fixture - #37324
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
#37291 added status bar items to plugins, and plugin summaries now read
statusBarItems. The RPC approval test builds a hand-written plugin fixture without that list, so two of its tests fail on main with a TypeError instead of the expectedapproval_required. This adds the empty list to the fixture.What Changed
src/main/runtime/rpc/methods/plugins.test.ts: the fixture'scontributesgainsstatusBarItems: []. Test-only.Why
Real manifests are normalized with every contribution list present; only this hand-built fixture missed the new one.
Linked Issue
N/A (maintainer fix for main).
Visual Proof
N/A: test-only.
Testing
pnpm test src/main/runtime/rpc/methods/plugins.test.tspasses.Risk
Level: None. Test fixture only.
Agent skill upstream boundary
Checklist
N/Afor visuals with reason