Skip to content

test(plugins): add statusBarItems to the RPC approval test fixture - #37324

Merged
nwparker merged 1 commit into
mainfrom
nwparker/fix-plugins-rpc-test-fixture
Nov 2, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/fix-plugins-rpc-test-fixture

Conversation

@nwparker

@nwparker nwparker commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1
Prod 0 0 0 0

ELI5

#37291 added status bar items to plugins, and plugin summaries now read statusBarItems. The RPC approval test builds a hand-written plugin fixture without that list, so two of its tests fail on main with a TypeError instead of the expected approval_required. This adds the empty list to the fixture.

What Changed

src/main/runtime/rpc/methods/plugins.test.ts: the fixture's contributes gains statusBarItems: []. Test-only.

Why

Real manifests are normalized with every contribution list present; only this hand-built fixture missed the new one.

Linked Issue

N/A (maintainer fix for main).

Visual Proof

N/A: test-only.

Testing

  • pnpm test src/main/runtime/rpc/methods/plugins.test.ts passes.

Risk

Level: None. Test fixture only.

Agent skill upstream boundary

  • Not applicable.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I stated the risk
  • N/A for visuals with reason

@nwparker
nwparker merged commit 892e800 into main Nov 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant