Skip to content

refactor(plugins): split custom editor host types so main passes max-lines - #37314

Merged
nwparker merged 1 commit into
mainfrom
nwparker/fix-custom-editor-host-lines
Nov 2, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/fix-custom-editor-host-lines

Conversation

@nwparker

@nwparker nwparker commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​65 $\color{#cf222e}{\Huge{\mathbf{−}}}$​49 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​16

ELI5

Two plugin PRs merged close together (#37277 and #37278). Each kept plugin-custom-editor-host.ts under the 300-line limit on its own, but together they push it to 302, so pnpm lint fails on main and on every open PR. This moves the file's exported types into their own file.

What Changed

The CustomEditorHost* types move to plugin-custom-editor-host-types.ts. The host file re-exports them, so no import changes elsewhere. No behaviour change.

Why

This is the lint fix with the smallest diff that keeps the 300-line rule.

Linked Issue

N/A (maintainer fix for main).

Visual Proof

N/A: type move only.

Testing

  • oxlint is clean for the editor folder, pnpm tc:web passes, and the editor tests pass (2,787).

Risk

Level: Low. Type-only move; plain revert.

Agent skill upstream boundary

  • Not applicable.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I stated the risk
  • N/A for visuals with reason

@nwparker
nwparker merged commit 1cc843e into main Nov 2, 2026
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 32311390-dccf-49a5-8dc3-1303356d7cb1
Commits

Reviewing files that changed from the base of the PR and between a08ac11 and 6e91017.

Files selected for processing: 2
  • src/renderer/src/components/editor/plugin-custom-editor-host-types.ts
  • src/renderer/src/components/editor/plugin-custom-editor-host.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant