Repository navigation
Keep a project’s own checkout visible through path aliases - #37233
brennanb2025 wants to merge 11 commits into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
No actionable comments were generated in the recent review.
|
…classification Resolve a saved project root asynchronously with each worktree scan and carry the result with that scan's rows in memory, so visibility checks on cached rows (lists, sidebar, process and file targets) touch no filesystem. The registered checkout is recognized even when it is a linked worktree or a stalled-scan metadata row. Nested repo import and the same-checkout lookup recognize alias spellings without probing other WSL distros.
… through the cache TTL
Review statusThe problem. If you created or cloned a Git project inside a folder reached through a symlink ( What changes for users. New projects from Create and Clone (desktop and paired host) save the location Git reports, like Add Project, so the checkout is visible right away. Projects already saved through a symlink, including ones registered at a linked worktree, show their own checkout again with no saved data rewritten. Repeating Create, Clone or nested import through the symlinked path finds the existing project. Other projects' worktrees stay hidden. What review changed. The first version resolved the folder's real location synchronously on every visibility check, including checks on cached rows. A hung network mount could then have frozen the app. The fix was reworked so each worktree scan resolves the location once, in the background, and visibility checks never touch the disk. That pass also fixed three more cases:
Creating a project also no longer touches unrelated WSL distros. Verified.
Not verified. No running app was launched: nothing on screen changed, and the behavior is main-process logic covered by the integration tests above. Deferred.
Already on main, not changed by this PR (for Brennan):
For Brennan's review
|
The problem
If you created or cloned a Git project inside a folder reached through a symlink (for example
~/codepointing at another disk, macOS's/tmp, or a Windows junction), the project showed up with no workspace at all. Orca saved the path as you typed it, but Git reports the project's checkout at its real location. Orca compared the two as plain text, decided the checkout belonged to some other project, and the default "hide external worktrees" setting hid it. Add Project didn't have this problem because it already saves the location Git reports.What changes for users
How it works
git rev-parse --show-toplevel). The other entry points then find them through the existing same-folder check, which resolves symlinks.Visible differences (intended)
\\wsl$\…becomes\\wsl.localhost\…, a\\wsl.localhost\<distro>\mnt\c\…path becomesC:\…, and a mapped drive letter becomes its\\server\share\…path.No settings, saved fields or protocol messages are added.
Verification
/tmp./tmpcase was skipped there.Tracked in STA-13215: https://linear.app/stably/issue/STA-13215/git-projects-created-through-symlinked-paths-hide-their-own-checkout