You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: group renderer session launch owners - #37018
Puts renderer session-launch code together so its owners and callers are easier to find. Launching, retrying, cancelling, and restoring sessions keep their existing behavior.
What Changed
Moves 36 files into lib/agent-session/launch and updates callers, mocks, and CI timing paths together. Removes forwarding exports; consumers import the concrete status, selection, cancellation, and type owners.
Two absent legacy tests are accounted for separately: one was relocated upstream into the existing integration suite, and one was deliberately retired upstream. The current integration suite stays in place.
Why
Keeps related launch responsibilities together and makes dependencies explicit, without barrels or compatibility shims.
Linked Issue
Maintainer-authorized module-organization cleanup; no separate issue opened.
Visual Proof
N/A — module moves and import retargets preserve rendered UI and interaction behavior.
Testing
I manually tested these changes locally
Automated tests added/updated, or explained why not below
Existing tests and mocks were retargeted. Local macOS validation: ORCA_BACKGROUND_LAUNCH=1 pnpm check:changed --base=46bc075bf9e0d9a9d9cb79a1ac3c9d28ff735b97 --maxWorkers=2 passed 24 of 25 checks, including unit tests and typechecks. Its sole fixture line-count finding was corrected by renaming a new mock callback parameter; focused lint, formatting, both fixture consumer suites (29 tests), seven affected view suites (49 tests), and normal commit hooks passed.
Hosted lint then found four duplicate same-owner imports. Consolidating them preserved bindings, evaluation order, and non-import statements; the failing lint rule and four affected consumer suites (38 tests) pass locally.
Hosted CI covers Linux unit tests, static analysis/typechecks, package builds including Windows, and isolated Electron end-to-end/layout checks. The sole initial end-to-end failure captured text in the terminal instead of the search box; the failed-job-only retry passed on unchanged source. No local manual GUI or SSH session was run.
AI Disclosure
Review
Two independent native Codex source audits verified production bodies, literals, concrete owners, mock composition, and all 142 outputs across 178 changed paths. The unchanged refactor-audit merge gate and independent current-main preservation review pass. Detailed evidence remains local.
Agent skill upstream boundary
Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.
Notes
No protocol, permission, persistence, focus, or rendering behavior changes. Platform, remote, mobile, and folder-workspace paths retain their existing implementation; only module ownership and references change.
Checklist
This PR is focused: one renderer session-launch boundary
I explained what changed and why
Visual proof is N/A with reason
Self-reviewed for correctness, security, and performance
Cross-platform, SSH/remote, and path/shortcut impact considered
Lint, typechecks, tests, and builds covered by the validation above and hosted CI
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.
Walkthrough
The change relocates structured agent-session launch modules under agent-session/launch. Production imports, test imports, mocks, fixtures, and CI timing keys now use the new paths. Launch tests separate implementation, registry, and options mocks. The launch implementation also removes its registry, status, and selection re-exports.
Merge Risk: Minimal · up to 74d5e
The launch modules and their consumers have been relocated without an identified merge-blocking behavior change.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: grouping renderer session launch owners under a dedicated module area.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description is complete and aligned with the template. It explains the refactor, scope, rationale, visual impact, testing, review evidence, platform considerations, and checklist status. The maint…
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 50 files. (90 skipped: 1 unsupported, 89 over the file limit.)
Full details: Description check
Explanation
The description is complete and aligned with the template. It explains the refactor, scope, rationale, visual impact, testing, review evidence, platform considerations, and checklist status. The maintainer-authorized cleanup explains why no separate issue was opened.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Puts renderer session-launch code together so its owners and callers are easier to find. Launching, retrying, cancelling, and restoring sessions keep their existing behavior.
What Changed
Moves 36 files into
lib/agent-session/launchand updates callers, mocks, and CI timing paths together. Removes forwarding exports; consumers import the concrete status, selection, cancellation, and type owners.Two absent legacy tests are accounted for separately: one was relocated upstream into the existing integration suite, and one was deliberately retired upstream. The current integration suite stays in place.
Why
Keeps related launch responsibilities together and makes dependencies explicit, without barrels or compatibility shims.
Linked Issue
Maintainer-authorized module-organization cleanup; no separate issue opened.
Visual Proof
N/A — module moves and import retargets preserve rendered UI and interaction behavior.
Testing
Existing tests and mocks were retargeted. Local macOS validation:
ORCA_BACKGROUND_LAUNCH=1 pnpm check:changed --base=46bc075bf9e0d9a9d9cb79a1ac3c9d28ff735b97 --maxWorkers=2passed 24 of 25 checks, including unit tests and typechecks. Its sole fixture line-count finding was corrected by renaming a new mock callback parameter; focused lint, formatting, both fixture consumer suites (29 tests), seven affected view suites (49 tests), and normal commit hooks passed.Hosted lint then found four duplicate same-owner imports. Consolidating them preserved bindings, evaluation order, and non-import statements; the failing lint rule and four affected consumer suites (38 tests) pass locally.
Hosted CI covers Linux unit tests, static analysis/typechecks, package builds including Windows, and isolated Electron end-to-end/layout checks. The sole initial end-to-end failure captured text in the terminal instead of the search box; the failed-job-only retry passed on unchanged source. No local manual GUI or SSH session was run.
AI Disclosure
Review
Two independent native Codex source audits verified production bodies, literals, concrete owners, mock composition, and all 142 outputs across 178 changed paths. The unchanged refactor-audit merge gate and independent current-main preservation review pass. Detailed evidence remains local.
Agent skill upstream boundary
Notes
No protocol, permission, persistence, focus, or rendering behavior changes. Platform, remote, mobile, and folder-workspace paths retain their existing implementation; only module ownership and references change.
Checklist