Repository navigation
Fix update-related issues: macOS crash, duplicate notifications, version display - #37
Merged
Merged
Conversation
…ion display - Fix macOS "quit unexpectedly" crash on update-and-restart by using app.relaunch() + app.quit() instead of autoUpdater.quitAndInstall() which bypasses the normal quit lifecycle - Fix duplicate "checking for updates" notifications by removing redundant sendStatus calls (the electron-updater event handler already emits the checking state) - Show current app version in the Settings update section Fixes #35 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nwparker
force-pushed
the
nwparker/update-fixes
branch
from
March 22, 2026 22:54
3069f83 to
096a78e
Compare
Jinwoo-H
added a commit
that referenced
this pull request
Sep 5, 2026
Jinwoo-H
added a commit
that referenced
this pull request
Sep 5, 2026
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…ion display (stablyai#37) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.relaunch()+app.quit()instead ofautoUpdater.quitAndInstall()on macOS, which callsapp.exit()and bypasses the normal quit lifecycle causing the "quit unexpectedly" dialogsendStatus({ state: 'checking' })calls fromcheckForUpdates()andcheckForUpdatesFromMenu()— thechecking-for-updateevent handler already emits this status, so it was firing twiceupdater:getVersionIPC channelFixes #35
Test plan
🤖 Generated with Claude Code