Skip to content

feat(chat): show split shortcut in pane header tooltip - #36872

Merged
AmethystLiang merged 2 commits into
mainfrom
AmethystLiang/show-shortcut-for-spliting-tab-group
Nov 1, 2026
Merged

AmethystLiang merged 2 commits into
mainfrom
AmethystLiang/show-shortcut-for-spliting-tab-group

Conversation

@AmethystLiang

@AmethystLiang AmethystLiang commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​35 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​35
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​43 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​42

ELI5

Hovering over the native-chat split button now shows the keyboard shortcut for the same action.

What Changed

Append standard ShortcutKeyCombo key caps to the Split Chat Right tooltip using the existing effective-binding hook. Custom bindings update the displayed keys, and unbound actions show no shortcut. The button keeps its action-only accessible name.

Add tooltip coverage and a headless component fixture for visual review.

Why

Make the existing shortcut discoverable without duplicating keyboard handling or split behavior.

Linked Issue

No linked issue.

Visual Proof

Light and dark screenshots attached below. The before captures show the existing action-only tooltip; after captures show the shortcut key caps.

Testing

  • Checked headless component screenshots in light and dark mode on macOS.
  • Updated automated tooltip tests, including a custom binding and an unbound action.
  • All 16 tests passed across the header, pane-command, and split-flow suites during review; the 14 header and pane-command tests passed again after the key-cap change.
  • Focused lint, formatting, and git diff checks passed; commit hooks passed.
  • Full typecheck, build, and remaining checks are delegated to CI. Windows/Linux and SSH were not manually exercised; bindings use the existing platform-aware hook and no runtime protocol changes are introduced.

Review

Self-reviewed the keyboard handler and button path: both use the existing native-chat split action.

Agent skill upstream boundary

  • Not applicable; no upstream skill source is copied.

Checklist

  • Small and focused change with behavior and rationale explained.
  • Before/after screenshots attached.
  • Self-reviewed for correctness, security, and performance.
  • Cross-platform, SSH/remote, mobile, and shortcut impact considered; desktop tooltip presentation only.
  • Focused local checks passed; CI covers remaining validation.

Before, dark

After, dark

Before, light

After, light

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b7b8f2b7-b152-47a8-9619-faf29c9a7d4c
Commits

Reviewing files that changed from the base of the PR and between c440ec1 and c41937c.

Files selected for processing: 2
  • src/renderer/src/components/native-chat/NativeChatPaneHeader.test.tsx
  • src/renderer/src/components/native-chat/NativeChatPaneHeader.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

NativeChatPaneHeader now loads shortcut-combo details for terminal.splitRight and displays available combinations in the Split Chat Right tooltip. Tests cover platform-formatted shortcuts, multiple combinations, and an empty binding. A fixture focuses the split button.

Merge Risk: Minimal · up to c4193

The shortcut tooltip change is consistent with existing formatting behavior and is ready to merge.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Description check Warning The description explains the user-facing change, implementation, rationale, testing, visual proof, and checklist status. However, it explicitly states that no linked issue exists, while the repository… Add the relevant issue reference under “Linked Issue” using “Fixes #”. Complete any applicable missing template sections, including “AI Disclosure” and “Notes”.
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: showing the split shortcut in the chat pane header tooltip.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the user-facing change, implementation, rationale, testing, visual proof, and checklist status. However, it explicitly states that no linked issue exists, while the repository template requires an actual linked issue.

Resolution

Add the relevant issue reference under “Linked Issue” using “Fixes #<issue-number>”. Complete any applicable missing template sections, including “AI Disclosure” and “Notes”.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 3 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47231435-db6b-43f8-9d3c-ae5b1e1138a7
Commits

Reviewing files that changed from the base of the PR and between 833f6cc and c440ec1.

Files selected for processing: 3
  • src/renderer/src/components/native-chat/NativeChatPaneHeader.fixture.tsx
  • src/renderer/src/components/native-chat/NativeChatPaneHeader.test.tsx
  • src/renderer/src/components/native-chat/NativeChatPaneHeader.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@AmethystLiang
AmethystLiang force-pushed the AmethystLiang/show-shortcut-for-spliting-tab-group branch from c440ec1 to c41937c Compare November 1, 2026 19:56
@AmethystLiang
AmethystLiang merged commit 730a458 into main Nov 1, 2026
42 checks passed
Nenzyz pushed a commit to Nenzyz/orca that referenced this pull request Nov 2, 2026
* feat(chat): show split shortcut in pane header tooltip

* Show split chat shortcuts clearly in tooltip
Nenzyz pushed a commit to Nenzyz/orca that referenced this pull request Nov 2, 2026
* feat(chat): show split shortcut in pane header tooltip

* Show split chat shortcuts clearly in tooltip
Nenzyz pushed a commit to Nenzyz/orca that referenced this pull request Nov 2, 2026
* feat(chat): show split shortcut in pane header tooltip

* Show split chat shortcuts clearly in tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant