Repository navigation
Agent setup panel no longer renders behind the new tab menu - #36839
Conversation
The setup panel opened from an agent row's arrow used the base popover layer (z-60), below the menu it opens from (z-70), so the menu's drop shadow fell across the panel and it looked tucked behind the menu. Sharing the menu layer stacks it by open order, like a submenu, and keeps the panel's own permission dropdown above it.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
No actionable comments were generated in the recent review.
|
Review loop status: light path, doneThe problem. In the new tab menu, the arrow next to an agent (for example Claude) opens a panel for its model, effort and args. That panel was drawn underneath the menu that opened it: the panel used the base popover layer (z-index 60) while menus sit at 70, so the menu's drop shadow fell across the panel's left edge and the panel looked like the lower layer. In a narrow window, where the panel opens below the agent row and overlaps the menu, the menu rows were drawn over the panel. The change. The panel now sits on the menu layer (z-index 70). At equal z-index the later-opened layer paints on top, so the panel lands above the menu that opened it, and the panel's own permission dropdown (also 70, opened later) still lands above the panel. Tooltips stay above everything (90). This is the same way a submenu already stacks over its parent menu. Review. One fresh adversarial reviewer confirmed the light-path classification in code (1 production line, styling only, no repeat in 30 days, local effect) and found nothing. It checked: both places the panel mounts are inside the z-70 new tab menu; the class replaces the base z-60 through the class merge; the positioning wrapper copies the panel's z-index; everything inside the panel that portals (permission dropdowns at 70, tooltips at 90) still opens above it, and nothing inside it sits at 50 or 60; dialogs (50) were already below both layers, so their order is unchanged. No review findings, nothing deferred. One test-only commit since: 5826991 adds a renderer test ( Reference comparison: not required. This is renderer styling in the agent picker; it changes no agent mechanism, value source or check on a user's action. Verified. CI was green on 7e220ef. On 5826991 the only failure was lint in For Brennan's review
Branch, permission dropdown open above the panel:
Head 7e220ef includes one merge of main (2 unrelated commits: an orcad sidecar cleanup and an orchestration guide edit). Since the QA'd head: 5826991 (test only) and 7919910 (merge of main bringing in #36852's lint fix and other unrelated main commits; no conflicts, no change to this PR's files). |





Problem
In the new tab menu, clicking the arrow next to an agent (for example Claude) opens a panel to pick its model, effort and args. That panel looked like it was tucked behind the menu: the menu's drop shadow fell across the panel's left edge, so the panel read as the lower layer even though it is the thing the user just opened. Reported in Slack with a screenshot.
Why: the panel uses the app's base popover layer (z-index 60), while dropdown menus sit one layer higher (z-index 70). The panel was literally rendered underneath the menu it opens from, and only looked mostly visible because it is positioned beside it.
Change
The setup panel now uses the menu layer (z-index 70). With equal z-index, the browser stacks by open order, so the panel lands above the menu that opened it, and the panel's own permission dropdown (also z-index 70, opened later) still lands above the panel. This is the same way a nested submenu already stacks over its parent menu. Tooltips stay above everything at z-index 90.
The only place this panel opens is the new tab menu's agent rows, which are all z-index 70 menus.
Review path: light
AgentLaunchSetupButton.tsx).git log --since=30.dayson the file shows only the feature that added it (Choose an agent setup from the new tab menu #34728); no earlier fix for this symptom, no revert.Plan: put the menu-launched popover on the menu layer instead of adding a special shadow or offset, so stacking follows open order like submenus.