Repository navigation
ci(ssh-windows): include cloud in the sparse checkout - #36715
Conversation
…oad its tsconfig references
|
No actionable comments were generated in the recent review.
|
|
The Windows SSH host checks failed before running tests because the test transform config now references projects under A fresh adversarial review confirmed the light-path criteria, traced all 14 local configs in the reference closure, and checked Git's sparse checkout rules against the required root files. No blocking findings, code fixes, or deferred bugs remain. Other sparse checkouts do not need this dependency. Verification: Windows SSH host matrix and PR checks. All four Windows host matrix cells pass, including the previously failing x64 preview cell. Static analysis and typecheck, all 12 unit shards, relay integration, and the PR gate pass on the reviewed head. App QA and screenshots are not required for a CI-only change; no app run was performed. For Brennan's review: the checkout addition and the cloud config references. No screenshots apply. |
Problem
Since #36657,
config/tsconfig.vitest-transform.jsonreferences the projects undercloud/. The SSH Windows hosts workflow checks out only some folders (sparse checkout), andcloudisn't one of them. So Vite fails before any host test runs, with "cannot load cloud/apps/connector/tsconfig.json". This currently fails the x64 preview cells for every PR that triggers this workflow. For example, #35764's run 41217181492 failed this way, with no change to these files.Change
Add
cloudto the workflow's sparse checkout list, with a one-line comment saying why. Nothing else changes.Other sparse checkouts run standalone JavaScript or read workflow policy. Their build and test source checkouts are full, so no other sparse checkout needs this change.
Testing
This workflow's own run on this PR is the test: the cells that failed should get past Vite setup.
Review classification
Light path:
Plan
Include the complete cloud tree using the existing sparse checkout mechanism. Review the tsconfig references and checkout consumers, then require the workflow’s matrix to pass setup on this PR. No app QA is needed for a CI-only change.