Skip to content

ci(ssh-windows): include cloud in the sparse checkout - #36715

Merged
brennanb2025 merged 1 commit into
mainfrom
brennanb2025/ci-ssh-windows-sparse-cloud
Nov 1, 2026
Merged

brennanb2025 merged 1 commit into
mainfrom
brennanb2025/ci-ssh-windows-sparse-cloud

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2

Problem

Since #36657, config/tsconfig.vitest-transform.json references the projects under cloud/. The SSH Windows hosts workflow checks out only some folders (sparse checkout), and cloud isn't one of them. So Vite fails before any host test runs, with "cannot load cloud/apps/connector/tsconfig.json". This currently fails the x64 preview cells for every PR that triggers this workflow. For example, #35764's run 41217181492 failed this way, with no change to these files.

Change

Add cloud to the workflow's sparse checkout list, with a one-line comment saying why. Nothing else changes.

Other sparse checkouts run standalone JavaScript or read workflow policy. Their build and test source checkouts are full, so no other sparse checkout needs this change.

Testing

This workflow's own run on this PR is the test: the cells that failed should get past Vite setup.

Review classification

Light path:

  • Small: two added lines in one CI workflow; no shipped code or tests change.
  • Outside risky areas: only checkout inputs change; no build/release/packaging commands, process behavior, saved data, protocol, auth or user defaults change.
  • Not a repeat: the last 30 days of this workflow’s history contain no fix for the missing cloud tsconfig references or a revert of this change; the dependency was introduced by fix(test): keep unit-test tooling inside the repo root in nested checkouts #36657.
  • Local effect: CI-only checkout completeness, applied uniformly to the existing Windows host matrix.

Plan

Include the complete cloud tree using the existing sparse checkout mechanism. Review the tsconfig references and checkout consumers, then require the workflow’s matrix to pass setup on this PR. No app QA is needed for a CI-only change.

@brennanb2025
brennanb2025 marked this pull request as ready for review October 31, 2026 16:06
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 29c95b47-c95a-49b3-a221-fa10d74c3167
Commits

Reviewing files that changed from the base of the PR and between 8d47584 and 58bf7f1.

Files selected for processing: 1
  • .github/workflows/ssh-windows-hosts.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

Walkthrough

The Windows hosts workflow's sparse checkout now includes the cloud directory alongside .github.

Merge Risk: Minimal · up to 58bf7

The sparse checkout change matches the stated Vitest configuration requirement and is ready to merge.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description clearly explains the problem, change, scope, and intended validation. However, it does not follow the required template. It omits the ELI5, Why, Linked Issue with a Fixes link, Visual … Add all required template sections. Include an actual linked issue in the required Fixes format, state N/A with a reason for Visual Proof if applicable, complete the testing checkboxes and report the workflow result, and complete the remain…
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly identifies the CI workflow and the specific change: adding cloud to the SSH Windows hosts sparse checkout.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the problem, change, scope, and intended validation. However, it does not follow the required template. It omits the ELI5, Why, Linked Issue with a Fixes link, Visual Proof or N/A statement, AI Disclosure, Agent skill upstream boundary, Notes, and Checklist sections. Testing also does not report an actual outcome.

Resolution

Add all required template sections. Include an actual linked issue in the required Fixes format, state N/A with a reason for Visual Proof if applicable, complete the testing checkboxes and report the workflow result, and complete the remaining checklist items or explain why they do not apply.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@brennanb2025

Copy link
Copy Markdown
Contributor Author

The Windows SSH host checks failed before running tests because the test transform config now references projects under cloud/, while this workflow left that directory out of its checkout. This PR includes the complete cloud tree so those configs and their common base are available to every existing Windows host matrix cell. Application behavior is unchanged.

A fresh adversarial review confirmed the light-path criteria, traced all 14 local configs in the reference closure, and checked Git's sparse checkout rules against the required root files. No blocking findings, code fixes, or deferred bugs remain. Other sparse checkouts do not need this dependency.

Verification: Windows SSH host matrix and PR checks. All four Windows host matrix cells pass, including the previously failing x64 preview cell. Static analysis and typecheck, all 12 unit shards, relay integration, and the PR gate pass on the reviewed head. App QA and screenshots are not required for a CI-only change; no app run was performed.

For Brennan's review: the checkout addition and the cloud config references. No screenshots apply.

@brennanb2025
brennanb2025 merged commit 40fea68 into main Nov 1, 2026
61 checks passed
@brennanb2025
brennanb2025 deleted the brennanb2025/ci-ssh-windows-sparse-cloud branch November 1, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant