You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: remove low-value capability, copy, and source inventories - #36114
Remove 20 authored tests (27 expanded cases) from eight audited suites. Delete the published-capability inventory, installed Vitest source-text check, and worker receipt wording suite entirely; trim default-value, label, locale inventory, and duplicate schema examples from five others.
Keep 10 authored tests (11 expanded cases), with their callbacks and setup unchanged. Remove only the two timing entries for deleted suites. No production changes.
Validation: authenticated static reconstruction, retained-callback checks, formatting/lint receipts, and final diff review. Full PR CI must pass before merge. Removed copy and inventory alarms are intentionally lost; no equivalent replacement coverage is claimed.
This change removes test assertions across runtime, interface, shared-constant, and test-tooling areas. It also removes two test-duration entries from the CI shard timing file. Some test files retain other tests. No implementation code changes are described.
Priority: Low
Merge Risk: Low · up to 3a993
WSL selection and browser requests have less regression coverage. Restore focused checks or accept the coverage loss as follow-up.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Description check
The description explains the scope and validation, but it omits most required template sections, including ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing checklist details, Review, Notes…
Add the required template sections. Include a plain-language ELI5, user-facing before and after details, the reason and alternatives considered, a linked issue or the applicable maintainer exception, Visual Proof set to N/A with a reason, t…
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly identifies the main change: removing low-value capability, copy, and source inventory tests.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.
Full details: Description check
Explanation
The description explains the scope and validation, but it omits most required template sections, including ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing checklist details, Review, Notes, and the final Checklist.
Resolution
Add the required template sections. Include a plain-language ELI5, user-facing before and after details, the reason and alternatives considered, a linked issue or the applicable maintainer exception, Visual Proof set to N/A with a reason, testing steps and platforms, AI disclosure when applicable, review and compatibility notes, and completed checklist items.
Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Follow-up Comments
Keep unit tests for already-added and stopped WSL distros.
4-4: Trivial · Functional Correctness · Quick win
Keep unit tests for already-added and stopped WSL distros.
The removed test was the only unit test of canAddWslDistro and wslDistroStateLabel. No remaining test covers an already-added distro, which must show Already a host and stay disabled in the picker and submit button. No remaining test covers a stopped distro that stays selectable. A regression in either path would not fail the unit suite.
The WSL 1 exclusion has partial end-to-end coverage in tests/e2e/wsl-host-fake-transport.spec.ts, which checks that Ubuntu is preselected because Legacy is WSL 1. That spec does not check the already-added or stopped cases. Restore focused cases for those two states. The broader locale and copy inventory tests can stay removed.
Cover the reachable browser payloads, not an empty tabClose payload.
1-4: Trivial · Data Integrity & Integration · Quick win
Cover the reachable browser payloads, not an empty tabClose payload.
Current browser.tabClose callers pass { worktree: 'id:wt-1' }. The existing dispatcher test covers neither browser.tabClose nor page-only browser.tabSwitch. Add coverage for the reachable payloads.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 20 authored tests (27 expanded cases) from eight audited suites. Delete the published-capability inventory, installed Vitest source-text check, and worker receipt wording suite entirely; trim default-value, label, locale inventory, and duplicate schema examples from five others.
Keep 10 authored tests (11 expanded cases), with their callbacks and setup unchanged. Remove only the two timing entries for deleted suites. No production changes.
Validation: authenticated static reconstruction, retained-callback checks, formatting/lint receipts, and final diff review. Full PR CI must pass before merge. Removed copy and inventory alarms are intentionally lost; no equivalent replacement coverage is claimed.