Repository navigation
fix(wsl): a held pane whose distro could not be checked says so, not that it stopped - #35860
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[Low impact] The change affects wording and state labels on held WSL restore panes. The PR appears safe to merge, with a non-blocking readability issue in narrow panes. Findings
SummaryThe PR distinguishes a confirmed WSL stop from a running-state check that gave no answer.
Reviews (1) · Last reviewed commit: "fix(wsl): a held pane whose distro could..." · Reviewed by Greptile |
| 'components.native-chat.hostOutage.unverifiable', | ||
| "Orca couldn't check whether {{distro}} is running", | ||
| { distro } |
There was a problem hiding this comment.
The longer title can hide the distro name in narrow split panes. RemoteRuntimeRecoveryCard puts the title on one line with truncate, so users may see only “Orca couldn't check whether…” beside Start. Let this message wrap, or put it in the card's wrapping body, so users can read which distro could not be checked.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
ELI5
#35813 holds a restored WSL bridge pane instead of starting its distro when Orca can't prove the distro is running. When Orca couldn't even tell (the WSL running-list read gave no answer), the card still said " is stopped", which might not be true. It now says "Orca couldn't check whether is running", still with Start.
What Changed
terminal_held_wsl_distro_stopped:<distro>orterminal_held_wsl_distro_unverifiable:<distro>(wslDistroHoldMessage/parseWslDistroHoldinsrc/shared/wsl-distro-stopped-hold.ts).WslDistroStoppedCardpicks the title from it.data-terminal-wsl-distro-hold-stateattribute. The existing attribute keeps the distro name.components.native-chat.hostOutage.unverifiablein all 11 locales.stoppedandstartkeys that only en and de had are now translated in the other 9 too.Why
Wording follows the live / unverifiable / exited vocabulary: an unanswered read is "couldn't check", never a stop. A stopped-looking card for a running distro would send the user to Start something that already runs.
Flag-off: applies to WSL bridge panes, which exist with
ORCA_INTERNAL_WSL_HOSTSunset. It changes copy only.User risk: none; a title change on an existing card.
Linked Issue
Internal: follow-up to #35813 (e9 review, unverifiable copy).
Visual Proof
N/A. The copy is asserted in
WslDistroStoppedHoldCard.test.tsx.Testing
WslDistroStoppedHoldCard.test.tsx:daemon-pty-adapter-wsl-passive-restore-hold.test.ts: the hold namesstoppedorunverifiable.deferred-session-reattach-wsl-distro-stopped-hold.test.tsandWslHostStoppedCard.test.tsxtests still pass.pnpm tc,oxlint,check:code-quality:changed, the ast-grep gates, and the locale format check pass.pty-connection-*renderer tests failed; this PR doesn't touch them, and the 6 failing files pass when run alone (242/242).Agent skill upstream boundary
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)