Skip to content

test: cover editor reveal overlay restarts - #35683

Merged
AmethystLiang merged 1 commit into
mainfrom
test-editor-reveal-flash-restart
Oct 29, 2026
Merged

AmethystLiang merged 1 commit into
mainfrom
test-editor-reveal-flash-restart

Conversation

@AmethystLiang

@AmethystLiang AmethystLiang commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​13 $\color{#cf222e}{\Huge{\mathbf{−}}}$​7 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​6
Prod 0 0 0 0

Replace the repeat-key hook test with a component test that verifies a second flash replaces the overlay DOM node, resets its lifetime, and removes it when the restarted timer expires.

Validation: ORCA_BACKGROUND_LAUNCH=1 pnpm check:changed --maxWorkers=2 (all 21 checks passed).

CI cancellation and merge without waiting for CI requested by the maintainer.

@AmethystLiang
AmethystLiang merged commit 912ba1c into main Oct 29, 2026
1 of 3 checks passed
@AmethystLiang
AmethystLiang deleted the test-editor-reveal-flash-restart branch October 29, 2026 04:49
@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This test-only change appears safe to merge.

Summary

Replaces the repeat-flash hook test with a component test.

  • The repeat-flash test checks that the editor overlay is replaced and gets a fresh lifetime.

No actionable issues found.

Reviews (1) · Last reviewed commit: "test: cover editor reveal overlay restar..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant