Repository navigation
test: cover editor reveal overlay restarts - #35683
Merged
Merged
Conversation
[Low impact] This test-only change appears safe to merge. SummaryReplaces the repeat-flash hook test with a component test.
No actionable issues found. Reviews (1) · Last reviewed commit: "test: cover editor reveal overlay restar..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the repeat-key hook test with a component test that verifies a second flash replaces the overlay DOM node, resets its lifetime, and removes it when the restarted timer expires.
Validation: ORCA_BACKGROUND_LAUNCH=1 pnpm check:changed --maxWorkers=2 (all 21 checks passed).
CI cancellation and merge without waiting for CI requested by the maintainer.