You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Flash revealed editor tabs for terminal file links - #35656
Opening a terminal file link that points to an already-visible editor tab gave no visual confirmation that the click worked.
Solution
Briefly tint the revealed editor tab, including when it is already active. Repeat clicks restart the tint so each click gets feedback.
ELI5
A file link now makes the editor gently flash, so it is clear where the file opened.
What Changed
Added a per-editor reveal-flash store and overlay animation.
Triggered the flash after a terminal file link reveals an editor view.
Added tests for targeting, clearing, and repeated flashes.
Why
An existing active tab otherwise looks unchanged after a file-link click. A short, scoped visual cue confirms the action without moving focus or changing the document.
Linked Issue
Fixes #
Visual Proof
TODO: attach before/after visual proof for this UI behavior change.
Testing
Added automated coverage for editor reveal-flash targeting, timeout cleanup, and repeat-click animation restarts.
I manually tested these changes locally
Automated tests added/updated, or explained why not below
AI Disclosure
Review
Agent skill upstream boundary
Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.
Notes
Considered security, cross-platform support (Linux, Windows, Mac), Remote SSH, Mobile, backwards compatibility, and performance. The animation is renderer-only, scoped per editor view, and does not change file-opening behavior.
Checklist
This PR is small and focused
I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
Before/after screenshots or videos attached for UI changes, or N/A with reason
Self-reviewed for correctness, security, and performance
Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)
The reason will be displayed to describe this comment to others. Learn more.
Visible restarts remain untested
The repeat-click test checks only that the hook returns a new number. It never renders EditorRevealFlash, so removing key={flashKey} would leave this test passing while repeated clicks stop restarting the visible animation. Add a component test that flashes twice, checks that the second flash replaces the first DOM node, and checks that the overlay disappears after the timer.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Opening a linked file now flashes its editor view, including when the link has no line position. Each view has a separate flash key that clears after 1.2 seconds; a repeated flash restarts its timer. The active editor renders an aria-hidden overlay while its flash is active. The overlay uses the locate color and fades out.
Priority: Low
Merge Risk: Minimal · up to 9f77f
No merge-blocking issue is established. A component test would better protect repeated-flash behavior.
Pre-merge checks: 3 · 2
Failed checks: 2 warnings
Check name
Status
Explanation
Resolution
Description check
The description explains the problem, solution, user impact, implementation, and tests, but it is incomplete for the repository template. The required linked issue is empty, visual proof is marked TOD…
Add a valid issue reference after “Fixes #”. Attach before-and-after screenshots or a video, or write N/A with a valid reason if no visual proof is possible. Report manual testing and the results of lint, typecheck, test, and build, or stat…
Docstring Coverage
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 3 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the primary change: flashing editor tabs revealed by terminal file links.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the problem, solution, user impact, implementation, and tests, but it is incomplete for the repository template. The required linked issue is empty, visual proof is marked TODO for a UI change, and testing and validation checklist items remain unchecked.
Resolution
Add a valid issue reference after “Fixes #”. Attach before-and-after screenshots or a video, or write N/A with a valid reason if no visual proof is possible. Report manual testing and the results of lint, typecheck, test, and build, or state that CI will cover each check. Complete the remaining checklist items after review.
Full details: Docstring Coverage
Explanation
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 5 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Add a component-level test for the repeated-flash remount.
The new tests call only useEditorRevealFlashKey. They never render EditorRevealFlash, so nothing checks that the rendered <span> remounts when the key changes. If key={flashKey} is removed, the hook tests still pass. The span then stays mounted during a repeat reveal, and the editor-reveal-flash CSS animation does not restart. That is the behavior the PR describes for repeated clicks.
A rendering test should check DOM identity across a repeat flash:
Suggested fix
// @vitest-environment happy-dom// New file: src/renderer/src/components/tab-group/EditorRevealFlash.test.tsximport{act,render}from'@testing-library/react'import{afterEach,describe,expect,it,vi}from'vitest'import{EditorRevealFlash}from'./EditorRevealFlash'import{EDITOR_REVEAL_FLASH_MS,flashRevealedEditorView}from'./editor-reveal-flash'describe('EditorRevealFlash',()=>{afterEach(()=>{vi.useRealTimers()})it('remounts the flash span on a repeat flash',()=>{vi.useFakeTimers()const{ container }=render(<EditorRevealFlashviewStateId="view-d"/>)act(()=>flashRevealedEditorView('view-d'))constfirst=container.querySelector('.editor-reveal-flash')expect(first).not.toBeNull()act(()=>vi.advanceTimersByTime(EDITOR_REVEAL_FLASH_MS-100))act(()=>flashRevealedEditorView('view-d'))expect(container.querySelector('.editor-reveal-flash')).not.toBe(first)})})
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 94ef1487-0872-4a7b-83be-0cf922b381d7
Commits
Reviewing files that changed from the base of the PR and between 2dd9c82 and 9f77f28.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a terminal file link that points to an already-visible editor tab gave no visual confirmation that the click worked.
Solution
Briefly tint the revealed editor tab, including when it is already active. Repeat clicks restart the tint so each click gets feedback.
ELI5
A file link now makes the editor gently flash, so it is clear where the file opened.
What Changed
Why
An existing active tab otherwise looks unchanged after a file-link click. A short, scoped visual cue confirms the action without moving focus or changing the document.
Linked Issue
Fixes #
Visual Proof
TODO: attach before/after visual proof for this UI behavior change.
Testing
Added automated coverage for editor reveal-flash targeting, timeout cleanup, and repeat-click animation restarts.
I manually tested these changes locally
Automated tests added/updated, or explained why not below
AI Disclosure
Review
Agent skill upstream boundary
Notes
Considered security, cross-platform support (Linux, Windows, Mac), Remote SSH, Mobile, backwards compatibility, and performance. The animation is renderer-only, scoped per editor view, and does not change file-opening behavior.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)