Repository navigation
Plugins: turning off auto-update stops an update already in progress - #35642
Conversation
A pass already waiting on the catalog or kill list could still install after the user turned automatic updates off. Recheck the setting just before the install starts.
[Medium impact] The PR appears safe to merge; the install callback now checks the setting after the helper’s file reads. SummaryThe PR checks the auto-update setting immediately before calling
Reviews (2) · Last reviewed commit: "fix(plugins): recheck the auto-update se..." · Reviewed by Greptile |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Walkthrough
Priority: Merge Risk:
|
There was a problem hiding this comment.
Actionable comments posted: 1

Review info
-
Run configuration-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
1f1d0bb4-54d2-40a0-9056-92dfc113446b
Files selected for processing: 2-
src/main/plugins/catalog/plugin-auto-updater.test.tssrc/main/plugins/catalog/plugin-auto-updater.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
-
The approval step awaits the old version's recipe files before installing, so the check now runs at the install call itself.
ELI5
If you turned off automatic plugin updates while Orca was in the middle of checking for one, that check could still finish and install the update you just said you didn't want.
What Changed
Why
Follow-up from a review thread on #35470. The install is the only step that changes what the user runs, so checking immediately before it closes the window with one line; cancelling the network requests themselves would add plumbing for no user-visible benefit.
Linked Issue
Follow-up from #35470.
Visual Proof
N/A — background update logic only.
Testing
Notes
Same code runs on local, headless and remote hosts.