Skip to content

Plugins: turning off auto-update stops an update already in progress - #35642

Merged
nwparker merged 2 commits into
mainfrom
nwparker/plugin-autoupdate-optout
Oct 29, 2026
Merged

nwparker merged 2 commits into
mainfrom
nwparker/plugin-autoupdate-optout

Conversation

@nwparker

@nwparker nwparker commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​10 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​10
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​5 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​4

ELI5

If you turned off automatic plugin updates while Orca was in the middle of checking for one, that check could still finish and install the update you just said you didn't want.

What Changed

  • Before: the "automatic updates on?" setting was read at the start of a pass and before each plugin, but not again after the slow network steps (catalog preview, kill-list refresh). Turning the setting off only stopped future passes.
  • After: the setting is read again right before the install starts. If it is now off, the pass installs nothing for that plugin.

Why

Follow-up from a review thread on #35470. The install is the only step that changes what the user runs, so checking immediately before it closes the window with one line; cancelling the network requests themselves would add plumbing for no user-visible benefit.

Linked Issue

Follow-up from #35470.

Visual Proof

N/A — background update logic only.

Testing

  • Unit test: turning auto-update off while the pass waits on the kill list installs nothing (fails without the fix).

Notes

Same code runs on local, headless and remote hosts.

A pass already waiting on the catalog or kill list could still install after
the user turned automatic updates off. Recheck the setting just before the
install starts.
@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the install callback now checks the setting after the helper’s file reads.

Summary

The PR checks the auto-update setting immediately before calling installer.install.

  • Plugin updates stop if auto-update is turned off before installation.

Reviews (2) · Last reviewed commit: "fix(plugins): recheck the auto-update se..." · Reviewed by Greptile

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 546654b2-881a-42b9-bd2d-86734e17fef0
Commits

Reviewing files that changed from the base of the PR and between 8fb356a and c68f0a2.

Files selected for processing: 1
  • src/main/plugins/catalog/plugin-auto-updater.ts
Walkthrough

After refreshing the kill list, PluginAutoUpdater.updateOne checks whether auto-update is still enabled. If it is disabled, the updater returns without installing the release. A test covers disabling auto-update while the kill-list refresh is in progress.

Priority: Normal

Merge Risk: Low · previous review 8fb35

A narrow VM-recipe update path can still install after the user disables automatic updates; recheck the setting before installation.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main behavior change: disabling automatic updates prevents an update already in progress from installing.
Description check Passed The description includes the required core sections, explains the user-facing behavior and implementation, identifies the related issue, documents the lack of visual changes, and records an automated …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required core sections, explains the user-facing behavior and implementation, identifies the related issue, documents the lack of visual changes, and records an automated unit test. The scope and rationale are clear.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1f1d0bb4-54d2-40a0-9056-92dfc113446b
Commits

Reviewing files that changed from the base of the PR and between 110c427 and 8fb356a.

Files selected for processing: 2
  • src/main/plugins/catalog/plugin-auto-updater.test.ts
  • src/main/plugins/catalog/plugin-auto-updater.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

The approval step awaits the old version's recipe files before installing, so
the check now runs at the install call itself.
@nwparker
nwparker merged commit e3a07e5 into main Oct 29, 2026
40 checks passed
@nwparker
nwparker deleted the nwparker/plugin-autoupdate-optout branch October 29, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant