Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion config/scripts/vitest-node-runtime-files.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ const NODE_RUNTIME_INCLUDE = [
]

/** `filters` limits the SQLite import scan to the tests a filtered CLI run can select. */
// Emits and sends process messages, a channel node-runtime workers reserve for Vitest's own IPC.
const PROCESS_MESSAGE_TESTS = new Set(['src/main/ai-vault/session-scanner-service-search.test.ts'])

export function getNodeRuntimeInclude({ filters } = {}) {
return [...NODE_RUNTIME_INCLUDE, ...findSqliteRuntimeTests({ filters })]
return [
...NODE_RUNTIME_INCLUDE,
...findSqliteRuntimeTests({ filters }).filter((file) => !PROCESS_MESSAGE_TESTS.has(file))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Routing exception lacks test coverage

The current routing checks compare the config with getNodeRuntimeInclude() itself, so removing this filter would still pass those checks. Add a focused assertion that session-scanner-service-search.test.ts stays out of the Node list while another session-search-indexer-test-fixture user stays in it. This would protect the exception that fixes the CI failure.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

]
}
Loading