Skip to content

test: remove 24 low-value test cases and eight suites - #35147

Merged
OrcaWin merged 1 commit into
mainfrom
test-audit-712-low-value-wsl-tests
Oct 28, 2026
Merged

OrcaWin merged 1 commit into
mainfrom
test-audit-712-low-value-wsl-tests

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator
Files Added Deleted Net
Test 12 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3 $\color{#cf222e}{\Huge{\mathbf{−}}}$​425 $\color{#cf222e}{\Huge{\mathbf{−}}}$​422
Prod 1 0 $\color{#cf222e}{\Huge{\mathbf{−}}}$​3 $\color{#cf222e}{\Huge{\mathbf{−}}}$​3

Remove 24 low-value test registrations across twelve suites, deleting eight suites entirely. Remove mock-call and payload inventories, memo-token checks, prompt prose replays, and updater ordering that preserves a stale snapshot overwriting a newer event. Production code is unchanged.

Keep breadcrumb privacy/timing, path and extension admission, same-host versus retired-host pairing, and option-looking Git ref safety. Retained test bodies are unchanged. Remove only three deleted suites’ existing timing entries.

Validation: isolated enumeration, routing, retained callback/support identity, formatting and lint passed where applicable. Four retained suites have eleven expanded cases. Runtime verification is pending CI; this stays a draft while batching removals.

@OrcaWin OrcaWin changed the title test: remove mock-only WSL suites and wrapper inventories test: remove four mock-only suites and wrapper inventories Oct 28, 2026
@OrcaWin OrcaWin changed the title test: remove four mock-only suites and wrapper inventories test: remove five low-value suites and wrapper inventories Oct 28, 2026
@OrcaWin OrcaWin changed the title test: remove five low-value suites and wrapper inventories test: remove 20 low-value test cases and six suites Oct 28, 2026
@OrcaWin
OrcaWin force-pushed the test-audit-712-low-value-wsl-tests branch from d51b691 to 3cde23d Compare October 28, 2026 21:27
@OrcaWin OrcaWin changed the title test: remove 20 low-value test cases and six suites test: remove 24 low-value test cases and eight suites Oct 28, 2026
@OrcaWin
OrcaWin marked this pull request as ready for review October 28, 2026 21:35
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8e8cf630-397e-4aee-97b6-09a9d19b56fe
Commits

Reviewing files that changed from the base of the PR and between cf794d9 and 3cde23d.

Files selected for processing: 13
  • config/scripts/ci-shard-timings.json
  • src/main/wsl/wsl-host-client-declaration.test.ts
  • src/main/wsl/wsl-host-connect-request.test.ts
  • src/renderer/src/components/native-chat/native-chat-resolved-path-ownership.test.ts
  • src/renderer/src/components/right-sidebar/SourceControl.resolve-conflicts-prompt.test.ts
  • src/renderer/src/components/right-sidebar/checks-panel-pr-refresh-breadcrumb.test.ts
  • src/renderer/src/components/terminal-pane/terminal-eviction-exempt-tabs.test.ts
  • src/renderer/src/components/terminal-pane/terminal-pane-split-completion.test.ts
  • src/renderer/src/hooks/ipc-events/ssh-managed-server-refusal-toast.test.ts
  • src/renderer/src/hooks/ipc-events/updater-status-ipc-bridge.test.ts
  • src/renderer/src/lib/worktree-owner-rows-token.test.ts
  • src/renderer/src/web/web-preload-api-wsl-move-orchestrator.test.ts
  • src/shared/file-preview-kind.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable defects were found.

Summary

Removes 24 test registrations across twelve files, deletes eight suites, and removes three matching CI timing entries. Application code is unchanged.

  • Selected WSL connection checks are no longer in the test suite.
  • Selected terminal parking and split checks are no longer in the test suite.
  • Selected SSH notice and updater status checks are no longer in the test suite.
  • Selected attachment, conflict-prompt, breadcrumb, and preview checks leave their test suites.
  • The worktree ownership-token test is no longer in the suite.

Acknowledged intent: OrcaWin explicitly identifies the removed coverage as low-value and the updater test as preserving an unwanted stale-snapshot overwrite. These intentional removals are not reported as findings.

Reviews (1) · Last reviewed commit: "test: remove 24 low-value test cases and..." · Reviewed by Greptile

@OrcaWin
OrcaWin merged commit 3f56b8f into main Oct 28, 2026
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant