Skip to content

ci: seed hosted Linux packaging and mobile bundle caches on main, and stop PR-local saves - #34672

Merged
OrcaWin merged 1 commit into
mainfrom
ci/cache-quota-gaps
Oct 28, 2026
Merged

OrcaWin merged 1 commit into
mainfrom
ci/cache-quota-gaps

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator
Files Added Deleted Net
Test 5 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​62 $\color{#cf222e}{\Huge{\mathbf{−}}}$​14 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​48
Prod 7 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​137 $\color{#cf222e}{\Huge{\mathbf{−}}}$​9 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​128

Follow-up to #34576, #34588, #34600 and #34605. The Actions cache is at 9.4 of 10 GB. This PR closes the remaining gaps where hosted PRs either missed a cache that nothing on main seeded, or saved PR-scoped copies that nothing restored.

Changes

Gap Change
electron-builder-linux-* was never in GitHub's store (package missed 0/1; the release's lockfile-keyed copy was evicted) package and the release seed now key on the Electron and electron-builder versions, the same scheme as electron-builder-win-*. The new warm-linux-electron job (hosted ubuntu-24.04, main only) seeds the exact key and path. On a miss it downloads the toolsets electron-builder fetches for AppImage/deb/rpm (icons, fpm, 7zip, AppImage runtime) through app-builder-lib's own toolset API.
Linux x64 Electron native-modules was never seeded (38 PR entries) warm-linux-electron installs with native-runtime: electron, like warm-windows-electron. On PRs, prepare-native-runtime now restores without saving for hosted Linux Electron, as it already does for Windows.
setup-ruby bundler cache (15 PR entries) bundler-cache: true saves on every miss and cannot be restore-only. Mobile verify now runs setup-ruby without it, restores mobile/vendor/bundle under a mobile-bundle-v1-<os>-<platform>-<ruby ABI>-<Gemfile hash> key with no restore-keys, and runs bundle install. Only the new warm-mobile-bundle job (main, ubuntu-24.04-arm) saves it.
node-cache-* Mobile main-tests restored 652 MB in 11.1s, then linked in about 10s. A PR's direct install of the same two lockfiles takes 14–16s, so restoring loses. The glibc-floor container jobs wrote 2 × 417 MB, and their direct installs took 6–9s. Both now set cache-pnpm-store: 'false'.
bun-* Every setup-bun already has no-cache: true. All 21 entries predate the #34600 merge, so no change is needed.
CodeQL overlay-base No change. CodeQL runs as default setup, so there is no workflow to configure. The only control in codeql-action is CODEQL_OVERLAY_DATABASE_MODE, which needs an advanced-setup workflow and turns overlay analysis off entirely. There is no retention input.

Why none of this can serve wrong content

  • Electron-builder caches are version-addressed directories, so an older restore only re-downloads. Restore-keys cannot cross path sets, which keeps them away from the release's electron-builder-linux-x64-* entries.
  • The native-module keys are unchanged, and restored addons are still probed.
  • The bundle key has no restore-keys, and BUNDLE_FROZEN makes bundle install verify against the lockfile.

… stop PR-local saves

- Warm electron-builder-linux-<versions> and the hosted ubuntu-24.04 Electron native modules
- PRs restore hosted Linux Electron native modules without saving
- Replace mobile verify's bundler-cache with a restore of a warmup-saved bundle
- Drop the pnpm store cache where a direct install was faster (mobile main, glibc-floor containers)
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb657dd5-7a0b-4d3b-8b2a-3481b8dfd7fc
Commits

Reviewing files that changed from the base of the PR and between 3a4ac54 and c9c2ba9.

Files selected for processing: 12
  • .github/actions/prepare-native-runtime/action.yml
  • .github/workflows/ci-cache-warmup-platform-jobs.yml
  • .github/workflows/ci-cache-warmup-platforms.yml
  • .github/workflows/mobile.yml
  • .github/workflows/node-server-tests.yml
  • .github/workflows/pr.yml
  • .github/workflows/release-cut.yml
  • config/scripts/ci-dependency-download-cache.test.mjs
  • config/scripts/ci-native-cache.test.mjs
  • config/scripts/mobile-release-check-scope.test.mjs
  • config/scripts/mobile-test-change-scope.test.mjs
  • config/scripts/mobile-typecheck-cache.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin
OrcaWin merged commit e0f32dc into main Oct 28, 2026
85 checks passed
audichuang added a commit to audichuang/orca that referenced this pull request Oct 28, 2026
… stop PR-local saves (stablyai#34672)

- Warm electron-builder-linux-<versions> and the hosted ubuntu-24.04 Electron native modules
- PRs restore hosted Linux Electron native modules without saving
- Replace mobile verify's bundler-cache with a restore of a warmup-saved bundle
- Drop the pnpm store cache where a direct install was faster (mobile main, glibc-floor containers)

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>

(cherry picked from commit e0f32dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant