Repository navigation
fix(browser): stop malformed localhost pages from freezing the new tab page probe - #34427
Conversation
…b page probe The title and icon-link regexes rescanned the rest of the body from every unclosed opener, so a 192 KB page of repeated '<link ' or '<title>' blocked the main or runtime event loop for seconds. Scan tags forward only.
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the problem, mechanism, performance impact, and testing results, but it does not follow the required template. It lacks an actual linked issue, required section headings, visu… | Add the required template sections. Include a direct issue link under Linked Issue, complete Visual Proof with attachments or N/A plus a reason, document testing and platforms, complete AI Disclosure when applicable, and address the Notes a… |
| Docstring Coverage | |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surv… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: preventing malformed localhost pages from freezing the new tab page probe. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Description check
-
Explanation
The description explains the problem, mechanism, performance impact, and testing results, but it does not follow the required template. It lacks an actual linked issue, required section headings, visual proof or an N/A explanation, testing checklist details, and the remaining checklist information.
Resolution
Add the required template sections. Include a direct issue link under Linked Issue, complete Visual Proof with attachments or N/A plus a reason, document testing and platforms, complete AI Disclosure when applicable, and address the Notes and Checklist items.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
The browser's new tab page probes local servers for their title and icon. A localhost page full of unclosed
<linkor<title>tags could freeze Orca's main process, or the runtime server for a remote workspace, for seconds. Those pages now parse in a few milliseconds.The title and icon-link regexes rescanned the rest of the body from every opener that had no closing
>or</title>, so the parse grew quadratically with page size. It runs synchronously, so the 1.5 s HTTP timeout couldn't cut it short. Both now scan forward once: find the opener, thenindexOf('>'), then continue from there. Titles and icons come out the same as before for every input (real sites plus a 200k-case differential fuzz against the old regexes). The loopback, same-origin and size checks are unchanged.Time spent in
probeWorkspacePortPagewith a loopback server serving each page:<title>ok</title>+'<link '.repeat(32000)(192 KB)'<title>'.repeat(27000)(189 KB)Linear: STA-11898