Repository navigation
test: remove 81 wrapper replay and inventory tests - #34426
Conversation
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the main test removals and validation status, but it omits most required template sections, including ELI5, Why, Linked Issue, Visual Proof or N/A, Testing checkboxes, AI Disc… | Complete the required template sections. Add the linked issue, explain why this approach was selected, state Visual Proof as N/A with a reason if applicable, document testing and platforms, complete the relevant checkboxes, and address cros… |
-
Check name Status Explanation Title check The title clearly summarizes the main change: removing 81 wrapper, replay, and inventory tests. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files.
-
Full details: Description check
-
Explanation
The description explains the main test removals and validation status, but it omits most required template sections, including ELI5, Why, Linked Issue, Visual Proof or N/A, Testing checkboxes, AI Disclosure, Review, boundary assessment, Notes, and Checklist.
Resolution
Complete the required template sections. Add the linked issue, explain why this approach was selected, state Visual Proof as N/A with a reason if applicable, document testing and platforms, complete the relevant checkboxes, and address cross-platform, SSH, compatibility, security, and performance considerations.
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
0b238122-31e1-4e77-944d-7e2a6ed7119f
-
config/scripts/ci-shard-timings.jsonsrc/renderer/src/runtime/runtime-antigravity-accounts-client.test.tssrc/renderer/src/runtime/runtime-client-events.test.tssrc/renderer/src/runtime/runtime-git-client-branch-line-total.test.tssrc/renderer/src/runtime/runtime-git-client-merge.test.tssrc/renderer/src/runtime/runtime-git-client.test.tssrc/renderer/src/runtime/runtime-git-mutation-in-flight-client.test.tssrc/renderer/src/runtime/runtime-git-worktree-scope-client.test.tssrc/renderer/src/runtime/runtime-host-account-sign-in-client.test.tssrc/renderer/src/runtime/runtime-jira-client.test.tssrc/renderer/src/runtime/runtime-jira-favourite-filters-client.test.tssrc/renderer/src/runtime/runtime-layout-client.test.tssrc/renderer/src/runtime/runtime-provider-accounts-client.test.ts
-
- src/renderer/src/runtime/runtime-git-client-merge.test.ts
- src/renderer/src/runtime/runtime-git-client-branch-line-total.test.ts
- src/renderer/src/runtime/runtime-git-mutation-in-flight-client.test.ts
- src/renderer/src/runtime/runtime-host-account-sign-in-client.test.ts
- src/renderer/src/runtime/runtime-antigravity-accounts-client.test.ts
- src/renderer/src/runtime/runtime-jira-favourite-filters-client.test.ts
- src/renderer/src/runtime/runtime-git-worktree-scope-client.test.ts
- src/renderer/src/runtime/runtime-layout-client.test.ts
- src/renderer/src/runtime/runtime-client-events.test.ts
- config/scripts/ci-shard-timings.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
-
| expect(claudeRemoveLocal).not.toHaveBeenCalled() | ||
| }) | ||
| }) | ||
| describe('provider account mutations', () => {}) |
There was a problem hiding this comment.
Remove the empty mutation suite.
When Vitest runs this file, describe('provider account mutations', () => {}) contains no tests. Vitest 5.0.5 marks that suite as failed, and this repository does not enable passWithNoTests. The test command therefore fails even if the retained tests pass. Delete the registration along with its tests. (raw.githubusercontent.com)
c6c1cb6 to
cc84758
Compare
config/electron-builder.config.cjs: kept upstream configuration and restored ORCA_NO_PUBLISH=1 => publish:null. config/scripts/build-computer-macos.mjs: kept upstream --build-system native fix for Swift 6.4; supersedes our per-triple scratch paths. package.json: kept upstream byte-for-byte, version 1.4.243; packaging injects 1.4.244-blowzer.1. src/main/claude-accounts/claude-account-selection.ts: retained upstream folder/runtime/organization handling and restored autoSwitchEnabled plus its notifying setter. src/main/claude-accounts/service.ts: kept upstream sign-in flow and restored queued automatic selection, user-action precedence, and setting setter. src/main/provider-account-services.ts: kept upstream agent-view reconciliation and background runtime protections; restored auto-switch subscription/callback. src/main/rate-limits/claude-profile-usage.test.ts: retained upstream OAuth renewal cases and restored successful-reading account provenance case. src/main/runtime/rpc/methods/accounts.ts: kept upstream host sign-in RPCs and restored accounts.setClaudeAutoSwitch with accounts-admin permission. src/main/updater/updater-setup.ts: kept upstream proxy handling and packaged-app initialization; restored no-feed/no-check kill switch. src/renderer/src/components/settings/accounts-search.test.ts: accepted upstream deletion in 84494ce (stablyai#34234); no replacement suite found, so dropped our one search case. src/renderer/src/i18n/locales/en.json: kept upstream names/translations and restored the seven auto-switch translation lines. src/renderer/src/runtime/runtime-provider-accounts-client.test.ts: retained upstream removals from stablyai#34426 and restored only our local/remote auto-switch mutation case. src/shared/global-settings-types.ts: retained upstream types/comments and restored optional claudeAutoSwitchEnabled. Adapted automatic-switch restart tests to upstream grouped sessions and carried its optional system-default folder/login snapshot through the automatic-switch event.
Removes 81 low-value test registrations across twelve files, deleting five suites entirely. This removes Jira favourite-filter, Antigravity-account, Git merge, branch-line-count and mutation-state wrapper suites, plus mocked dispatch/results and event-kind inventories in surviving files.
Keeps 39 registrations for real query limits, account aggregation and subscription races, cancellation and retry, workspace identity and receipt rejection, SSH authority admission, and layout sequencing/resync/backoff. Production code is unchanged; five obsolete CI timing keys are removed.
Validation: static parsing, registration/callback preservation, discovery, formatting, lint and reliability checks passed. Full CI and fresh passing results for all seven retained files are required before merge. The exact candidate has been revalidated against current main.