You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: retry transient 5xx responses in the runner demand report - #34337
Follow-up to #34324. The first post-merge dispatch (run) got past the interval split but then hit a transient Actions API: 500. A report makes ~600 API calls, so a single 5xx shouldn't fail it. This retries 5xx responses up to 3 attempts with 5 s and 10 s backoff. 4xx responses still fail immediately.
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: bdd531ce-6afe-40eb-9796-564239d9e75a
Commits
Reviewing files that changed from the base of the PR and between 230c9a9 and 56ae9aa.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
Walkthrough
The api helper retries GitHub Actions API responses with status 500 or higher, for up to three attempts. It waits 5 seconds after the first failure and 10 seconds after the second. It returns JSON for successful responses. It throws Actions API: <status> for responses below 500 and after the final failed attempt.
Priority: Low
Merge Risk: Low · previous review 230c9
Cancel failed response bodies to avoid retaining connection resources during the report. The risk is bounded and does not appear to block merging.
Pre-merge checks: 3 · 2
Failed checks: 2 warnings
Check name
Status
Explanation
Resolution
Description check
The description explains the failure, the retry behavior, and the backoff intervals, but it omits most required template sections, including ELI5, What Changed, Why, Linked Issue, Visual Proof, Testin…
Complete the required template sections. Link the actual issue, state N/A with a reason for Visual Proof if applicable, document testing and platform coverage, address AI Disclosure and review considerations, and complete the checklist.
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 3 passed
Check name
Status
Explanation
Title check
The title clearly identifies the main change: retrying transient 5xx responses in the runner demand report.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the failure, the retry behavior, and the backoff intervals, but it omits most required template sections, including ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing, AI Disclosure, Review, Notes, and Checklist.
Resolution
Complete the required template sections. Link the actual issue, state N/A with a reason for Visual Proof if applicable, document testing and platform coverage, address AI Disclosure and review considerations, and complete the checklist.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: d946645c-8ab7-4c9d-84f3-4db48ec4ca19
Commits
Reviewing files that changed from the base of the PR and between 72a4fd1 and 230c9a9.
Files selected for processing: 1
config/scripts/ci-runner-demand.mjs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
The retry loop leaves non-success response bodies undisposed. Cancel each failed body before the backoff or final error. The report limits job requests to four concurrent requests, so the evidence supports a resource-leak risk but not a major or indefinite stall.
Suggested fix
if (response.ok) {
return response.json()
}
+ await response.body?.cancel()
if (response.status < 500 || attempt === 3) {
throw new Error(`Actions API: ${response.status}`)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #34324. The first post-merge dispatch (run) got past the interval split but then hit a transient
Actions API: 500. A report makes ~600 API calls, so a single 5xx shouldn't fail it. This retries 5xx responses up to 3 attempts with 5 s and 10 s backoff. 4xx responses still fail immediately.