Repository navigation
fix(i18n): improve Korean disabled-state labels - #34155
Conversation
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check |  |
Issue #34140 requires “끔” for the disabled state in two places and “켬” for the enabled provider badge. Current PR description: (1) Color Contrast Off option changes “끄다” to “끔”, which meets the issue.… |
Set the Korean value of auto.components.stats.usage.overview.sections.statusOff to “끔”. Set the Korean value of auto.components.stats.usage.overview.sections.statusEnabled to “켬”. Keep auto.components.settings.contrast.off as “끔”, and keep … |
| Out of Scope Changes check | |
The raw summary of src/renderer/src/i18n/locales/ko.json reports changed Korean wording for “the Orca CLI unavailable startup dialog” (+5/-5 lines). The PR objectives summary also states that two runt… | Remove the Korean runtimeRpc.startupFailure wording changes from this PR so that only the usage status and contrast label values change. If those translations are still wanted, move them to a separate PR that references its own issue. After… |
-
Check name Status Explanation Title check The title clearly identifies the main change: improving Korean labels for disabled states. It is concise and relevant to the locale updates. Description check The description includes the required sections, linked issue, user-facing changes, rationale, testing details, visual proof, AI disclosure, and scope notes. It also clearly states that full applicatio… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Full details: Description check
-
Explanation
The description includes the required sections, linked issue, user-facing changes, rationale, testing details, visual proof, AI disclosure, and scope notes. It also clearly states that full application testing and standalone validation commands were not run locally and are left to CI.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Full details: Linked Issues check
-
Explanation
Issue
#34140requires “끔” for the disabled state in two places and “켬” for the enabled provider badge. Current PR description: (1) Color Contrast Off option changes “끄다” to “끔”, which meets the issue. (2) Usage overview disabled provider badge changes to “꺼짐”, not “끔”, so it does not meet the issue. (3) The enabled provider badge keeps “활성화됨”, not “켬”, so it does not meet the issue. The PR objectives summary reports a different state (enabled badge “활성”, disabled label “비활성”), which also does not match#34140. The raw summary reports changed usage status labels, but the diff tool could not read the changed blobs, and the override file read was truncated before the relevant keys. The exact committed values of auto.components.stats.usage.overview.sections.statusOff and statusEnabled are therefore not confirmed from source. Based on the current PR description, the linked requirements are not met.Resolution
Set the Korean value of auto.components.stats.usage.overview.sections.statusOff to “끔”. Set the Korean value of auto.components.stats.usage.overview.sections.statusEnabled to “켬”. Keep auto.components.settings.contrast.off as “끔”, and keep the matching repair override in config/scripts/locale-ko-key-overrides.json consistent with these values. Update the PR description to match the final values.
Full details: Out of Scope Changes check
-
Explanation
The raw summary of src/renderer/src/i18n/locales/ko.json reports changed Korean wording for “the Orca CLI unavailable startup dialog” (+5/-5 lines). The PR objectives summary also states that two runtimeRpc.startupFailure strings (“CLI 없이 계속” / “Orca CLI를 사용할 수 없습니다”) were translated and carried over from
#14044. Neither the current PR description nor issue#34140mentions this change. Issue#34140covers only the Color Contrast option and the usage provider status labels. The startup dialog strings are not among the affected locations, so this change is unrelated to#34140. The current PR description also states that exactly two catalog values changed, which conflicts with the +5/-5 line count in the raw summary. The diff tool could not confirm the exact changes.Resolution
Remove the Korean runtimeRpc.startupFailure wording changes from this PR so that only the usage status and contrast label values change. If those translations are still wanted, move them to a separate PR that references its own issue. After the change, confirm that the ko.json diff contains only the labels named in
#34140.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
사용량 통계의 비활성 상태는 비활성으로, 터미널 색상 대비의 Off 옵션은 끔으로 수정했습니다. 활성 상태의 기존 활성화됨 표현은 유지했습니다. 번역 재생성 시에도 두 표현이 유지되도록 한국어 키별 보정 설정에 반영했습니다.
6898481 to
1970952
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
ko.json:4693
src/renderer/src/i18n/locales/ko.json:4693
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAlign the provider badge with the reported Korean target.
Disabled providers use
statusOff, which currently resolves to비활성instead of꺼짐. Update both the catalog value and its repair override. Otherwise localization repair can restore비활성.Suggested fix
"auto.components.stats.usage.overview.sections.statusOff": { - "ko": "비활성" + "ko": "꺼짐" },
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
8651af50-e8df-4eb9-a978-89fa80008110
-
config/scripts/locale-ko-key-overrides.jsonsrc/renderer/src/i18n/locales/ko.json
-
- config/scripts/locale-ko-key-overrides.json
- src/renderer/src/i18n/locales/ko.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
-
|
I’ve updated the label next to the agent to “비활성,” which seems more appropriate than “꺼짐” in this context. |
…ings Carried over from stablyai#14044. Co-authored-by: JeongSu <zz1996zz@naver.com>
|
Thanks @RyuWoong! Maintainer edits pushed to this branch:
Localization verify scripts and |
ELI5
Make two Korean “Off” labels read more naturally in their UI contexts.
What Changed
The enabled provider badge keeps its existing “활성화됨” wording.
Why
“끄다” means “to turn off”. These labels describe a state or setting value rather than an action.
“꺼짐” fits the provider status badge, while “끔” fits the compact Color Contrast option. Key-specific overrides keep the changes limited to these contexts.
Linked Issue
Fixes #34140
Visual Proof
Before/after screenshots were captured and inspected in light and dark themes using the actual
ProviderUsageRowandTerminalContrastSettingcomponents with sample provider data.Full Electron application interaction was not tested.
Testing
Verified locally on macOS:
ORCA_BACKGROUND_LAUNCH=1 pnpm check:changed --maxWorkers=2— all 20 selected checks passed.git diff --checkpassed.Windows, Linux, SSH, and mobile were not tested. Full standalone lint, typecheck, test, and build commands were not run; the repository’s changed-file verification gate was used.
No new test files were added for this static wording change. The existing localization repair function was exercised directly, and the repository verification gate passed.
AI Disclosure
Prepared with OpenAI Codex, which assisted with locating translation keys, editing translations and overrides, running checks, capturing component screenshots, and drafting this PR.
Review
Self-reviewed both changed labels against their actual component call sites.
The enabled provider badge and Enable action button retain their existing wording. Color Contrast retains its Automatic, Off, and Custom options.
Agent skill upstream boundary
Notes
Korean translation text and localization overrides only. No runtime behavior, permissions, paths, shortcuts, platform-specific logic, remote execution, mobile logic, or compatibility changes.
Checklist
pnpm lint,pnpm typecheck,pnpm test, andpnpm buildvalidation completed locally or confirmed by CILocal validation: all 20 checks selected by
pnpm check:changed --maxWorkers=2passed. Full lint, typecheck, test, and build validation is left to CI.