Repository navigation
test(wsl-mover): orchestrator automatic path never reconnects a serving host (E9) - #34110
Merged
nwparker merged 1 commit intoOct 26, 2026
Merged
Conversation
… serving host, and adds a bridge host once (E9)
nwparker
force-pushed
the
nwparker/wsl-d3a-landing-connect-test
branch
from
October 26, 2026 22:28
8f027a3 to
2b8420a
Compare
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
This adds a test for the landing branch only, with no product change. It checks the WSL move orchestrator's automatic path from end to end against a real WSL host service. First the orchestrator readies the host, then the move driver reaches it in automatic mode. The test makes sure the host is never reconnected when it's already serving, and that a bridge user's host is added only once.
What Changed
src/main/ipc/wsl-move-orchestrator-host-connect.test.ts, which uses a realWslHostServicewith the shared fake connector. It covers two cases:connectWslMoveHostService(..., 'automatic'). The connector is never connected or disconnected again.prepareWslMoveHostadds the host once withstartIfStopped: false, and the driver's automatic reach adds no further connect.Why
The E9 connect change (
wsl-move-host-connect.ts) and the orchestrator's own host readiness both reach the host before a move. This test pins the order: prepare first, then the driver's automatic path. That way, an automatic move never adds a reconnect, which would bump the host's liveness generation.Linked Issue
N/A (internal tracker: D3a, E9)
Visual Proof
N/A: this only adds a test.
Testing
service.connectinstead ofensureForRuntimeCall.Review
Agent skill upstream boundary
Notes
This is based on the landing branch, which owns
wsl-move-host-connect.ts. Merge it into land-2 at your discretion.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)