fix(mobile): use desktop's check rules and fix-checks prompt in the PR panel by AmoabaKelvin · Pull Request #34014 · stablyai/orca

AmoabaKelvin · 2026-10-26T17:10:30Z

	Files	Added	Deleted	Net
Test	22	$\color{#1a7f37}{\Huge{\mathbf{+}}}$314	$\color{#cf222e}{\Huge{\mathbf{−}}}$592	$\color{#cf222e}{\Huge{\mathbf{−}}}$278
Prod	89	$\color{#1a7f37}{\Huge{\mathbf{+}}}$2716	$\color{#cf222e}{\Huge{\mathbf{−}}}$2212	$\color{#1a7f37}{\Huge{\mathbf{+}}}$504

Stacked on #34011: review the commits after 43798d5.

ELI5

The phone's PR checks list, labels and "Fix with AI" button followed rules of their own. Now they use desktop's rules, and the agent started from the phone gets the same failing-log details desktop gives it.

What Changed

Each item is from the mobile/desktop parity audit (source-control report, plus agent-sessions #6 / #14 and tasks #18).

Capitalize app name to Orca for desktop installs #11 / agent-sessions Improve update experience: toasts, graceful restart, sidebar indicator #14 Fix-checks prompt has the failing logs.
- Desktop's details loop is now collectFixChecksPromptDetails (with hasGitHubCheckHandle and isBrokenCheck) in src/shared/pr-checks-fix-prompt.ts.
- The checks panel and the phone both use it.
- Before, the phone sent check names and URLs only. Now it sends the failing step log tails for up to five broken checks.
- The resolve-conflicts prompt now names the worktree path, as desktop does.
agent-sessions Fix MaxListenersExceededWarning with singleton PTY dispatcher #6 Saved agent arguments apply. Dropped from this PR: AI fix actions use the + menu's agent picker and remember chat or terminal #31310 landed the same change on main first.
Add Orca logo and polish README header #13 Check order. The phone uses sortChecksBySeverity: failure, cancelled, pending, success, neutral, skipped.
Improve update experience: toasts, graceful restart, sidebar indicator #14 Labels and failed jobs.
- Desktop's check status label moved to src/shared/pr-check-status-label.ts. A queued check now reads "Queued" on the phone.
- resolveStepOutcome / summarizeJobSteps moved to src/shared/pr-check-step-status.ts, so jobs ending in startup_failure, action_required or stale now count as failed jobs.
Fix first worktree card top border cutoff #15 Reviewer rows. github-pr-reviewer-display.ts moved to src/shared/github/pr-reviewer-display.ts, and the phone's copy is deleted.
After we add a new repo, we should have a little notification that says “repo added” #16 Comment edit/delete eligibility. It moved to src/shared/github/pr-comment-mutability.ts, and the phone's copy is deleted.
tasks P1: I selected “system” as my appearance, but my terminal side is still dark #18 Rerun failed in Tasks uses the shared isBrokenCheck, the same set the host reruns.
Fix and Rerun gating. The Fix strip and the Rerun button are now gated on desktop's broken-check set, so a PR whose only "failure" is action_required no longer offers an agent a prompt with nothing in it.

Mobile behaviour removed or changed (it now follows desktop):

the neutral-before-success sort
the "Pending" label for queued checks
the narrower failed-job filter
launches without the saved agent args
Fix/Rerun showing for action_required-only PRs

Deferred / not in this PR:

A "Resolve comments with AI" action on mobile (new UI).
Treating chat-only saved agents as usable (chosenOpensAsChat needs host facts mobile doesn't have).

Why

Each rule now has one copy in src/shared, used by desktop and the phone. The renderer re-export of the fix-checks prompt is gone, so desktop imports the shared module directly.

Linked Issue

Part of the mobile/desktop parity audit

Visual Proof

No device captures for this fleet. The change adopts desktop's existing behaviour:

use-checks-panel-check-and-review-actions details fetch
sortChecksBySeverity
check-details-model labels
check-job-step-status
github-pr-reviewer-display
comment-controls eligibility
active-content broken-check gating

Testing

Focused mobile tests (pr-sidebar, session, tasks, RPC recordings) and desktop/shared tests for every moved module.
Mobile typecheck / typecheck:tests, tc:web and tc:node pass, as do check:code-quality:changed and check:react-doctor:changed.
I manually tested these changes locally
Automated tests added/updated, or explained why not below

AI Disclosure

Review

Agent skill upstream boundary

Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Mixed versions:
- agentArgs is an existing optional field of agent.launch; the host validates it for its own shell.
- Details come from the already allowlisted github.prCheckDetails.
Folder workspaces: the worktree path comes from the worktree id; folder ids yield no path, so the prompt keeps its fallback wording.

Checklist

This PR is small and focused
I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
Before/after screenshots or videos attached for UI changes, or N/A with reason
Self-reviewed for correctness, security, and performance
Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

coderabbitai · 2026-10-27T01:24:05Z

Walkthrough

The changes add shared resolvers for hosted-review eligibility and upstream actions. Mobile source control now handles fast-forward preparation and uses sidebar push-target data when building actions. Shared check utilities support status labels, failure selection, reviewer display, comment mutability, and check-detail collection. Mobile prompts can include check logs and worktree paths, and agent launches can forward saved arguments. RPC recordings and tests are updated for these flows.

Priority: Normal

Merge Risk: Low · up to 005ae

A replacement PR can show incorrect Source Control actions, and merge-queue labels remain untranslated. These bounded issues should be fixed or explicitly accepted before merging.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 17.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surv…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly summarizes the main change: aligning mobile PR checks and the fix-checks prompt with desktop behavior.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		PASS. The description clearly explains the user impact, implementation, rationale, testing, deferred work, and checklist status. It does not provide an actual linked issue, use the exact `N/A` wording…

Full details: Description check

Explanation

PASS. The description clearly explains the user impact, implementation, rationale, testing, deferred work, and checklist status. It does not provide an actual linked issue, use the exact N/A wording for visual proof, or confirm all requested pnpm commands, but these omissions do not make the description largely incomplete.

Full details: Docstring Coverage

Explanation

Docstring coverage is 17.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 28 functions across 31 files. (7 skipped: 7 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 3

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

⚔️ Resolve merge conflicts: 💡

Resolve merge conflict in branch mobile-pr-checks-parity

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

Review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: e19f4348-63a8-4998-8865-b04452906651

Commits

Reviewing files that changed from the base of the PR and between 57aa892 and fbc062c.

Files selected for processing: 175

mobile/rpc-foundation/goldens/matrix-github.pr-read-github.listassignableusers-1.json
mobile/rpc-foundation/goldens/matrix-github.pr-read-github.prcheckdetails-1.json
mobile/rpc-foundation/goldens/matrix-github.pr-read-github.prchecks-1.json
mobile/rpc-foundation/goldens/matrix-github.pr-read-github.prforbranch-1.json
mobile/rpc-foundation/goldens/matrix-github.pr-read-github.reposlug-1.json
mobile/rpc-foundation/goldens/matrix-github.pr-read-github.workitemdetails-1.json
mobile/rpc-foundation/goldens/matrix-github.pr-read-hostedreview.forbranch-1.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-git.bulkstage-1.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-git.commit-1.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-git.generatecommitmessage-1.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-git.push-1.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-git.status-1.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-git.status-2.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-git.status-3.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-git.status-4.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-hostedreview.create-1.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-hostedreview.getcreationeligibility-1.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-hostedreview.getcreationeligibility-2.json
mobile/rpc-foundation/goldens/matrix-hostedreview.create-intent-worktree.set-1.json
mobile/rpc-foundation/goldens/matrix-session.pr-sidebar-github.prchecks-1.json
mobile/rpc-foundation/goldens/matrix-session.pr-sidebar-github.prforbranch-1.json
mobile/rpc-foundation/goldens/matrix-session.pr-sidebar-hostedreview.forbranch-1.json
mobile/rpc-foundation/goldens/matrix-session.pr-sidebar-worktree.show-1.json
mobile/rpc-foundation/goldens/pr-read-surface.json
mobile/rpc-foundation/goldens/pr-read-upstream-error.json
mobile/rpc-foundation/goldens/pr-sidebar-checks-refused.json
mobile/rpc-foundation/goldens/pr-sidebar-load.json
mobile/rpc-foundation/goldens/sc-create-intent-stage-commit-push-create.json
mobile/rpc-foundation/goldens/sc-create-intent-unlisted-provider.json
mobile/rpc-foundation/goldens/sc-pr-link-hosted-review.json
mobile/rpc-foundation/goldens/sc-prerequisite-publish.json
mobile/rpc-foundation/pilot-scenarios.json
mobile/src/components/MobilePRSidebar.tsx
mobile/src/components/pr-sidebar/MobileLinkPrForm.tsx
mobile/src/components/pr-sidebar/PRActionsSection.tsx
mobile/src/components/pr-sidebar/PRChecksSection.tsx
mobile/src/components/pr-sidebar/PRReviewersSection.tsx
mobile/src/components/pr-sidebar/PrSidebarCreateEmptyState.tsx
mobile/src/components/pr-sidebar/pr-actions-state.test.ts
mobile/src/components/pr-sidebar/pr-actions-state.ts
mobile/src/components/pr-sidebar/pr-actions-styles.ts
mobile/src/components/pr-sidebar/pr-check-detail-content.ts
mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts
mobile/src/components/pr-sidebar/pr-checks-presentation.ts
mobile/src/session/github-pr-mutation-operations.ts
mobile/src/session/github-pr-mutations.ts
mobile/src/session/github-pr-read-reply-schema.ts
mobile/src/session/github-pr-repo-slug.ts
mobile/src/session/github-pr-rpc.ts
mobile/src/session/mobile-existing-agent-launch.ts
mobile/src/session/mobile-pr-sidebar-resolve.test.ts
mobile/src/session/mobile-pr-sidebar-resolve.ts
mobile/src/session/mobile-pr-sidebar-state.ts
mobile/src/session/pr-action-mutation-contract.ts
mobile/src/session/pr-actions-engine.test.ts
mobile/src/session/pr-actions-engine.ts
mobile/src/session/pr-ai-triage-launch.test.ts
mobile/src/session/pr-ai-triage-launch.ts
mobile/src/session/pr-ai-triage-prompt.test.ts
mobile/src/session/pr-ai-triage-prompt.ts
mobile/src/session/pr-comment-actions.test.ts
mobile/src/session/pr-comment-actions.ts
mobile/src/session/use-mobile-pr-actions.test.ts
mobile/src/session/use-mobile-pr-actions.ts
mobile/src/session/use-mobile-pr-ai-triage.ts
mobile/src/session/use-mobile-pr-sidebar-controller-probe.test.ts
mobile/src/session/use-mobile-pr-sidebar-controller.test.ts
mobile/src/session/use-mobile-pr-sidebar-controller.ts
mobile/src/source-control/MobileSourceControlContent.test.tsx
mobile/src/source-control/MobileSourceControlContent.tsx
mobile/src/source-control/MobileSourceControlPanel.tsx
mobile/src/source-control/github-pr-link-parse.test.ts
mobile/src/source-control/github-pr-link-parse.ts
mobile/src/source-control/mobile-create-pr-action.test.ts
mobile/src/source-control/mobile-create-pr-action.ts
mobile/src/source-control/mobile-git-mutation-operations.ts
mobile/src/source-control/mobile-hosted-review-create-intent-runner.ts
mobile/src/source-control/mobile-hosted-review-create-intent.test.ts
mobile/src/source-control/mobile-hosted-review-create-intent.ts
mobile/src/source-control/mobile-hosted-review-git-preparation.ts
mobile/src/source-control/mobile-hosted-review-remote-prerequisite.ts
mobile/src/source-control/mobile-pr-chip-summary.test.ts
mobile/src/source-control/mobile-pr-create.test.ts
mobile/src/source-control/mobile-pr-create.ts
mobile/src/source-control/mobile-pr-link.test.ts
mobile/src/source-control/mobile-pr-link.ts
mobile/src/source-control/mobile-source-control-primary-action.test.ts
mobile/src/source-control/mobile-source-control-primary-action.ts
mobile/src/source-control/mobile-worktree-metadata-operations.ts
mobile/src/source-control/source-control-status-retry.test.tsx
mobile/src/source-control/use-mobile-create-pr-runner.ts
mobile/src/source-control/use-mobile-source-control-create-pr-action.ts
mobile/src/source-control/use-mobile-source-control-state.ts
mobile/src/source-control/worktree-metadata-reply-schema.ts
mobile/src/tasks/agent-launch-request.ts
mobile/src/tasks/mobile-tasks-item-detail-content.tsx
mobile/src/tasks/mobile-tasks-project-review-panels.tsx
mobile/src/tasks/mobile-tasks-repository-presentation.ts
mobile/src/test-support/rpc-recording/adapters/hosted-review-mount-adapters.ts
mobile/src/test-support/rpc-recording/adapters/pr-sidebar-mount-adapters.ts
mobile/src/test-support/rpc-recording/adapters/source-control-mount-adapters.ts
mobile/src/test-support/rpc-recording/mutants/operation-mutations.ts
mobile/src/test-support/rpc-recording/recording-scenario.ts
mobile/src/test-support/rpc-recording/run-recording.ts
mobile/src/test-support/rpc-recording/scripted-rpc-transport.ts
mobile/src/transport/use-workspace-client.ts
mobile/src/transport/workspace-server.ts
src/main/runtime/mobile-rpc-allowlist.test.ts
src/main/runtime/runtime-rpc/runtime-rpc-mobile-method-routing.ts
src/renderer/src/components/editor/CheckRunJobs.tsx
src/renderer/src/components/editor/check-details-reading-cache.ts
src/renderer/src/components/editor/check-details-reading-owner.ts
src/renderer/src/components/editor/check-run-details-fix-context.ts
src/renderer/src/components/github-item-dialog/inspect-pull-request/checks-tab-actions.ts
src/renderer/src/components/github-item-dialog/inspect-pull-request/checks-tab.tsx
src/renderer/src/components/github-item-dialog/land-pull-request/pr-reviewers-panel.tsx
src/renderer/src/components/github-item-dialog/land-pull-request/pr-reviewers-request-actions.ts
src/renderer/src/components/github-item-dialog/land-pull-request/pr-reviewers-requested-list.tsx
src/renderer/src/components/github-pr-merge-state.test.ts
src/renderer/src/components/github-pr-merge-state.ts
src/renderer/src/components/pr-checks-fix-prompt.ts
src/renderer/src/components/pull-request-page/checks/fix-launch.ts
src/renderer/src/components/pull-request-page/checks/tab.tsx
src/renderer/src/components/pull-request-page/reviewers/panel.tsx
src/renderer/src/components/pull-request-page/reviewers/request-actions.ts
src/renderer/src/components/pull-request-page/reviewers/requested-list.tsx
src/renderer/src/components/right-sidebar/HostedReviewActions.tsx
src/renderer/src/components/right-sidebar/check-job-log-tail.tsx
src/renderer/src/components/right-sidebar/checks-panel-content.test.tsx
src/renderer/src/components/right-sidebar/checks-panel-review-creation.test.ts
src/renderer/src/components/right-sidebar/checks-panel-review-creation.ts
src/renderer/src/components/right-sidebar/checks-panel-review-lookup-authority.ts
src/renderer/src/components/right-sidebar/checks-panel/active-content.tsx
src/renderer/src/components/right-sidebar/checks-panel/check-details-model.ts
src/renderer/src/components/right-sidebar/checks-panel/check-run-details.tsx
src/renderer/src/components/right-sidebar/checks-panel/checks-list.tsx
src/renderer/src/components/right-sidebar/checks-panel/comment-controls.tsx
src/renderer/src/components/right-sidebar/checks-panel/comment-row.tsx
src/renderer/src/components/right-sidebar/checks-panel/use-checks-panel-check-and-review-actions.tsx
src/renderer/src/components/right-sidebar/checks-panel/use-checks-panel-comment-mutations.tsx
src/renderer/src/components/right-sidebar/github-pr-stack-merge.test.ts
src/renderer/src/components/right-sidebar/github-pr-stack-merge.ts
src/renderer/src/components/right-sidebar/source-control-create-pr-intent-flow.test.ts
src/renderer/src/components/right-sidebar/source-control-dropdown-items.test.ts
src/renderer/src/components/right-sidebar/source-control/review/create-pr-intent-flow.ts
src/renderer/src/components/right-sidebar/source-control/review/create-pr-intent-review-step.ts
src/renderer/src/components/right-sidebar/source-control/review/use-linked-reviews.ts
src/renderer/src/components/task-page/github/Avatars.tsx
src/renderer/src/components/task-page/github/ReviewCell.tsx
src/renderer/src/components/task-page/github/task-page-github-reviewer-actions.ts
src/renderer/src/i18n/locales/en.json
src/renderer/src/store/github/pull-request-actions.ts
src/renderer/src/store/github/pull-request-execution.ts
src/renderer/src/store/github/refresh-event-actions.ts
src/renderer/src/store/github/worktree-refresh.ts
src/renderer/src/store/slices/github-branch-mismatched-linked-pr.test.ts
src/shared/github/linked-pr-staleness.ts
src/shared/github/pr-comment-mutability.test.ts
src/shared/github/pr-comment-mutability.ts
src/shared/github/pr-reviewer-display.test.ts
src/shared/github/pr-reviewer-display.ts
src/shared/github/pull-request-merge-state.ts
src/shared/github/pull-request-stack-merge.ts
src/shared/hosted-review-create-confirmation.test.ts
src/shared/hosted-review-create-confirmation.ts
src/shared/hosted-review-push-target.test.ts
src/shared/hosted-review-push-target.ts
src/shared/pr-check-status-label.ts
src/shared/pr-check-step-status.test.ts
src/shared/pr-check-step-status.ts
src/shared/pr-checks-fix-prompt.test.ts
src/shared/pr-checks-fix-prompt.ts
src/shared/source-control-create-review-intent.test.ts
src/shared/source-control-create-review-intent.ts
src/shared/source-control-runtime-capabilities.ts

Files with no reviewable changes: 13

mobile/src/tasks/mobile-tasks-repository-presentation.ts
src/renderer/src/components/right-sidebar/checks-panel-content.test.tsx
mobile/src/source-control/github-pr-link-parse.test.ts
mobile/src/session/mobile-pr-sidebar-resolve.ts
mobile/src/session/pr-comment-actions.test.ts
mobile/src/session/mobile-pr-sidebar-resolve.test.ts
mobile/src/source-control/github-pr-link-parse.ts
src/renderer/src/components/pr-checks-fix-prompt.ts
src/renderer/src/components/right-sidebar/checks-panel/comment-controls.tsx
src/renderer/src/components/right-sidebar/source-control-create-pr-intent-flow.test.ts
src/renderer/src/components/right-sidebar/checks-panel-review-creation.test.ts
mobile/src/components/pr-sidebar/pr-checks-presentation.ts
src/renderer/src/store/github/worktree-refresh.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

coderabbitai · 2026-10-27T01:24:08Z

+    case 'merge_queue':
+    case 'merge_queue_auto_merge_on':
+      return {
+        label: kind === 'merge_queue_auto_merge_on' ? 'Auto-merge on' : 'Merge when ready',


Minor · Functional Correctness · Quick win

Translate the merge-queue labels.

Every other case in presentMergeStateKind sends its label through translate. The merge_queue and merge_queue_auto_merge_on cases return the raw English strings 'Merge when ready' and 'Auto-merge on'. In a non-English locale, the merge-state chip therefore shows untranslated text for repositories that use a merge queue. The catalog already has a key for 'Merge when ready' (b169f943e1). 'Auto-merge on' needs a new key.

Proposed fix

--- "a/src/renderer/src/components/github-pr-merge-state.ts" +++ "b/src/renderer/src/components/github-pr-merge-state.ts" @@ -123,7 +123,10 @@ case 'merge_queue': case 'merge_queue_auto_merge_on': return { - label: kind === 'merge_queue_auto_merge_on' ? 'Auto-merge on' : 'Merge when ready', + label: + kind === 'merge_queue_auto_merge_on' + ? translate('auto.components.github.pr.merge.state.autoMergeOn', 'Auto-merge on') + : translate('auto.components.github.pr.merge.state.b169f943e1', 'Merge when ready'), tone: WARNING_TONE, tooltip: translate( 'auto.components.github.pr.merge.state.35ec24bc43',

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

label: kind === 'merge_queue_auto_merge_on' ? 'Auto-merge on' : 'Merge when ready',

label:

kind === 'merge_queue_auto_merge_on'

? translate('auto.components.github.pr.merge.state.autoMergeOn', 'Auto-merge on')

: translate('auto.components.github.pr.merge.state.b169f943e1', 'Merge when ready'),

coderabbitai

Actionable comments posted: 1

Review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 4c2b6f6d-9cbd-4a14-a0f5-c886f88d40d4

Commits

Reviewing files that changed from the base of the PR and between fbc062c and 005aea1.

Files selected for processing: 11

mobile/rpc-foundation/goldens/matrix-session.pr-sidebar-github.prchecks-1.json
mobile/rpc-foundation/goldens/matrix-session.pr-sidebar-github.prforbranch-1.json
mobile/rpc-foundation/goldens/matrix-session.pr-sidebar-hostedreview.forbranch-1.json
mobile/rpc-foundation/goldens/matrix-session.pr-sidebar-worktree.show-1.json
mobile/rpc-foundation/goldens/pr-sidebar-checks-refused.json
mobile/rpc-foundation/goldens/pr-sidebar-load.json
mobile/rpc-foundation/pilot-scenarios.json
mobile/src/components/MobilePRSidebar.tsx
mobile/src/session/mobile-pr-sidebar-state.ts
mobile/src/session/use-mobile-pr-sidebar-controller.test.ts
src/renderer/src/components/pull-request-page/checks/tab.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

coderabbitai · 2026-10-27T02:22:02Z

+        details: null,
+        checks: checksOutcome.result,
+        checksError: null,
+        pushTarget: link.pushTarget


Minor · Data Integrity & Integration · Quick win

Clear the old push target when replacing a stale review.

If resolveStaleLink clears the linked review and fetchPR(null) finds another PR, pr refers to the new PR but link.pushTarget still refers to the old review. Source Control then builds actions from mismatched review data. Return a null push target after a stale-link clear in both ready-state branches.

Create PR now fast-forwards a behind-only branch before committing, picks its push step from desktop's shared rule, and the commit-area button reads the branch's review state.

…-target gating Restaging after a failed commit is best effort and checks the branch first, and reviews with their own push target are not gated until mobile reads targeted upstream status.

…push targets ungated

…ate PR on desktop's intent rule Desktop and mobile compose the review push target through one shared function, the Create button admits branches Create PR can prepare, and older hosts without a lookup outcome still fail closed on mobile.

…in the PR panel Check, step, reviewer and comment rules move to src/shared; the phone's fix-checks agent now gets failing log tails, the worktree path and the action's saved agent arguments.

…rop the prompt re-export Fix and Rerun show for the same checks the prompt and the host use, desktop imports the fix-checks prompt from src/shared directly, and job steps split through the shared summary.

AmoabaKelvin mentioned this pull request Oct 26, 2026

fix(mobile): list Source Control changes with desktop's sections, order and row rules #34017

Merged

7 of 9 tasks

AmoabaKelvin force-pushed the mobile-pr-checks-parity branch 3 times, most recently from de1996b to fbc062c Compare October 27, 2026 01:07

AmoabaKelvin marked this pull request as ready for review October 27, 2026 01:07

AmoabaKelvin requested a review from brennanb2025 as a code owner October 27, 2026 01:07

coderabbitai Bot reviewed Oct 27, 2026

View reviewed changes

AmoabaKelvin force-pushed the mobile-pr-checks-parity branch from fbc062c to 005aea1 Compare October 27, 2026 02:13

coderabbitai Bot reviewed Oct 27, 2026

View reviewed changes

AmoabaKelvin added 7 commits October 27, 2026 02:56

fix(mobile): prepare Create PR and the commit action like desktop

327b536

Create PR now fast-forwards a behind-only branch before committing, picks its push step from desktop's shared rule, and the commit-area button reads the branch's review state.

fix(mobile): keep Create PR commit failures intact and skip fork push…

53b3afb

…-target gating Restaging after a failed commit is best effort and checks the branch first, and reviews with their own push target are not gated until mobile reads targeted upstream status.

fix(mobile): enter Create PR on desktop's intent rule and leave fork …

32e8357

…push targets ungated

fix(mobile): use desktop's check order, labels and fix-checks prompt …

190760f

…in the PR panel Check, step, reviewer and comment rules move to src/shared; the phone's fix-checks agent now gets failing log tails, the worktree path and the action's saved agent arguments.

test(shared): pass only the fields comment mutability reads

37a8cd9

refactor(mobile): gate fix-checks on desktop's broken-check set and d…

2361218

…rop the prompt re-export Fix and Rerun show for the same checks the prompt and the host use, desktop imports the fix-checks prompt from src/shared directly, and job steps split through the shared summary.

AmoabaKelvin force-pushed the mobile-pr-checks-parity branch from 005aea1 to 2361218 Compare October 27, 2026 02:58

AmoabaKelvin merged commit 88ffc5c into main Oct 27, 2026
43 checks passed

kiwidream mentioned this pull request Oct 27, 2026

sync: upstream df95be4090 into swaplabs/main SwapLabsInc/orca#62

Merged

1 task done

Navigation Menu

Repository navigation

fix(mobile): use desktop's check rules and fix-checks prompt in the PR panel - #34014

fix(mobile): use desktop's check rules and fix-checks prompt in the PR panel#34014
AmoabaKelvin merged 7 commits into
mainfrom
mobile-pr-checks-parity

AmoabaKelvin commented Oct 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Oct 27, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

AmoabaKelvin commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ELI5

What Changed

Why

Linked Issue

Visual Proof

Testing

AI Disclosure

Review

Agent skill upstream boundary

Notes

Checklist

Uh oh!

coderabbitai Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

AmoabaKelvin commented Oct 26, 2026 •

edited

Loading

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading