Repository navigation
Fix TypeScript error and linting issues in TabBar - #34
Merged
Merged
Conversation
Jinwoo-H
added a commit
that referenced
this pull request
Sep 5, 2026
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
onCloseAllFileswas renamed to_onCloseAllFilesduring destructuring but the usage on line 543 wasn't updated, causing a TypeScript error. Additionally, the file exceeded the max-lines limit (400), and there were several linting violations (inconsistent-type-definitions, max-lines, curly braces).Solution
onCloseAllFilesto_onCloseAllFiles