Skip to content

Fix TypeScript error and linting issues in TabBar - #34

Merged
AmethystLiang merged 1 commit into
mainfrom
AmethystLiang/fixBuild
Mar 22, 2026
Merged

AmethystLiang merged 1 commit into
mainfrom
AmethystLiang/fixBuild

Conversation

@AmethystLiang

Copy link
Copy Markdown
Contributor

Problem

onCloseAllFiles was renamed to _onCloseAllFiles during destructuring but the usage on line 543 wasn't updated, causing a TypeScript error. Additionally, the file exceeded the max-lines limit (400), and there were several linting violations (inconsistent-type-definitions, max-lines, curly braces).

Solution

  • Fixed the variable reference from onCloseAllFiles to _onCloseAllFiles
  • Extracted the SortableTab component to a separate file to reduce TabBar.tsx from 572 to ~400 lines
  • Fixed all linting issues (converted interfaces to types, added required curly braces)
  • Build now passes successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant