Repository navigation
refactor(task-page): colocate cross-provider composition owners - #33913
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Keep the cross-provider Task Page code together so its owners and tests are easier to find.
What Changed
Move seven composition/rule modules and eight existing tests into
components/task-page/, retaining their basenames. Update their callers and test timing paths. Remove four forwarded Linear view types from localized options and import those types from their shared defining module. Draft storage explicitly imports the existing store singleton from its defining file.Why
These modules belong to the existing Task Page folder. Direct owner imports keep that boundary clear without adding aggregation modules or compatibility forwarders. Runtime bodies, hook ownership, module identities, labels, and timing weights remain unchanged.
Linked Issue
N/A — internal module organization work.
Visual Proof
N/A — module moves and import changes preserve rendering and interaction behavior.
Testing
Review
Two independent native Codex source audits approved the committed source with no findings. Current-main preservation and actual squash-tree checks remain part of the merge gate.
Agent skill upstream boundary
Notes
No platform, remote protocol, mobile, folder-workspace, or persistence behavior changes. Open feature contacts were reviewed so later rebases can preserve their additions in the relocated owners.
Checklist