Skip to content

test: remove 57 low-value cases and standalone browser probes - #33889

Merged
OrcaWin merged 1 commit into
mainfrom
audit/test-value-488
Oct 26, 2026
Merged

OrcaWin merged 1 commit into
mainfrom
audit/test-value-488

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator
Files Added Deleted Net
Test 31 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​957 $\color{#cf222e}{\Huge{\mathbf{−}}}$​956
Prod 17 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​8 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1287 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1279

This batch removes 57 low-value test declarations across 50 reviewed sources, including 24 entire suites and nine orphaned browser fixture modules (2,234 net lines removed).

The removals cover copied inventories/private predicate tables, mock-only option and callback assertions, ineffective recovery-wait checks, and standalone Electron experiments that configure their own proxy without exercising Orca’s production routing policy. Retained behavior coverage includes real socket delivery, runtime ownership and recovery, stateful invalidation, parser rejection, redraw performance, and native Windows observations. All 33 retained declarations and callbacks are byte-for-byte unchanged.

CI discovery, the orphaned spec import, stale baselines, and active reliability-gate references are updated. Historical experiment receipts and timing provenance are preserved. Production executable behavior is unchanged; its only source edit corrects a deleted-test comment pointer.

Validation: isolated AST/census, exact retained-byte checks, formatting, auxiliary/config parsing and gate checks; fresh PR CI required before merge. Native Windows cases were not executed locally. The registration-only journal wrapper is preserved without crediting its imported test bodies as reviewed declarations.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: de988baf-af94-48d6-af57-ec8441de961b
Commits

Reviewing files that changed from the base of the PR and between 7d21e9b and 4b89c71.

Files selected for processing: 3
  • .github/workflows/pr.yml
  • config/flaky-test-pattern-baseline.txt
  • src/main/codex/codex-structured-permission-policy.test.ts
Files with no reviewable changes: 3
  • src/main/codex/codex-structured-permission-policy.test.ts
  • .github/workflows/pr.yml
  • config/flaky-test-pattern-baseline.txt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The PR removes standalone TCP-egress, persisted-worker-egress, and DNS-prefetch probes and their Electron tests. It updates CI and reliability-gate inventories; WebRTC and HTTP/3 egress tests remain listed. It also removes selected test cases and suites across browser, startup, IPC, runtime, Git, skills, SSH, and other application areas.

Priority: Low

Merge Risk: Minimal · up to 4b89c

No actionable merge-blocking issue is established. The remaining validation, including fresh CI, should run before merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description gives a detailed change summary, rationale, retained coverage, and validation details. It omits the required linked issue, explicit visual-proof statement, checklist status, and severa… Add the required issue link after “Fixes #”. Add “N/A” with a reason under Visual Proof because this change has no UI or interaction change. Complete or explicitly mark the Testing, AI Disclosure, Review, Agent skill upstream boundary, Note…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: removing low-value tests and standalone browser probes.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description gives a detailed change summary, rationale, retained coverage, and validation details. It omits the required linked issue, explicit visual-proof statement, checklist status, and several template sections.

Resolution

Add the required issue link after “Fixes #”. Add “N/A” with a reason under Visual Proof because this change has no UI or interaction change. Complete or explicitly mark the Testing, AI Disclosure, Review, Agent skill upstream boundary, Notes, and Checklist sections.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin OrcaWin closed this Oct 26, 2026
@OrcaWin OrcaWin reopened this Oct 26, 2026
@OrcaWin
OrcaWin marked this pull request as draft October 26, 2026 10:33
@OrcaWin
OrcaWin marked this pull request as ready for review October 26, 2026 10:33
@OrcaWin
OrcaWin force-pushed the audit/test-value-488 branch from 7d21e9b to 4b89c71 Compare October 26, 2026 19:19
@OrcaWin
OrcaWin merged commit f34c13c into main Oct 26, 2026
83 of 85 checks passed
audichuang pushed a commit to audichuang/orca that referenced this pull request Oct 27, 2026
…ai#33889)

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
(cherry picked from commit f34c13c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant