Repository navigation
fix(i18n): correct native-chat subagent and tool-run summary strings in zh/ja/ko/fr - #33561
Conversation
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (5 skipped: 5… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Issue #33552requires the Chinese subagent message to use启动 1 个子智能体and requires natural counters and punctuation in Chinese tool summaries. The PR evidence reports the correctedstartedOneand c…Out of Scope Changes check The changes remain connected to the localization defect in #33552. The separator API and its tests support the required Chinese summary. The Japanese, Korean, and French string corrections use the sam…Title check The title names the change type (fix), the scope (i18n), and the affected areas: native-chat subagent and tool-run summary strings in zh, ja, ko, and fr. The changeset corrects those translated string… Description check The description follows the template closely. It includes ELI5, What Changed (with a before/after table), Why, Linked Issue (Fixes #33552), Visual Proof (marked N/A with a reason and a text-based befo…Full details: Linked Issues check
-
Explanation
Issue
#33552requires the Chinese subagent message to use启动 1 个子智能体and requires natural counters and punctuation in Chinese tool summaries. The PR evidence reports the correctedstartedOneand count forms inzh.json, including个,条, and次. It also reports the target output搜索 1 次、使用 1 个集成、读取 1 个文件并运行 2 条命令. The shared joiner supports a locale-specific separator, andnative-chat-tool-run-label.tsreads that separator through a getter. The reported tests cover the joiner, locale override, language switching, and localization catalogs.
Full details: Out of Scope Changes check
-
Explanation
The changes remain connected to the localization defect in
#33552. The separator API and its tests support the required Chinese summary. The Japanese, Korean, and French string corrections use the same subagent activity keys and correct the samekicked offmistranslation class. The default separator preserves existing behavior for other locales. No unrelated product behavior or files appear in the supplied change summary.
Full details: Title check
-
Explanation
The title names the change type (fix), the scope (i18n), and the affected areas: native-chat subagent and tool-run summary strings in zh, ja, ko, and fr. The changeset corrects those translated strings and adds a locale-configurable list separator, so the title matches the main change. It omits the separator mechanism, which is acceptable because the title need not cover every detail.
Full details: Description check
-
Explanation
The description follows the template closely. It includes ELI5, What Changed (with a before/after table), Why, Linked Issue (Fixes
#33552), Visual Proof (marked N/A with a reason and a text-based before/after rendering), Testing (manual and automated checks, with the platform stated), Review, Agent skill upstream boundary, Notes, and Checklist. The AI Disclosure section is absent from the description. The template says to fill it in unless the author is a StablyAI team member, so the author should confirm whether that section applies. The Visual Proof section is N/A with a reason, which the template allows for non-visual changes.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (5 skipped: 5 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
zh.json:18971-18986
src/renderer/src/i18n/locales/zh.json:18971-18986
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winFix the Chinese list join and counted live labels.
When three or more tool categories are rendered,
runListsupplies the final joiner. The Chinese value uses和instead of the requested enumeration punctuation. KeeprunPairunchanged because the shared formatter uses it only for exactly two clauses, where和is the correct conjunction.The counted live labels still omit
个for files, directories, commands, and integrations.Suggested fix
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
836d3ec0-40e9-4120-b7b4-012bf0424d40
-
Reviewing files that changed from the base of the PR and between 33c76d8 and 2fdbd8d88ff513b8e22edb9745d3d86660fc825f.
-
src/renderer/src/i18n/locales/fr.jsonsrc/renderer/src/i18n/locales/ja.jsonsrc/renderer/src/i18n/locales/ko.jsonsrc/renderer/src/i18n/locales/zh.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
-
6776f4c to
51123f2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
95ab83d5-b69b-4848-abac-fbe110e7e7f3
-
Reviewing files that changed from the base of the PR and between 2fdbd8d88ff513b8e22edb9745d3d86660fc825f and 51123f2e984143dbf23d0c0eec6ae28bb314e0cf.
-
src/renderer/src/components/native-chat/native-chat-tool-run-label.tssrc/renderer/src/i18n/locales/en.jsonsrc/renderer/src/i18n/locales/fr.jsonsrc/renderer/src/i18n/locales/ja.jsonsrc/renderer/src/i18n/locales/ko.jsonsrc/renderer/src/i18n/locales/zh.jsonsrc/shared/native-chat/tools/native-chat-tool-run-sentence.test.tssrc/shared/native-chat/tools/native-chat-tool-run-sentence.ts
-
- src/renderer/src/i18n/locales/ko.json
- src/renderer/src/i18n/locales/zh.json
- src/renderer/src/i18n/locales/ja.json
- src/renderer/src/i18n/locales/fr.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
-
2b2a315 to
897d41b
Compare
…in zh/ja/ko/fr
Replace mistranslated subagent summaries ("kicked off" rendered as "fired"/
"kicked out", untranslated "Ran") and add missing measure words to the zh
tool-run clauses. Leading tool-run clauses are now joined with a translated
runListSeparator so CJK locales use 、 instead of an English comma.
Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
897d41b to
56c149f
Compare
nwparker
changed the title
ELI5
When a chat says a subagent was started, the Chinese, Japanese and Korean text said it was fired or kicked out, and two places still showed the English word
Ran. The Chinese tool summary also dropped its counter words ("run 2 command" instead of "run 2 条 commands") and glued clauses together with an English comma. This fixes the wording and lets each language pick its own list separator.What Changed
Subagent summaries (before -> after):
startedOnestartedNranOne/ranNstartedOnestartedNranOne/ranNstartedOnestartedNranNTool-run summary in zh: added measure words (
个/条/次), fixed the然typo (->运行) and the noun清单(->列出), and join clauses with、and并:Mechanism:
joinNativeChatToolRunClausesused to hardcode', 'when joining leading clauses.NativeChatToolRunSentenceWords.listnow receives the leading clauses as an array; the English/shared formatter joins withNATIVE_CHAT_TOOL_RUN_SENTENCE_JOINERS.separator(", "), and the renderer joins withtranslate('components.native-chat.tool.runListSeparator', ', ')on each call, so a live language switch picks up the new separator. A newrunListSeparatorkey is added toen(", "),zhandja(、); other locales fall back to", "and render unchanged.Why
"Kicked off" is an idiom that machine translation read as "remove", producing 解雇 / 踢掉 / 추방 — the opposite of what happened, and inconsistent with the neighbouring
startedNstrings. The missing counters and English comma made the Chinese summary read like a machine dump, and the comma could not be fixed in the catalog alone because the joiner was hardcoded. Passing the clause array keeps the join per-locale without an extra optional getter on the format object.Linked Issue
Fixes #33552
Visual Proof
N/A — catalog strings and a string joiner only; no layout, component or styling change. The rendered text was verified by building the summary line with the real renderer
nativeChatToolRunSentenceand the real locale catalogs viai18n.t:English and Spanish output is unchanged.
Testing
Reproduced the bad strings on
mainwith a throwaway probe (renderer sentence builder + real catalogs); the same probe passes on this branch (output above).pnpm testfornative-chat-shared-copy-matches-catalog,native-chat-tool-run-label,native-chat-tool-run-sentence, andsrc/renderer/src/i18n— 15 files, 272 tests pass. The catalog-parity test now pinsrunListSeparatorinen.jsonagainst the shared separator.oxlint (anti-slop, code-quality plugins), ast-grep, changed-code-quality gate, and oxfmt clean on touched files.
Platform: macOS. Locale data and pure string joining only; no platform, SSH or path behavior involved.
I manually tested these changes locally
Automated tests added/updated, or explained why not below
Review
", ", so mobile output is unchanged.Agent skill upstream boundary
Notes
Original fix by @beduldul in #33561; maintainer follow-up switched the optional separator getter to passing the clause array and adjusted the zh pair joiner and ja counters.
智能体->Agentbrand cleanup is out of scope.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)