Repository navigation
test: strengthen CLI and mobile behavior checks - #33526
Conversation
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the main test changes and validation results, but it omits most required template sections, including the linked issue, visual proof or an N/A explanation, testing checkboxes,… | Update the description to use the repository template. Add the required issue link, visual proof or an explicit N/A reason, testing details and checkboxes, AI disclosure if applicable, review and agent-boundary sections, notes, and the chec… |
| Docstring Coverage | |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 8 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly summarizes the main change: strengthening CLI and mobile behavior tests. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Description check
-
Explanation
The description explains the main test changes and validation results, but it omits most required template sections, including the linked issue, visual proof or an N/A explanation, testing checkboxes, review notes, agent boundary, notes, and checklist.
Resolution
Update the description to use the repository template. Add the required issue link, visual proof or an explicit N/A reason, testing details and checkboxes, AI disclosure if applicable, review and agent-boundary sections, notes, and the checklist. Keep the existing change summary and validation details.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
ef1d2874-11e2-4e17-9d0a-c2590b79a417
-
mobile/src/transport/foreground-stale-dial-restart.test.tsmobile/src/transport/mobile-direct-endpoint-probe.test.tsmobile/src/transport/mobile-endpoint-lifecycle-host-edit.test.tsmobile/src/transport/mobile-endpoint-supervisor-direct-probe.test.tsmobile/src/transport/mobile-endpoint-supervisor-nudge.test.tssrc/cli/orchestration-session-caller-cli.test.tssrc/cli/runtime-client.test.tssrc/cli/skills-install.test.tssrc/cli/skills-reference-selector.test.ts
-
- src/cli/skills-reference-selector.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.
-
| lifecycle.stop() | ||
| finishCredentialWrite() | ||
| await new Promise((resolve) => setTimeout(resolve, 0)) | ||
| await vi.advanceTimersByTimeAsync(0) |
There was a problem hiding this comment.
Prune the wall-clock test ratchet baseline.
After this PR replaces real-time waits with fake-timer advancement, the required validation job fails. The test-no-wall-clock count is 0, but its checked-in baseline is 2. Run pnpm check:flaky-test-pattern-ratchet --prune and include the baseline update so the job can pass.
Source: Pipeline failures
Several CLI and mobile tests accepted unrelated handler failures, mocked their own session migration, or relied on unrealistic persistence fixtures. Repair 18 cases and remove three duplicate or inventory declarations across nine test files.
CLI tests now require successful caller dispatch, coordinate timeouts with actual socket receipt, and check skill links with platform-aware path semantics. Mobile tests exercise actual stable-session cutover and withdrawal, verify stale socket closure, and retain keyed storage while checking host edits and probe cleanup. Prune the two obsolete host-edit wall-clock findings from the ratchet baseline. Application code is unchanged.
Validation: independently checked original/candidate runs, retained-case witnesses, real-owner fault controls and sealed source/support evidence for 14 reviewed files (135 original declarations). Current scoped formatting, lint and the changed flaky-test ratchet pass; full fresh PR CI supplies aggregate validation before merge. The installed local pnpm wrapper cannot complete the required aggregate command, and no dependency/native builds were run locally. Linux runtime evidence uses explicit native substitutes; upstream Hermes capability data drift was reviewed separately and is validated against current code by CI.