Repository navigation
test: verify retry identities and complete boundary outputs - #33491
Conversation
Walkthrough
Priority: Merge Risk:
|
There was a problem hiding this comment.
🧹 Nitpick comments: 1
src/shared/ephemeral-vm-runtime-feature-sorting.test.ts: 1
30-35:Trivial · Functional Correctness · Quick win Cover required-feature insertion.
requiredhas the sameid,recipeId, andcreatedAtasfeatures[0];replacementis not part offeatureIdentity. The test therefore covers replacement only. A merge regression that drops a required feature with a new identity would pass these assertions.Suggested fix
const required = { ...features[0], replacement: true } + const additionalRequired = { ...features[0], id: 'vm-required', replacement: true } const merged = new Map(features.map((entry) => [featureIdentity(entry), entry])) merged.set(featureIdentity(required), required) + merged.set(featureIdentity(additionalRequired), additionalRequired) const expectedMerged = [...merged.values()].sort((a, b) => featureIdentity(a).localeCompare(featureIdentity(b)) ) reads = 0 - const actual = mergeRuntimeFeatures(features, [required]) + const actual = mergeRuntimeFeatures(features, [required, additionalRequired])

Review info
-
Run configuration-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
ac9c053f-4897-4bf4-9bbb-ffca2a07aae4
Files selected for processing: 7-
src/cli/runtime/client-recovery.test.tssrc/cli/runtime/profile-state-recovery-launch.test.tssrc/cli/runtime/serve-orcad-launch.test.tssrc/cli/specs/profile-state.test.tssrc/shared/ephemeral-vm-runtime-feature-sorting.test.tssrc/shared/execution-host-registry-shared-control-connect.test.tssrc/shared/export-let-function-initializer-ban.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
-
Several tests could pass with unrelated retry IDs, truncated sort results, or missing rollback guidance. Compare recovery IDs with the actual socket request, require complete sorted results, and check rollback guidance in rendered help.
Also use the production status projector in the shared-control fixture, replace an arbitrary source-count threshold with shipped-source and scanner-fixture checks, and correct launch test titles to describe their injected boundaries. Seven test files change; production code is unchanged.
Audited 49 sources/336 authored declarations; no removals. Original and candidate runs each passed 385 cases. Four Darwin-only cases skipped, two fish cases were scope-excluded, and two fish/node-pty cases were deferred locally. Changed-file lint/format and independent evidence validation passed; deliberate owner faults confirm the strengthened assertions. Full PR CI supplies typecheck and ast-grep validation.