Skip to content

perf(dev): serve the renderer with bundled dev mode by default - #33449

Merged
nwparker merged 2 commits into
mainfrom
nwparker/renderer-bundled-dev-default
Oct 25, 2026
Merged

nwparker merged 2 commits into
mainfrom
nwparker/renderer-bundled-dev-default

Conversation

@nwparker

@nwparker nwparker commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​6 $\color{#cf222e}{\Huge{\mathbf{−}}}$​9 $\color{#cf222e}{\Huge{\mathbf{−}}}$​3

Makes the bundled renderer dev mode from #33433 the default for pnpm dev; ORCA_DEV_BUNDLED=0 opts out. Production builds are unaffected.

First render was 10.9s → 3.5s warm and 24.3s → 4.1s cold in #33433's measurements; HMR still works. Smoke-tested here: pnpm dev in a worktree (background launch) rendered the full app with 35 script requests.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9a46adfc-1e71-43f6-b50c-bf15614e3363
Commits

Reviewing files that changed from the base of the PR and between 9f9a25b and 6c9108b.

Files selected for processing: 1
  • config/scripts/electron-vite-output-contract.test.ts

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5a4969e3-cb6f-47ba-bdc5-21b7a9234da9
Commits

Reviewing files that changed from the base of the PR and between cae5e98 and 9f9a25b.

Files selected for processing: 2
  • .github/CONTRIBUTING.md
  • config/build-plugins/renderer-bundled-dev.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

Bundled renderer development is now enabled by default. Set ORCA_DEV_BUNDLED=0 to disable it. The plugin still skips configurations without a renderer and configurations where the renderer is a function. The contribution guide documents the default behavior and retains its note about placeholder HTML during rebuilds.

Priority: Normal

Merge Risk: Minimal · up to 9f9a2

No actionable merge risk was identified in the bundled renderer default change.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the main change, opt-out behavior, production-build impact, performance results, and smoke test. It does not follow the required template and omits the linked issue, visual pr… Complete the required sections. Add the linked issue, visual proof or explain why it is N/A, testing details and checklist status, AI disclosure when applicable, review and compatibility notes, agent skill boundary status, and the remaining…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: bundled renderer development is enabled by default for development.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the main change, opt-out behavior, production-build impact, performance results, and smoke test. It does not follow the required template and omits the linked issue, visual proof or an explicit N/A explanation, testing checklist, AI disclosure, review notes, agent boundary checklist, and project checklist.

Resolution

Complete the required sections. Add the linked issue, visual proof or explain why it is N/A, testing details and checklist status, AI disclosure when applicable, review and compatibility notes, agent skill boundary status, and the remaining checklist items.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit 9bed1b4 into main Oct 25, 2026
38 checks passed
@nwparker
nwparker deleted the nwparker/renderer-bundled-dev-default branch October 25, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant