[nwparker]

	Files	Added	Deleted	Net
Test	2	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​220	0	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​220
Prod	6	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​233	$\color{#cf222e}{\Huge{\mathbf{−}}}$​4	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​229

ELI5

Some projects are saved under a WSL network path that actually points at a Windows folder: \\wsl.localhost\Ubuntu\mnt\c\src\app is the same folder as C:\src\app. The WSL move can't take these. They need to become plain Windows projects at C:\… instead. This PR adds the first piece: working out which projects qualify and what each saved path and workspace id becomes. Nothing changes yet.

What Changed

New file src/main/wsl/wsl-drive-unc-project-scope.ts:

• wslUncDrivePathToWindows maps \\wsl.localhost\<distro>\mnt\c\x (either UNC spelling or slash, any case in mnt\<drive>) to C:\x. Anything else returns null.
• collectWslDriveUncScope lists the local repos and folder workspaces of a distro that qualify. It refuses a repo with a reason when:
  • some of its saved paths (worktree folder, imported worktrees and so on) aren't on the drive;
  • it already runs on another host;
  • C:\x is already a project here, so converting would make two rows for one folder.
• wslDriveUncWorktreeId gives a converted worktree its new id: same repo id, drive path, and any folder-workspace suffix kept.

New file src/main/wsl/wsl-unc-access-denied.ts: when adding a \\wsl.localhost\… path fails because Windows refused to read it (EPERM or EACCES), the add says "Windows denied access to this WSL path" instead of "Not a valid git repository", which sent users looking in the wrong place. Only on Windows with the WSL hosts gate open; otherwise the usual message, which the renderer uses to offer adding the folder as a non-git project.

The list of a repo's saved paths is the mover's own (wslMoveRepoPaths, now exported), so the two scope rules can't drift apart.

Why

Owner decision: Windows-drive projects that run under WSL become Windows projects with WSL terminals. For UNC-path projects the path itself changes, and a workspace id contains its path (<repoId>::<path>). So the next PRs must re-key the saved session, chats and terminals. Pinning down the scope and the mapping first lets those PRs share one definition.

Linked Issue

WSL re-write, step D1c (R36, R37). Stacked on #33097.

Visual Proof

N/A: no caller and no UI yet.

Testing

• wsl-drive-unc-project-scope.test.ts: path map (spellings, case, drive root, other distros, in-distro paths), scope with every refusal reason, and worktree ids including the folder-workspace suffix.
• The mover's scope tests pass with the exported helper.

Review

Self-reviewed.

Agent skill upstream boundary

• Not applicable.

Notes

• Flag-off: no change. describeWslUncAccessDenied returns null unless it is Windows with the gate open, without listing the folder, so a failed add still says "Not a valid git repository" and the renderer still offers adding it as a folder (pinned in wsl-unc-access-denied.test.ts). The new scope module has no production importer yet, and wslMoveRepoPaths is a rename plus an export.
  Pure functions; nothing runs them yet.

Status

• 2026-10-28, head 4c5a34243f4: rebased onto main 64344142fa0, which has feat(wsl): run Git for Windows for a WSL project on a Windows drive (D1c-2) #33090 squash-merged (fix(wsl-host): tell users how to fix a distro Orca can't host (D1c-1) #33085 earlier) and fix(wsl-mover): hold an app update install while a moved project comes back #35357; feat(wsl): offer Git for Windows in a Windows-drive WSL project's settings (D1c-3) #33097 now targets main. Every commit is kept. CI: running on this head.
• Re-review: drive mount points match case-sensitively (mountinfo gives the exact spelling), so a real /mnt/C directory never converts onto C:. Test added; the duplicate test now uses spellings that really are the same folder.
• Review fixes: only one UNC spelling of a drive folder converts (\\wsl$ vs \\wsl.localhost, /mnt/C vs /mnt/c compare equal); the others are refused as duplicates, for folder workspaces too. A path converts only when the distro's own mount table shows it is that Windows drive folder (main's drvfs/9p mountinfo parser); if the mounts can't be read, nothing converts.
• Kept here: the refused-WSL-path message is computed only on Windows with WSL hosts on.
• pnpm tc, pnpm run typecheck:ci, the PR's tests, check:code-quality:changed, the anti-slop oxlint, repo oxlint and ast-grep (including the no-real-time-sleep test rules) and the e2e typecheck ratchet all pass locally on this head, run one branch at a time.

[greptile-apps]

Confidence Score: 3/5

[Low impact] The changes stay within WSL project selection and repo registration.

The PR should not merge until the two existing mount-reading findings are fixed; both can let conversion select the wrong folder.

Findings

1.  Nested mounts select wrong folders ▶
2.  Incomplete mounts select wrong folders ▶

Summary

Adds helpers that identify WSL UNC projects backed by Windows drives and map their paths and worktree IDs to Windows spelling.

• Eligible WSL drive projects get mapped Windows paths for conversion.
• Repo registration explains when Windows blocks access to a WSL path.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Saved repository or folder] --> B{UNC path names the distro's drive folder?}
  B -- No --> C[Leave outside scope]
  B -- Yes --> D{Local and all saved paths map?}
  D -- No --> E[Refuse with reason]
  D -- Yes --> F{Mounts confirm the drive folder?}
  F -- No --> E
  F -- Yes --> G{Windows path already claimed?}
  G -- Yes --> E
  G -- No --> H[Include project in conversion scope]
  H --> I[Map paths and preserve worktree ID suffix]

Loading

_{Reviews (3) · Last reviewed commit: "Merge branch 'main' into nwparker/wsl-d1..." · Reviewed by Greptile}

[greptile-apps]

Nested mounts select wrong folders

readWslDistroDriveMounts drops non-Windows mounts before the folder check chooses the innermost mount. If /home/me/app is bind-mounted at /mnt/c/shared, the parser skips that ext4 mount and leaves only /mnt/c → C:\. The check then accepts \\wsl.localhost\Ubuntu\mnt\c\shared as C:\shared, although they are different folders.

The conversion caller in PR #33135 trusts this result when rewriting saved paths. Folder projects have no Git check to stop the wrong conversion. Keep non-Windows mounts as entries with windowsRoot: null so they block the parent drive match, and test with parsed mountinfo rather than a hand-built mount list.

[greptile-apps]

Incomplete mounts select wrong folders

If a distro's mount table exceeds the 1 MiB limit, runProcess keeps its beginning and sets outputTruncated. This code ignores that flag, and readStdout returns the captured text even when the closing marker is missing.

A parent drive mount can remain while a later nested mount is missing. Conversion then accepts a Windows folder that is not the UNC folder and rewrites saved paths to the wrong location. Return null when result.outputTruncated is true.

Suggested change

	const mountInfo = result.timedOut || result.code !== 0 ? null : fence.readStdout(result.stdout)
	const mountInfo =
	result.timedOut || result.code !== 0 || result.outputTruncated
	? null
	: fence.readStdout(result.stdout)

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: c4f4f6b3-88af-45f3-bab3-421b8c3b350e

Commits

Reviewing files that changed from the base of the PR and between e6a2708 and be42e48.

Files selected for processing: 8

• src/main/ipc/repos/local-repo-registration.ts
• src/main/persistence/moving-wsl-projects/wsl-move-scope.ts
• src/main/runtime/runtime-repository-registration-controller.ts
• src/main/wsl/wsl-drive-unc-mounts.ts
• src/main/wsl/wsl-drive-unc-project-scope.test.ts
• src/main/wsl/wsl-drive-unc-project-scope.ts
• src/main/wsl/wsl-unc-access-denied.test.ts
• src/main/wsl/wsl-unc-access-denied.ts

Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}