Repository navigation
fix(browser): bring the address bar back under the 400-line limit - #31727
Merged
Merged
Conversation
#31656 left BrowserAddressBar.tsx one counted line over max-lines, which fails Lint for every PR. The six copies of clear-a-timeout-ref become one helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31656 left
BrowserAddressBar.tsxone counted line over themax-lineslimit (401 of 400), so Lint fails on main and on every PR. The six copies of "clear this timeout ref" become oneclearTimerRefhelper; behavior is unchanged (the two sites that cleared without nulling reassign the ref on the next line).