fix(mobile): refresh chat file suggestions when the desktop connection changes

mobile/rpc-foundation/goldens/lifecycle-inventory-lifecycle.json

@@ -186,8 +186,8 @@
       {
         "id": "inventory-lifecycle.reset-before-1:settled",
         "observation": {
-          "sender": ["32c9018052ba", "2f1953cc0315"],
-          "payloads": ["8db0d1234c94", "c9b9d7a9b388"],
+          "sender": ["32c9018052ba"],
+          "payloads": ["8db0d1234c94"],
           "settlements": {
             "mount": "eb79a9b3682a",
             "old": "eb79a9b3682a",

mobile/src/session/use-mobile-native-chat-file-search.test.ts

@@ -178,6 +178,62 @@ describe('useMobileNativeChatFileSearch', () => {
     expect(state?.nativeChatFilePaths).toEqual(['docs/guide.md'])
   })
 
+  it.each([false, true])(
+    'retires cached queries after authority migration; legacy=%s',
+    async (legacy) => {
+      let generation = 1
+      const sendRequest = vi.fn(async (method: string) => {
+        if (legacy && method === 'files.searchPaths') {
+          return {
+            id: 'missing',
+            ok: false as const,
+            error: { code: 'method_not_found', message: 'Unknown method' }
+          }
+        }
+        return rpcSuccess([generation === 1 ? 'old/apple.ts' : 'new/apple.ts'])
+      })
+      await mount(fakeClient({ sendRequest, getGeneration: () => generation }))
+      act(() => state?.loadNativeChatFiles('apple'))
+      await act(async () => {
+        await vi.advanceTimersByTimeAsync(120)
+      })
+      expect(state?.nativeChatFilePaths).toEqual(['old/apple.ts'])
+      generation = 2
+      act(() => state?.loadNativeChatFiles('apple'))
+      await act(async () => {
+        await vi.advanceTimersByTimeAsync(120)
+      })
+      expect(state?.nativeChatFilePaths).toEqual(['new/apple.ts'])
+    }
+  )
+
+  it('rejects an old authority response before it can populate the cache', async () => {
+    let generation = 1
+    let resolveOld: (reply: Awaited<ReturnType<RpcClient['sendRequest']>>) => void = () => {}
+    const oldReply = new Promise<Awaited<ReturnType<RpcClient['sendRequest']>>>((resolve) => {
+      resolveOld = resolve
+    })
+    const sendRequest = vi.fn(() =>
+      generation === 1 ? oldReply : Promise.resolve(rpcSuccess(['new/apple.ts']))
+    )
+    await mount(fakeClient({ sendRequest, getGeneration: () => generation }))
+    act(() => state?.loadNativeChatFiles('apple'))
+    await act(async () => {
+      await vi.advanceTimersByTimeAsync(120)
+    })
+    generation = 2
+    await act(async () => {
+      resolveOld(rpcSuccess(['old/apple.ts']))
+      await oldReply
+    })
+    expect(state?.nativeChatFilePaths).toEqual([])
+    act(() => state?.loadNativeChatFiles('apple'))
+    await act(async () => {
+      await vi.advanceTimersByTimeAsync(120)
+    })
+    expect(state?.nativeChatFilePaths).toEqual(['new/apple.ts'])
+  })
+
   it('coalesces overlapping legacy inventory requests on a slow host', async () => {
     let resolveList: (value: Awaited<ReturnType<RpcClient['sendRequest']>>) => void = () => {}
     const listResponse = new Promise<Awaited<ReturnType<RpcClient['sendRequest']>>>((resolve) => {

mobile/src/session/use-mobile-native-chat-file-search.ts

@@ -29,6 +29,7 @@ export function useMobileNativeChatFileSearch(args: {
   const timerRef = useRef<ReturnType<typeof setTimeout> | null>(null)
   const sequenceRef = useRef(0)
   const queryCacheRef = useRef(new Map<string, string[]>())
+  const queryCacheGenerationRef = useRef<number | null>(null)
   const searchSupportedRef = useRef<boolean | null>(null)
   const inventory = useRef(
     new GenerationScopedRequestOwner<WorkspaceInventoryParameters, string[]>()
@@ -45,6 +46,7 @@ export function useMobileNativeChatFileSearch(args: {
   useEffect(() => {
     sequenceRef.current++
     queryCacheRef.current.clear()
+    queryCacheGenerationRef.current = null
     searchSupportedRef.current = null
     setNativeChatFilePaths([])
     return () => {
@@ -63,6 +65,13 @@ export function useMobileNativeChatFileSearch(args: {
       if (!client) {
         return
       }
+      const generation = client.getGeneration?.() ?? 0
+      if (queryCacheGenerationRef.current !== generation) {
+        queryCacheGenerationRef.current = generation
+        queryCacheRef.current.clear()
+        searchSupportedRef.current = null
+        inventory.reset()
+      }
       const normalizedQuery = query.trim().toLowerCase().slice(0, 256)
       const cached = queryCacheRef.current.get(normalizedQuery)
       if (cached) {
@@ -83,8 +92,12 @@ export function useMobileNativeChatFileSearch(args: {
       setNativeChatFilePaths([])
       timerRef.current = setTimeout(() => {
         timerRef.current = null
+        const isCurrentRequest = (): boolean =>
+          mountedRef.current &&
+          sequenceRef.current === sequence &&
+          (client.getGeneration?.() ?? 0) === generation
         const applyPaths = (paths: string[]): void => {
-          if (sequenceRef.current !== sequence) {
+          if (!isCurrentRequest()) {
             return
           }
           queryCacheRef.current.set(normalizedQuery, paths)
@@ -105,7 +118,7 @@ export function useMobileNativeChatFileSearch(args: {
           // reconnect to the same host leaves the files on disk alone, so the physical session
           // epoch is deliberately not in it. Read once, so a cutover between the two calls below
           // cannot put one attempt in two scopes.
-          const inventoryScope: RequestScope = [client, worktreeId, client.getGeneration?.() ?? 0]
+          const inventoryScope: RequestScope = [client, worktreeId, generation]
           const held = inventory.read(inventoryScope, WHOLE_WORKSPACE)
           if (held) {
             applyPaths(rankSuggestions(held, normalizedQuery, FILE_SEARCH_RESULT_LIMIT))
@@ -126,6 +139,9 @@ export function useMobileNativeChatFileSearch(args: {
           applyPaths(rankSuggestions(loaded.value, normalizedQuery, FILE_SEARCH_RESULT_LIMIT))
         }
         void (async () => {
+          if (!isCurrentRequest()) {
+            return
+          }
           if (searchSupportedRef.current === false) {
             await loadLegacyPaths()
             return
@@ -136,6 +152,9 @@ export function useMobileNativeChatFileSearch(args: {
             limit: FILE_SEARCH_RESULT_LIMIT
           })
           const accepted = nativeChatFileSearchRead.interpret(response)
+          if (!isCurrentRequest()) {
+            return
+          }
           if (accepted.accepted) {
             searchSupportedRef.current = true
             applyPaths(accepted.value)

mobile/src/test-support/rpc-recording/derived-goldens.ts

@@ -54,10 +54,13 @@ function baseScenario(manifest: readonly RecordingScenario[], id: string): Recor
 }
 
 function omitRetiredInventoryAdmission(scenario: RecordingScenario): RecordingScenario {
-  if (scenario.id !== 'inventory-lifecycle.unmount-before-1') {
+  if (
+    scenario.id !== 'inventory-lifecycle.unmount-before-1' &&
+    scenario.id !== 'inventory-lifecycle.reset-before-1'
+  ) {
     return scenario
   }
-  // A late search refusal cannot start an inventory after this owner's unmount.
+  // A late search refusal cannot start an inventory after its owner retires.
   return {
     ...scenario,
     steps: scenario.steps.filter(

mobile/src/test-support/rpc-recording/inventory-lifecycle-derivation.test.ts

@@ -5,7 +5,7 @@ import { hoistPreludeCheckpoints } from './prelude-checkpoints'
 import { readScenarios } from './scenario-input'
 import { bindCompletions, lifecycleSchedules } from './schedule-driver'
 
-it('omits only the inventory admission following a refusal to a fully unmounted owner', () => {
+it('omits only inventory admission following a refusal to a retired owner', () => {
   const manifest = readScenarios(
     resolve(import.meta.dirname, '../../../rpc-foundation/pilot-scenarios.json')
   )
@@ -27,12 +27,13 @@ it('omits only the inventory admission following a refusal to a fully unmounted
   expect(derived.map((scenario) => scenario.id)).toEqual(original.map((scenario) => scenario.id))
   expect(derived).toHaveLength(12)
   for (const [index, scenario] of original.entries()) {
-    if (scenario.id !== 'inventory-lifecycle.unmount-before-1') {
+    const unmounted = scenario.id === 'inventory-lifecycle.unmount-before-1'
+    if (!unmounted && scenario.id !== 'inventory-lifecycle.reset-before-1') {
       expect(derived[index]).toEqual(scenario)
       expect(JSON.stringify(derived[index])).toBe(JSON.stringify(scenario))
       continue
     }
-    expect(scenario.steps).toHaveLength(13)
+    expect(scenario.steps).toHaveLength(unmounted ? 13 : 11)
     expect(scenario.steps.slice(7, 10)).toEqual([
       { bind: 'old-inventory', request: 'files.list#1', params: { worktree: 'id:A' } },
       { bind: 'lifecycle-old-inventory', request: 'old-inventory', params: { worktree: 'id:A' } },
@@ -51,7 +52,7 @@ it('omits only the inventory admission following a refusal to a fully unmounted
     expect(expected.steps.filter((step) => 'checkpoint' in step)).toEqual([
       { checkpoint: 'lifecycle-boundary' },
       { checkpoint: 'settled' },
-      { checkpoint: 'remounted' }
+      ...(unmounted ? [{ checkpoint: 'remounted' }] : [])
     ])
     expect(expected.steps.filter((step) => 'bind' in step)).toEqual([
       {

src/renderer/src/components/browser-pane/ClientHostedBrowserPagePane.tsx

@@ -146,10 +146,7 @@ export function ClientHostedBrowserPagePane({
   // Why: the tour points at controls that cannot work yet, and recording the interaction is a
   // one-way write that would burn the tour on a pane the user has not really seen.
   useClientHostedBrowserIntroTour(isActive && !attachmentError && placement !== null)
-  useBrowserPageFindShortcuts({
-    ...shortcutOwner,
-    setFindOpen
-  })
+  useBrowserPageFindShortcuts({ ...shortcutOwner, setFindOpen })
   useBrowserPageWebviewShortcuts({
     ...shortcutOwner,
     isActiveRef,
@@ -241,9 +238,7 @@ export function ClientHostedBrowserPagePane({
       const activeLoadFailure = activeLoadFailureRef.current
       // URL writes clear certificate challenges, so preserve them while a failure stands.
       if (!activeLoadFailure) {
-        setUrlFromGuest(browserTab.id, metadata.url, {
-          preserveLoadError: true
-        })
+        setUrlFromGuest(browserTab.id, metadata.url, { preserveLoadError: true })
       }
       updatePageStateFromGuest(browserTab.id, {
         title: metadata.title,

src/renderer/src/i18n/locales/pt.json

@@ -8163,8 +8163,6 @@
           "5f5142a62a": "Ícone anterior"
         },
         "BrowserDefaultZoomSetting": {
-          "2622126877": "Nível de zoom aplicado às abas de navegador recém-abertas.",
-          "bbeec087d3": "Aplicado às abas de navegador recém-abertas.",
           "265597101f": "Zoom Padrão"
         },
         "BrowserUseComputerUseNotice": {