Skip to content

fix(mobile): keep review-note drafts with the file they belong to - #31698

Merged
nwparker merged 1 commit into
stablyai:mainfrom
nwparker:nwparker/mobile-monkey-review-document-owner
Oct 21, 2026
Merged

nwparker merged 1 commit into
stablyai:mainfrom
nwparker:nwparker/mobile-monkey-review-document-owner

Conversation

@nwparker

@nwparker nwparker commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

Start writing a review note on one file, then open another. The first file's draft can appear on the second file, or a slow save from the first file can close the new note box. This fix starts a separate note editor for each document.

What Changed

  • Clear the old note editor when you open a different document.
  • Stop a save from the previous document from closing the current note editor.
  • Keep documents separate even when their file paths happen to match.

Why

A review note should stay attached to the file you wrote it for.

Linked Issue

Maintainer-discovered regression. Bounded GitHub symptom and exact-file searches found no exact duplicate. No matching issue or exact PR found in bounded symptom/file searches.

Visual Proof

Captured with the visual-proof skill. Before uses base 15246eb4a45; after uses this PR's standalone commit add6844ec74. The scenario passed asserted capture runs 3 times per version before representative screenshots were selected. The captures were visually inspected.

Evidence scope: Actual production FileReader/DiffLineRow RN Web; draft path switch and late-save ownership.

01-path-03-save-a-completed.png 02-path-03-save-a-completed.png
01-path-03-save-a-completed.png 02-path-03-save-a-completed.png

The hook/transport boundary harnesses are labeled in the captures. These are browser evidence where stated; they do not establish native keyboard, gesture, permission dialog, safe-area or real-network behavior. Full code regressions cover additional cases described above.

Testing

  • Regression tests added or updated.
  • Full native device verification for every race.
ORCA_BACKGROUND_LAUNCH=1 pnpm --dir mobile test src/session/mobile-file-review-draft.test.tsx

The combined mobile change set passed 410 suites / 3,626 tests, production typecheck, the tests-typecheck ratchet, formatting, the changed-code quality gate, and the mobile-web build/asset verifier on macOS. These aggregate results are not a claim that the entire suite was rerun on this isolated branch. PR CI validates the branch against current main.

Review

Merge risk: Low. A small change to how the note editor is reset; switching documents intentionally closes its unfinished draft.

Previously reviewed by a separate agent team; reported issues were fixed and checked again.

Agent skill upstream boundary

  • Not applicable; this change copies no upstream skill-installer implementation.

Notes

Existing RPC methods and wire compatibility are retained. Review considered desktop host changes, remote execution authority, folder workspaces, and native/web consumers. Native simulator follow-up was limited after the three owned simulators became stuck shutting down; no unrelated simulator/process was reset.

Checklist

  • Focused change with a root-cause explanation.
  • Automated regression coverage and independent review.
  • Before/after proof attached with exact evidence scope.
  • Cross-platform and remote compatibility considered.
  • Required PR CI checks have passed.

A reused file reader carries a note composer into another document, and a late submission closes the new composer. Give document state and callbacks a keyed lifetime.
@nwparker
nwparker marked this pull request as ready for review October 21, 2026 23:34
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a917f6c1-42fa-4fa0-a99d-d9512bab9da9
📥 Commits

Reviewing files that changed from the base of the PR and between 10d4104 and add6844.

📒 Files selected for processing: 3
  • mobile/src/session/MobileSessionActiveContent.tsx
  • mobile/src/session/MobileSessionFileReader.tsx
  • mobile/src/session/mobile-file-review-draft.test.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit 1543074 into stablyai:main Oct 21, 2026
43 checks passed
@nwparker nwparker changed the title fix(mobile): isolate file review composers by document fix(mobile): keep review-note drafts with the file they belong to Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant