Repository navigation
fix(mobile): use port 443 for explicit WSS host edits - #31659
Merged
Merged
Conversation
Adapt the mobile address-editing fix from community PR #31499. Keep bare-host inheritance, explicit ports, and stored routes intact. Co-authored-by: Chun Chet Ng <ngchunchet95@gmail.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 of 8 tasks
6 of 7 tasks
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
When you replace a saved local address with a secure tunnel URL, the phone now uses the normal secure port, 443. It previously kept the old local port, such as 6768.
What Changed
wss://inputs without a port use 443 when editing a saved host.Why
The edit resolver supplied the saved port before considering an explicitly entered secure URL. This adjusts that fallback and reuses the existing normalizer and save flow.
Linked Issue
No separate issue identified for this address-editing symptom. Adapted from the mobile portion of community PR #31499; broader tunnel feature requests remain open.
Visual Proof
Real React Native Edit host screen on an iOS 26.1 simulator, captured without showing Simulator or taking desktop focus. Same synthetic saved LAN endpoint and same typed URL before/after. Visually checked both captures: the form remains legible and the preview changes from 6768 to 443.
Testing
wss://tunnel.example.com:443through the real host-store/AsyncStorage path; readback and device storage manifest agree.tsc --noEmit -p mobile/tsconfig.json), changed-code quality gate, formatting, and diff whitespace checks pass. Typecheck used the repository-patched WebView declaration in a private dependency overlay; shared dependencies were not edited.Review / Community attribution
Adapted the address-editing approach from #31499 by @chunchet-ng (Chun Chet Ng). Commit includes
Co-authored-by: Chun Chet Ng <ngchunchet95@gmail.com>using the community commit's author identity. Independent Codex peer review found no issues.Merge risk / Limitations
Low: four files, one port-selection fallback, copy, and focused regression coverage. No wire format, server behavior, platform-specific process/path handling, workspace assumptions, or new dependency. Mixed-version local/remote hosts keep the same connection contract. Android native execution and a live tunnel connection were not exercised; CI remains required.
Agent skill upstream boundary
Checklist
Compatibility review: saved host records are not migrated or rewritten. A name-only or no-op Save preserves the endpoint and route suffix; an explicit custom port wins, and a bare hostname inherits the saved scheme/port. The deliberate change applies when an edit explicitly enters
wss://new-hostwithout a port: it uses 443 instead of carrying forward the old 6768/8443 port. Users moving to another host on a custom TLS port must enter it, for examplewss://new-host:8443. All 74 endpoint/edit/save checks pass again.