Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
f672603
feat(sidebar): turn on main-owned sidebar inputs for every build (fli…
Oct 19, 2026
42bdbc5
fix(sidebar): the window never stamped a paired server's rows, so kee…
Oct 19, 2026
fa1b102
test(sidebar): Mark as read drops a pending raise; drop tests the sta…
Oct 19, 2026
c8ebb50
test: drop an unused import
Oct 19, 2026
e60f563
test: pass the row's host to Mark as read
Oct 19, 2026
b9433f9
test(e2e): pick the sidebar's last row only once the list end has ren…
Oct 19, 2026
804975c
test(e2e): count a native drop as the drag's input; wait for the phon…
Oct 19, 2026
4f80b8c
test(e2e): dismiss the setup-script prompt when it covers the sidebar…
Oct 19, 2026
a88afdd
test(e2e): sample the sidebar on DOM changes too, since a hidden Linu…
Oct 19, 2026
28ff1f7
test(e2e): tag frame-log samples by source; painted-frame checks read…
Oct 19, 2026
f4d5563
test(e2e): dismiss the setup-script prompt through its store action, …
Oct 19, 2026
d4b5c4f
fix(sidebar): a held Smart order releases after the list commits a dr…
Oct 20, 2026
2bb9162
fix(sidebar): release a drag's order hold on dragend, which always fo…
Oct 20, 2026
758ba01
test(e2e): name the proven cause of the sort-stamps race: hooks poste…
Oct 20, 2026
e219e6d
fix(sidebar): the window lists only the creations it draws, so a fini…
Oct 20, 2026
be74ac4
fix(sidebar): a deferred unread raise flips the folder row it was dec…
Oct 20, 2026
d71745b
test(e2e): reads-main proves drag, open, collapse and create from the…
Oct 20, 2026
6c7bb44
fix(sidebar): main fetches a paired server's rows with the normal req…
Oct 20, 2026
8bf4c22
fix(mobile): file projects under their project group on the phone, as…
Oct 20, 2026
21b6c22
fix(mobile): indent rows inside a project group by its depth, as the …
Oct 20, 2026
b7c061e
fix(sidebar): on launch the window draws main's rows only once its sa…
Oct 20, 2026
8b0e04e
Merge branch 'pr-31053' into sidebar-flip-a-flake
Oct 20, 2026
77a82b9
fix(mobile): space the pending-collapse spinner off a section's count
Oct 20, 2026
539fa4a
Merge remote-tracking branch 'origin/main' into HEAD
Oct 20, 2026
2fe4926
test(sidebar): typecheck the phone feed tests against the project-gro…
Oct 20, 2026
e320b7e
Merge remote-tracking branch 'origin/main' into sidebar-flip-a
Jinwoo-H Oct 20, 2026
8dd366f
test(sidebar): use-sort-order expects host-identity keys with the swi…
Jinwoo-H Oct 20, 2026
24fb57c
fix(mobile): the pending-collapse spinner shows only once the desktop…
Jinwoo-H Oct 20, 2026
746e214
test(sidebar): fit the switch-on fixtures to main's project catalog d…
Jinwoo-H Oct 20, 2026
01a6b9e
test(sidebar): pin the switch off in the two tests of the window-publ…
Jinwoo-H Oct 20, 2026
d94cc40
fix(mobile): highlight the workspace this phone last opened on the ho…
Jinwoo-H Oct 20, 2026
ff42175
Merge remote-tracking branch 'origin/main' into sidebar-flip-a
Jinwoo-H Oct 20, 2026
ec08840
test(e2e): the phone feed-list helper matches the host platform again…
Jinwoo-H Oct 20, 2026
a0e6cd8
fix(sidebar): a slept workspace leaves the list at once under Hide sl…
Jinwoo-H Oct 20, 2026
8989273
fix(mobile): the phone highlights only its own last-opened workspace,…
Jinwoo-H Oct 21, 2026
e696ff6
fix(mobile): the phone's host list never flashes a list shaped unlike…
Jinwoo-H Oct 21, 2026
d8444d9
fix(mobile): the phone's host list falls back to the plain list when …
Jinwoo-H Oct 21, 2026
8465608
fix(sidebar): closing a last tab and deleting a workspace leave the l…
Jinwoo-H Oct 21, 2026
6dbe87e
Merge remote-tracking branch 'origin/main' into sidebar-flip-a-merge
Jinwoo-H Oct 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions config/dark-build-switches.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ const { join } = require('node:path')
// release orcad template also refuse the variable itself.
const DARK_BUILD_SWITCHES = [
// src/shared/layout-owner-switch.ts
{ variable: 'ORCA_LAYOUT_OWNER', off: 'window' },
// src/shared/sidebar-inputs-switch.ts
{ variable: 'ORCA_SIDEBAR_INPUTS', off: 'window' }
{ variable: 'ORCA_LAYOUT_OWNER', off: 'window' }
]

function markerFileName(darkSwitch) {
Expand Down
39 changes: 21 additions & 18 deletions config/scripts/dark-build-switches.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,13 @@ afterEach(async () => {
})

describe('dark build switches', () => {
it.each(['ORCA_LAYOUT_OWNER', 'ORCA_SIDEBAR_INPUTS'])(
'compiles the dark path in only when %s=main asks',
(variable) => {
expect(darkBuildDefines({ [variable]: 'main' })[variable]).toBe('"main"')
expect(darkBuildDefines({ [variable]: 'window' })[variable]).toBe('"window"')
expect(darkBuildDefines({})[variable]).toBe('"window"')
expect(turnedOnDarkBuildDefines({ [variable]: 'main' })).toEqual({ [variable]: '"main"' })
expect(turnedOnDarkBuildDefines({})).toEqual({})
}
)
it.each(['ORCA_LAYOUT_OWNER'])('compiles the dark path in only when %s=main asks', (variable) => {
expect(darkBuildDefines({ [variable]: 'main' })[variable]).toBe('"main"')
expect(darkBuildDefines({ [variable]: 'window' })[variable]).toBe('"window"')
expect(darkBuildDefines({})[variable]).toBe('"window"')
expect(turnedOnDarkBuildDefines({ [variable]: 'main' })).toEqual({ [variable]: '"main"' })
expect(turnedOnDarkBuildDefines({})).toEqual({})
})

it('keeps the layout-owner marker name packaging already refuses', () => {
expect(darkBuildMarkers({ ORCA_LAYOUT_OWNER: 'main' })).toEqual([
Expand All @@ -39,7 +36,7 @@ describe('dark build switches', () => {
expect(darkBuildMarkers({})).toEqual([])
})

it.each(['ORCA_LAYOUT_OWNER', 'ORCA_SIDEBAR_INPUTS'])(
it.each(['ORCA_LAYOUT_OWNER'])(
'refuses %s at packaging time, and any output its dark build marked',
async (variable) => {
const clean = await mkdtemp(join(tmpdir(), 'orca-dark-build-clean-'))
Expand All @@ -54,17 +51,23 @@ describe('dark build switches', () => {
}
)

it.each([
['ORCA_LAYOUT_OWNER', 'ORCA_SIDEBAR_INPUTS'],
['ORCA_SIDEBAR_INPUTS', 'ORCA_LAYOUT_OWNER']
])('lets a dark build carry its own %s output, never one of %s', async (own, other) => {
it('lets a dark build carry its own output, and refuses it in any other build', async () => {
const dark = await mkdtemp(join(tmpdir(), 'orca-dark-build-own-'))
scratch.push(dark)
const [marker] = darkBuildMarkers({ [own]: 'main' })
const [marker] = darkBuildMarkers({ ORCA_LAYOUT_OWNER: 'main' })
await writeFile(join(dark, marker.fileName), marker.text)

expect(() => assertNoDarkOutputOfOffSwitches([dark], { [own]: 'main' })).not.toThrow()
expect(() => assertNoDarkOutputOfOffSwitches([dark], { [other]: 'main' })).toThrow(dark)
expect(() =>
assertNoDarkOutputOfOffSwitches([dark], { ORCA_LAYOUT_OWNER: 'main' })
).not.toThrow()
expect(() => assertNoDarkOutputOfOffSwitches([dark], {})).toThrow(dark)
})

it('no longer treats the retired sidebar-inputs switch as dark', () => {
expect(darkBuildDefines({ ORCA_SIDEBAR_INPUTS: 'main' })).not.toHaveProperty(
'ORCA_SIDEBAR_INPUTS'
)
expect(darkBuildMarkers({ ORCA_SIDEBAR_INPUTS: 'main' })).toEqual([])
expect(() => assertNotDarkBuild([], { ORCA_SIDEBAR_INPUTS: 'main' })).not.toThrow()
})
})
2 changes: 1 addition & 1 deletion config/scripts/generate-rpc-params-catalog.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function loadRegistryAndSchemas(modules) {
logLevel: 'error',
packages: 'external',
// Why: the catalog types every method a build can register, every dark switch's included.
define: { ORCA_LAYOUT_OWNER: '"main"', ORCA_SIDEBAR_INPUTS: '"main"' }
define: { ORCA_LAYOUT_OWNER: '"main"' }
})
const loaded = createRequire(import.meta.url)(outfile)
return { methods: loaded.ALL_RPC_METHODS, schemaModules: loaded.SCHEMA_MODULES }
Expand Down
6 changes: 3 additions & 3 deletions config/scripts/mobile-web-bundle-manifest.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ describe('writeMobileWebBundleTree', () => {
protocolWindow: { runtimeProtocolVersion: 3, minCompatibleRuntimeProtocolVersion: 3 },
env
})
const dark = await tree({ ORCA_SIDEBAR_INPUTS: 'main' })
expect(existsSync(join(outDir, 'ORCA_SIDEBAR_INPUTS_MAIN'))).toBe(true)
const dark = await tree({ ORCA_LAYOUT_OWNER: 'main' })
expect(existsSync(join(outDir, 'ORCA_LAYOUT_OWNER_MAIN'))).toBe(true)
const off = await tree({})
expect(existsSync(join(outDir, 'ORCA_SIDEBAR_INPUTS_MAIN'))).toBe(false)
expect(existsSync(join(outDir, 'ORCA_LAYOUT_OWNER_MAIN'))).toBe(false)
expect(dark.manifest.buildId).toBe(off.manifest.buildId)
} finally {
await rm(outDir, { recursive: true, force: true })
Expand Down
4 changes: 2 additions & 2 deletions config/scripts/orcad-mobile-web-bundle.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ it('stages the manifest and every asset it lists, byte for byte', async () => {
})

it('stages a dark page into a dark orcad, and refuses it in any other', async () => {
vi.stubEnv('ORCA_SIDEBAR_INPUTS', 'main')
vi.stubEnv('ORCA_LAYOUT_OWNER', 'main')
await writeMobileWebBundleFixtureTree({ outDir: bundleDir })
stageOrcadMobileWebBundle(outputDir, bundleDir)
expect(existsSync(join(outputDir, ORCAD_MOBILE_WEB_MANIFEST))).toBe(true)

vi.unstubAllEnvs()
rmSync(outputDir, { recursive: true, force: true })
expect(() => stageOrcadMobileWebBundle(outputDir, bundleDir)).toThrow('ORCA_SIDEBAR_INPUTS=main')
expect(() => stageOrcadMobileWebBundle(outputDir, bundleDir)).toThrow('ORCA_LAYOUT_OWNER=main')
expect(existsSync(join(outputDir, ORCAD_MOBILE_WEB_MANIFEST))).toBe(false)
})

Expand Down
4 changes: 2 additions & 2 deletions config/scripts/verify-packaged-mobile-web-bundle.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -169,15 +169,15 @@ describe('electron-builder packaging wiring', () => {

it('verifies a dark page build, and refuses to package it', async () => {
await withBundle(async ({ bundleDir }) => {
const [marker] = darkBuildMarkers({ ORCA_SIDEBAR_INPUTS: 'main' })
const [marker] = darkBuildMarkers({ ORCA_LAYOUT_OWNER: 'main' })
await writeFile(join(bundleDir, marker.fileName), marker.text, 'utf8')
expect(() => assertMobileWebBundleBuilt(bundleDir)).not.toThrow()
expect(() =>
electronBuilderConfig.beforePack(
{ electronPlatformName: process.platform, arch: process.arch === 'arm64' ? 3 : 1 },
bundleDir
)
).toThrow(`${bundleDir} holds an ORCA_SIDEBAR_INPUTS=main build`)
).toThrow(`${bundleDir} holds an ORCA_LAYOUT_OWNER=main build`)
})
})

Expand Down
Loading
Loading