Repository navigation
refactor(renderer): one twin check, one worktree-copy scan, drop stale resolver mocks - #30579
Merged
Merged
Conversation
…e resolver mocks - isTwinWorkspace replaces four inline resolveOwner(...).kind === 'ambiguous' checks - someWorktreeCopy shared by isUnprovenServerSshRoute and hasHostEvidence - file-explorer owner: drop the unreachable second unresolved guard and the stale comment - native chat owner: drop a null ternary the helper already handles - tests: delete stale getRuntimeEnvironmentIdForWorktree mocks (29 suites), one shared local+ssh twin fixture, file:// open-target tests next to their module, reset mocks.twin
nwparker
force-pushed
the
nwparker/r3-cleanpass-2
branch
from
October 19, 2026 06:18
1c81791 to
2872c9d
Compare
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 14 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly and concisely identifies the main refactor: centralizing twin checks, sharing worktree-copy scanning, and removing stale resolver mocks. Description check The description is complete and aligned with the template. It explains the user impact, changes, rationale, linked issue context, testing, review results, scope, and compatibility considerations.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 2
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
A tidy-up after the last batch of "which machine owns this project" changes. Nothing the user sees changes. Repeated checks become one named check, a duplicated scan becomes one helper, and about 30 test files stop pretending to stub a function the code no longer calls.
What Changed
isTwinWorkspace(state, workspaceId)inlib/resolve-owner.tsreplaces four inlineresolveOwner(...).kind === 'ambiguous'checks: file preview, the file:// open target, the doc-preview "open externally" action and the file-search runner.someWorktreeCopydoes the listed-plus-detected row scan thatisUnprovenServerSshRouteandhasHostEvidenceeach did on their own.getRuntimeEnvironmentIdForWorktreemocks are deleted from 29 suites. The code under test stopped importing it during the F2–F7 folds.web-runtime-session.test.tsnow names its mock after the helper it really stubs.lib/workspace-twin-rows.test-fixture.ts.workspace-file-browser-open-target.test.ts, next to their module.mocks.twinis reset inbeforeEach.Before and after for the user: identical.
Why
These are the follow-ups from the second clean-code pass over #30478, #30484, #30497 and #30562. Each removes a copy or a dead branch, so the next owner-resolution change has one place to edit. The stale mocks matter because they make a suite look as if it controls the owner when it doesn't. F8 deletes the deprecated resolver, and any mock still naming it would have to be cleaned up then anyway.
Alternative considered: merging
runtimeEnvironmentIdUnlessTwinwith the legacy-fallback wrapper now. It was held back on purpose, because that only becomes safe once F8 removes the legacy branch.Linked Issue
Internal SSH hardening, round 3 (clean-code pass 2). Stacked on #30562; it will be rebased onto main once that merges.
Visual Proof
N/A: no UI or behaviour change. Refactor and test clean-up only.
Testing
src/renderer/src/lib,components/right-sidebar,components/browser-pane,components/native-chat,runtime,components/activity,components/tab-group. Result: 1,865 files and 17,915 tests passed.Review
Codex clean; Opus clean.
Agent skill upstream boundary
Notes
SSH and folder workspaces: the owner answers are unchanged. The twin check is the same
resolveOwnercall, just behind a name.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)