Repository navigation
test(terminal): load the host runtime in setup so the alt-screen chain fits its test limit - #29661
Merged
Merged
Conversation
…n fits its test limit
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9 tasks done
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
One terminal test fails on main, without any PR changing it, whenever the whole
terminal-panetest folder runs at once. Its first case loads Orca's entire main-process runtime from scratch inside the test itself, which takes about 19 seconds on its own. When the folder runs in parallel, that crosses the 30-second test limit. The half-finished first test then breaks the other two. This loads the runtime once, before the tests start, so all three fit easily.What Changed
src/renderer/src/components/terminal-pane/remote-snapshot-alt-screen-host-chain.test.ts: the three main-side modules the test needs now load once in abeforeAll, in parallel, instead of cold inside the first test's body. The test logic and assertions are unchanged, and no timeout was raised.Why
Not a timeout bump: raising the timeout would just hide a 19-second cold load. Loading in setup makes the first case take about 222 ms in a full folder run.
Reproduced on main: on
origin/main(ebb9e32),pnpm test src/renderer/src/components/terminal-panefails all 3 cases of this file. With this change, 522 of 522 test files pass.Linked Issue
N/A (maintainer; CI flake found while running the terminal-pane suite for #29526).
Visual Proof
N/A: test-only change.
Testing
terminal-panefolderAI Disclosure
Review
Agent skill upstream boundary
Notes
Test-only. The same commit is in #29526's branch; once this lands on main, that branch drops it as already applied when it rebases.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)