Repository navigation
fix(remote): send again a tab close the paired host never received #29468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
816bf8a
fix(remote): send again a tab close the paired host never received
nwparker ab88832
fix(remote): replay held closes at snapshot receipt, pinned to their …
nwparker 82b60d8
fix(remote): consume held closes only on authoritative snapshots, and…
nwparker 34fe7fe
fix(remote): keep held closes through incomplete inventories, and re-…
nwparker d9ce987
fix(remote): re-list the worktree after a failed close replay
nwparker e79d3c7
fix(remote): re-list the worktree as soon as a close is held
nwparker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Treat a definitive refusal of a replayed close as settled, not as a retry.
closeWebRuntimeSessionTabreturns'failed'for two different cases:RuntimeRpcCallErrorcode that is not inUNDELIVERED_CLOSE_CODES.On a refusal, the inner catch takes the
elsebranch at Line 324-331 and clears the close intents. The tab becomes visible again. Line 150 still passesdelivered = false, so the replay stays inpendingReplaysas'retry'. The next snapshot that lists the tab then runsreplayWebSessionClosesDueForSnapshot. That call hides the tab again and sends the close again. The tab flickers and the close is resent until the attempt limit is reached.The comment at Line 93-94 says a structured refusal "is an answer." The replay path does not follow that contract.
The fix: return a distinct outcome for undelivered failures, or have the replay classify the error. Settle as delivered when the failure is a definitive refusal.
Proposed direction
If you add a new outcome value, check the existing callers that compare against
'failed'.