Skip to content

[CI] Cancel superseded PR cache warmers - #29279

Merged
nwparker merged 1 commit into
mainfrom
nwparker/cancel-outdated-pr-runs
Oct 16, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/cancel-outdated-pr-runs

Conversation

@nwparker

@nwparker nwparker commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​4 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​4
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​4 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​4

ELI5

When a pull request gets a new commit, the older cache-warming check could keep running. The newer commit now replaces that older run.

What Changed

Added workflow-level concurrency to the platform cache warmup workflow. Pull request runs share a group keyed by PR number and cancel any earlier run when a new PR update starts. Main-branch pushes keep their existing independent behavior.

Added a workflow contract assertion so this cancellation policy stays in place.

Why

The main PR checks already cancel superseded runs, but this PR-triggered workflow was the remaining exception. Putting the policy at the caller workflow level also covers its reusable workflow invocation.

Linked Issue

Maintainer CI maintenance; no separate issue created.

Visual Proof

N/A — CI workflow behavior only; there is no visual or interaction change.

Testing

  • pnpm exec vitest run --config config/vitest.config.ts config/scripts/ci-dependency-download-cache.test.mjs

  • pnpm run check:code-quality:changed

  • git diff --check

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

The automated workflow contract test covers the new concurrency policy.

Review

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

The change only affects GitHub Actions scheduling and is independent of operating system, SSH, mobile, and runtime behavior.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fccdb220-6faa-48ff-bbfe-b456d9db5905
📥 Commits

Reviewing files that changed from the base of the PR and between e9f1835 and cd418c6.

📒 Files selected for processing: 2
  • .github/workflows/ci-cache-warmup-platforms.yml
  • config/scripts/ci-dependency-download-cache.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit f670683 into main Oct 16, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant