Repository navigation
[CI] Cancel superseded PR cache warmers - #29279
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
When a pull request gets a new commit, the older cache-warming check could keep running. The newer commit now replaces that older run.
What Changed
Added workflow-level concurrency to the platform cache warmup workflow. Pull request runs share a group keyed by PR number and cancel any earlier run when a new PR update starts. Main-branch pushes keep their existing independent behavior.
Added a workflow contract assertion so this cancellation policy stays in place.
Why
The main PR checks already cancel superseded runs, but this PR-triggered workflow was the remaining exception. Putting the policy at the caller workflow level also covers its reusable workflow invocation.
Linked Issue
Maintainer CI maintenance; no separate issue created.
Visual Proof
N/A — CI workflow behavior only; there is no visual or interaction change.
Testing
pnpm exec vitest run --config config/vitest.config.ts config/scripts/ci-dependency-download-cache.test.mjspnpm run check:code-quality:changedgit diff --checkI manually tested these changes locally
Automated tests added/updated, or explained why not below
The automated workflow contract test covers the new concurrency policy.
Review
Agent skill upstream boundary
Notes
The change only affects GitHub Actions scheduling and is independent of operating system, SSH, mobile, and runtime behavior.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)