ci: reduce fixture startup and shutdown waits by nwparker · Pull Request #29163 · stablyai/orca

nwparker · 2026-10-15T14:22:32Z

	Files	Added	Deleted	Net
Test	129	$\color{#1a7f37}{\Huge{\mathbf{+}}}$10877	$\color{#cf222e}{\Huge{\mathbf{−}}}$10338	$\color{#1a7f37}{\Huge{\mathbf{+}}}$539
Prod	11	$\color{#1a7f37}{\Huge{\mathbf{+}}}$11	$\color{#cf222e}{\Huge{\mathbf{−}}}$11	0

ELI5

Small tests were repeatedly loading large fixtures and waiting through shutdown delays. This keeps their behavior checks while doing less setup and waiting.

What Changed

Combine 49 database test entry points into six domain suites. Keep all 469 cases, original assertion bodies, private hooks, and Node routing in imported registration files.
Give 21 pure renderer tests the existing throwing app-store fixture, with a check that the store was never touched. Import the existing remote-terminal predicate directly in 11 consumers instead of loading its store facade; its function and callers remain the same.
Use an existing 20 ms shutdown override in one real-child ACP test while retaining the separate 4,000 ms production-default boundary check and the real EOF/process-exit witnesses.
Run the independent Codex stdin-race case alongside two already concurrent modes. Retain four cases, all 160 real launches, per-mode serial ordering, assertions, and cleanup.
Assert successful exit in the existing installed-CLI smoke tests, addressing the minor review note from ci: trim redundant tests and consolidate suite startup #29156.
Close tracked journals after each rejection-batch case and restore maintenance fake timers in a finally block, keeping failures from leaking state into neighboring suites.

Why

These changes remove measured repeated work without reducing worker counts or skipping behavior checks. The logger-fixture split was excluded after mixed timing results. Reusing existing predicates, fixtures, and timeout overrides keeps the change smaller than introducing a new test runtime or cache.

Linked Issue

Maintainer-requested CI capacity work; no separate issue.

Visual Proof

N/A — test organization and equivalent import paths; no rendered UI or interaction change.

Testing

I manually tested these changes locally
Automated tests added/updated, or explained why not below

macOS, pinned Bun 1.4.3 with ordinary Bun/Node routing and four fixed workers: four fresh-cache runs in candidate/baseline/baseline/candidate order on the final cleanup source. All 1,088 cases passed every time; entry points fell from 116 to 73. Candidate runs: 24.71 and 23.45 seconds; baseline: 28.81 and 28.81 seconds. Scoped median: 28.81 to 24.08 seconds (-16.4%); worker median: 99.66 to 74.23 seconds (-25.5%). These are focused local observations, not a whole-CI speedup claim.

All four CI typecheck projects, changed-code quality, scoped formatting/lint pass on final commit 949c9f1. The full native-plugin check with the existing local mobile import-cycle allowance and all 146 reliability gates passed on its parent; the final two-file delta changes cleanup only. Independent source review checks moved bodies, literal values, registration counts, hook isolation, current references, and the two explicit cleanup corrections. All four benchmark runs were refreshed after those corrections, against base 507d0a9. Full exact-head hosted verification is required before merge. Superseded workflows were canceled to release their runners.

AI Disclosure

Review

Domain reviews cover assertion preservation, mock and lifecycle isolation, production initialization paths, child-process ownership, and current test routing. Runtime case catalogs and final source bytes are bound to the reviewed local evidence; hosted logs and artifacts will be reconciled before merge.

Agent skill upstream boundary

Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Equivalent predicate imports preserve native, SSH, and folder-workspace behavior. Database suites retain Node execution and all original cases. Process timings change only through existing test overrides or independent test scheduling.

Checklist

This PR is small and focused
I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
Before/after screenshots or videos attached for UI changes, or N/A with reason
Self-reviewed for correctness, security, and performance
Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

coderabbitai · 2026-10-15T14:38:36Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 7b6efc66-a69b-4ba5-b4cf-b37810601a5e

📥 Commits

Reviewing files that changed from the base of the PR and between aed87b7 and 949c9f1.

📒 Files selected for processing: 2

src/main/native-chat/agent-session-journal/journal-queued-rejection-batch.spec.ts
src/main/persistence/loading-store/profile-state-maintenance.spec.ts

🚧 Files skipped from review as they are similar to previous changes: 2

src/main/native-chat/agent-session-journal/journal-queued-rejection-batch.spec.ts
src/main/persistence/loading-store/profile-state-maintenance.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The pull request reorganizes journal and persistence tests into registered suites. It adds coverage for database schemas, journal recovery, queued-message behavior, profile-state durability, and PTY persistence. Renderer tests add guards that fail if they access the app store. Several renderer modules import the shared remote-runtime PTY-ID helper. CLI, ACP, and Codex process tests also receive targeted updates.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 949c9

This change only reorganizes tests and tightens test cleanup, with no production behavior change. Exact-head hosted CI verification is still needed before merge, as the author noted.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 17.80% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 191 functions across 50 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly summarizes the primary change: reducing fixture startup and shutdown waits for CI tests.
Description check		The description is detailed and covers the required change, rationale, testing, visual proof, review notes, scope considerations, and checklist. The maintainer-specific linked-issue exception is addre…

Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: dae0b0cb-13ea-4690-aada-e283a5d7bd8a

📥 Commits

Reviewing files that changed from the base of the PR and between 507d0a9 and aed87b7.

📒 Files selected for processing: 140

config/scripts/oxc-cli-invocation.test.mjs
src/main/acp/acp-structured-broken-stream.test.ts
src/main/codex/codex-app-server-teardown.integration.test.ts
src/main/native-chat/agent-session-journal/command-receipt-schema.spec.ts
src/main/native-chat/agent-session-journal/command-receipt-schema.test.ts
src/main/native-chat/agent-session-journal/command-receipt-table.spec.ts
src/main/native-chat/agent-session-journal/command-receipt-table.test.ts
src/main/native-chat/agent-session-journal/command-receipt-transaction.spec.ts
src/main/native-chat/agent-session-journal/command-receipt-transaction.test.ts
src/main/native-chat/agent-session-journal/journal-atomic-terminal-settlement.spec.ts
src/main/native-chat/agent-session-journal/journal-atomic-terminal-settlement.test.ts
src/main/native-chat/agent-session-journal/journal-crash-boundary.spec.ts
src/main/native-chat/agent-session-journal/journal-crash-boundary.test.ts
src/main/native-chat/agent-session-journal/journal-database-contracts.test.ts
src/main/native-chat/agent-session-journal/journal-database.spec.ts
src/main/native-chat/agent-session-journal/journal-database.test.ts
src/main/native-chat/agent-session-journal/journal-dispatch-reason-bound.spec.ts
src/main/native-chat/agent-session-journal/journal-dispatch-reason-bound.test.ts
src/main/native-chat/agent-session-journal/journal-epoch-replacement.spec.ts
src/main/native-chat/agent-session-journal/journal-epoch-replacement.test.ts
src/main/native-chat/agent-session-journal/journal-host-database.spec.ts
src/main/native-chat/agent-session-journal/journal-host-database.test.ts
src/main/native-chat/agent-session-journal/journal-item-provenance.spec.ts
src/main/native-chat/agent-session-journal/journal-item-provenance.test.ts
src/main/native-chat/agent-session-journal/journal-lifecycle-batch-appender.spec.ts
src/main/native-chat/agent-session-journal/journal-lifecycle-batch-appender.test.ts
src/main/native-chat/agent-session-journal/journal-pi-context-import.spec.ts
src/main/native-chat/agent-session-journal/journal-pi-context-import.test.ts
src/main/native-chat/agent-session-journal/journal-producer-inheritance.spec.ts
src/main/native-chat/agent-session-journal/journal-producer-inheritance.test.ts
src/main/native-chat/agent-session-journal/journal-queued-message-contracts.test.ts
src/main/native-chat/agent-session-journal/journal-queued-rejection-batch.spec.ts
src/main/native-chat/agent-session-journal/journal-queued-rejection-batch.test.ts
src/main/native-chat/agent-session-journal/journal-recovery-contracts.test.ts
src/main/native-chat/agent-session-journal/journal-restart-reconciliation.spec.ts
src/main/native-chat/agent-session-journal/journal-restart-reconciliation.test.ts
src/main/native-chat/agent-session-journal/journal-row-context-usage.spec.ts
src/main/native-chat/agent-session-journal/journal-row-context-usage.test.ts
src/main/native-chat/agent-session-journal/journal-row-schema-version.spec.ts
src/main/native-chat/agent-session-journal/journal-row-schema-version.test.ts
src/main/native-chat/agent-session-journal/journal-row-writer.spec.ts
src/main/native-chat/agent-session-journal/journal-row-writer.test.ts
src/main/native-chat/agent-session-journal/journal-settlement-contracts.test.ts
src/main/native-chat/agent-session-journal/journal-stop-and-resume-rows.spec.ts
src/main/native-chat/agent-session-journal/journal-stop-and-resume-rows.test.ts
src/main/native-chat/agent-session-journal/journal-store-schema.spec.ts
src/main/native-chat/agent-session-journal/journal-store-schema.test.ts
src/main/native-chat/agent-session-journal/journal-store.spec.ts
src/main/native-chat/agent-session-journal/journal-store.test.ts
src/main/native-chat/agent-session-journal/journal-subagent-item.spec.ts
src/main/native-chat/agent-session-journal/journal-subagent-item.test.ts
src/main/native-chat/agent-session-journal/journal-subagent-liveness.spec.ts
src/main/native-chat/agent-session-journal/journal-subagent-liveness.test.ts
src/main/native-chat/agent-session-journal/journal-submission-positions.spec.ts
src/main/native-chat/agent-session-journal/journal-submission-positions.test.ts
src/main/native-chat/agent-session-journal/journal-submission-queued-link.spec.ts
src/main/native-chat/agent-session-journal/journal-submission-queued-link.test.ts
src/main/native-chat/agent-session-journal/journal-terminal-settlement-validation.spec.ts
src/main/native-chat/agent-session-journal/journal-terminal-settlement-validation.test.ts
src/main/native-chat/agent-session-journal/journal-unknown-content.spec.ts
src/main/native-chat/agent-session-journal/journal-unknown-content.test.ts
src/main/native-chat/agent-session-journal/journal-unknown-row-kind.spec.ts
src/main/native-chat/agent-session-journal/journal-unknown-row-kind.test.ts
src/main/native-chat/agent-session-journal/journal-unsent-send-hold.spec.ts
src/main/native-chat/agent-session-journal/journal-unsent-send-hold.test.ts
src/main/native-chat/agent-session-journal/journal-write-queue.spec.ts
src/main/native-chat/agent-session-journal/journal-write-queue.test.ts
src/main/native-chat/agent-session-journal/queued-message-bookkeeping-failure.spec.ts
src/main/native-chat/agent-session-journal/queued-message-bookkeeping-failure.test.ts
src/main/native-chat/agent-session-journal/queued-message-delivered-echo.spec.ts
src/main/native-chat/agent-session-journal/queued-message-delivered-echo.test.ts
src/main/native-chat/agent-session-journal/queued-message-pause.spec.ts
src/main/native-chat/agent-session-journal/queued-message-pause.test.ts
src/main/native-chat/agent-session-journal/queued-message-store.spec.ts
src/main/native-chat/agent-session-journal/queued-message-store.test.ts
src/main/native-chat/agent-session-journal/queued-message-text-update.spec.ts
src/main/native-chat/agent-session-journal/queued-message-text-update.test.ts
src/main/persistence/loading-store/durable-settings-write.spec.ts
src/main/persistence/loading-store/durable-settings-write.test.ts
src/main/persistence/loading-store/profile-state-caller-cancellation.spec.ts
src/main/persistence/loading-store/profile-state-caller-cancellation.test.ts
src/main/persistence/loading-store/profile-state-durable-writes.test.ts
src/main/persistence/loading-store/profile-state-maintenance-contracts.test.ts
src/main/persistence/loading-store/profile-state-maintenance-final-failure.spec.ts
src/main/persistence/loading-store/profile-state-maintenance-final-failure.test.ts
src/main/persistence/loading-store/profile-state-maintenance-recovery.spec.ts
src/main/persistence/loading-store/profile-state-maintenance-recovery.test.ts
src/main/persistence/loading-store/profile-state-maintenance.spec.ts
src/main/persistence/loading-store/profile-state-maintenance.test.ts
src/main/persistence/loading-store/profile-state-pty-retirement-finalization.spec.ts
src/main/persistence/loading-store/profile-state-pty-retirement-finalization.test.ts
src/main/persistence/loading-store/profile-state-worker-coordination.spec.ts
src/main/persistence/loading-store/profile-state-worker-coordination.test.ts
src/main/persistence/loading-store/profile-state-worker-secret-retention.spec.ts
src/main/persistence/loading-store/profile-state-worker-secret-retention.test.ts
src/main/persistence/loading-store/profile-state-write-batching.spec.ts
src/main/persistence/loading-store/profile-state-write-batching.test.ts
src/main/persistence/loading-store/pty-binding-async-durability.spec.ts
src/main/persistence/loading-store/pty-binding-async-durability.test.ts
src/main/persistence/loading-store/pty-binding-created-surface-rollback.spec.ts
src/main/persistence/loading-store/pty-binding-created-surface-rollback.test.ts
src/main/persistence/loading-store/pty-binding-restart-retirement.spec.ts
src/main/persistence/loading-store/pty-binding-restart-retirement.test.ts
src/main/persistence/loading-store/pty-retirement-async-durability.spec.ts
src/main/persistence/loading-store/pty-retirement-async-durability.test.ts
src/main/persistence/loading-store/workspace-session-write-listeners.spec.ts
src/main/persistence/loading-store/workspace-session-write-listeners.test.ts
src/renderer/src/components/contextual-tours/ContextualTourControl.test.ts
src/renderer/src/components/contextual-tours/contextual-tour-overlay-measurement.test.ts
src/renderer/src/components/editor/editor-dropped-file-open.test.ts
src/renderer/src/components/editor/useMarkdownDocuments.test.ts
src/renderer/src/components/pet/PetOverlay.test.ts
src/renderer/src/components/pet/pet-overlay-position.test.ts
src/renderer/src/components/right-sidebar/use-checks-panel-terminal-worktree.ts
src/renderer/src/components/right-sidebar/use-source-control-ai.test.ts
src/renderer/src/components/right-sidebar/useFileExplorerKeys.test.ts
src/renderer/src/components/settings/KagiSessionLinkForm.test.ts
src/renderer/src/components/settings/PluginKeybindingConsentPreview.test.ts
src/renderer/src/components/settings/QuickCommandsPane.test.ts
src/renderer/src/components/settings/settings-setup-guide-progress.test.ts
src/renderer/src/components/sidebar/WorktreeParentPickerPopover.test.ts
src/renderer/src/components/sidebar/folder-workspace-linked-startup-plan.test.ts
src/renderer/src/components/sidebar/hovered-workspace-delete.test.ts
src/renderer/src/components/sidebar/use-worktree-activity-statuses.test.ts
src/renderer/src/components/tab-bar/tab-bar-item-model.git-status.test.ts
src/renderer/src/components/task-page-gitlab-task-filters.test.ts
src/renderer/src/components/task-page-repo-source-context.test.ts
src/renderer/src/components/task-page-task-source-host-availability.test.ts
src/renderer/src/components/terminal-cold-activation.ts
src/renderer/src/components/terminal-pane/parked-terminal-byte-watcher.ts
src/renderer/src/components/terminal-pane/remote-execution-host-pty.ts
src/renderer/src/components/terminal-pane/resolve-split-cwd.ts
src/renderer/src/components/terminal-pane/terminal-hidden-view-parking.ts
src/renderer/src/components/terminal-pane/terminal-hidden-worktree-retention.ts
src/renderer/src/components/terminal-pane/terminal-keyboard-search-dispatch.test.ts
src/renderer/src/components/terminal-pane/terminal-live-layout-reconciliation.ts
src/renderer/src/components/terminal-pane/terminal-parked-pty-watcher.ts
src/renderer/src/components/terminal-pane/use-manual-terminal-worktree-parking.test.ts
src/renderer/src/components/terminal-pane/use-terminal-pane-layout-persistence.ts
src/renderer/src/lib/automation-session-observer.ts

💤 Files with no reviewable changes: 38

src/main/native-chat/agent-session-journal/journal-pi-context-import.test.ts
src/main/native-chat/agent-session-journal/journal-producer-inheritance.test.ts
src/main/native-chat/agent-session-journal/journal-atomic-terminal-settlement.test.ts
src/main/native-chat/agent-session-journal/journal-unsent-send-hold.test.ts
src/main/native-chat/agent-session-journal/journal-store.test.ts
src/main/native-chat/agent-session-journal/journal-row-context-usage.test.ts
src/main/native-chat/agent-session-journal/journal-item-provenance.test.ts
src/main/native-chat/agent-session-journal/queued-message-pause.test.ts
src/main/native-chat/agent-session-journal/journal-subagent-liveness.test.ts
src/main/native-chat/agent-session-journal/journal-write-queue.test.ts
src/main/native-chat/agent-session-journal/queued-message-delivered-echo.test.ts
src/main/native-chat/agent-session-journal/command-receipt-schema.test.ts
src/main/native-chat/agent-session-journal/journal-submission-queued-link.test.ts
src/main/native-chat/agent-session-journal/journal-database.test.ts
src/main/native-chat/agent-session-journal/queued-message-bookkeeping-failure.test.ts
src/main/native-chat/agent-session-journal/journal-row-writer.test.ts
src/main/native-chat/agent-session-journal/journal-queued-rejection-batch.test.ts
src/main/native-chat/agent-session-journal/queued-message-store.test.ts
src/main/native-chat/agent-session-journal/queued-message-text-update.test.ts
src/main/native-chat/agent-session-journal/journal-unknown-row-kind.test.ts
src/main/native-chat/agent-session-journal/journal-subagent-item.test.ts
src/main/persistence/loading-store/profile-state-maintenance-final-failure.test.ts
src/main/native-chat/agent-session-journal/command-receipt-table.test.ts
src/main/persistence/loading-store/profile-state-caller-cancellation.test.ts
src/main/native-chat/agent-session-journal/journal-host-database.test.ts
src/main/native-chat/agent-session-journal/journal-row-schema-version.test.ts
src/main/native-chat/agent-session-journal/journal-epoch-replacement.test.ts
src/main/persistence/loading-store/durable-settings-write.test.ts
src/main/native-chat/agent-session-journal/journal-unknown-content.test.ts
src/main/native-chat/agent-session-journal/journal-store-schema.test.ts
src/main/native-chat/agent-session-journal/journal-restart-reconciliation.test.ts
src/main/native-chat/agent-session-journal/journal-stop-and-resume-rows.test.ts
src/main/native-chat/agent-session-journal/journal-lifecycle-batch-appender.test.ts
src/main/native-chat/agent-session-journal/journal-dispatch-reason-bound.test.ts
src/main/native-chat/agent-session-journal/journal-crash-boundary.test.ts
src/main/native-chat/agent-session-journal/journal-submission-positions.test.ts
src/main/native-chat/agent-session-journal/journal-terminal-settlement-validation.test.ts
src/main/native-chat/agent-session-journal/command-receipt-transaction.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

main moved journal-atomic-terminal-settlement.test.ts into a registered .spec.ts (#29163); this branch's edit (the observed-exit test settler) is carried there. Registrations take main's createAcpAdapter shape with this branch's producer argument.

main moved four journal suites into registered .spec.ts files (#29163); this branch's edits to them are carried into those files unchanged. main's thread-goal reader put journal-store.ts one line over its limit; holdReopenFromOpen becomes a one-line arrow.

ci: reduce fixture startup and shutdown waits

aed87b7

nwparker force-pushed the nwparker/ci-fixture-startup branch from cde1e68 to aed87b7 Compare October 15, 2026 14:29

coderabbitai Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread src/main/native-chat/agent-session-journal/journal-queued-rejection-batch.spec.ts Resolved

Comment thread src/main/persistence/loading-store/profile-state-maintenance.spec.ts Resolved

test: drain journals and restore maintenance timers

949c9f1

nwparker merged commit fca6a94 into main Oct 15, 2026
49 checks passed

This was referenced Oct 16, 2026

Native chat: one settlement transaction for everything an ended run left (4/5, rebuild of #26867) #28111

Merged

Native chat: recover interrupted messages before opening and retry cleanup in the background #28122

Closed

Navigation Menu

Repository navigation

ci: reduce fixture startup and shutdown waits - #29163

ci: reduce fixture startup and shutdown waits#29163
nwparker merged 2 commits into
mainfrom
nwparker/ci-fixture-startup

nwparker commented Oct 15, 2026 •

edited by github-actions Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

nwparker commented Oct 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ELI5

What Changed

Why

Linked Issue

Visual Proof

Testing

AI Disclosure

Review

Agent skill upstream boundary

Notes

Checklist

Uh oh!

coderabbitai Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nwparker commented Oct 15, 2026 •

edited by github-actions Bot

Loading

coderabbitai Bot commented Oct 15, 2026 •

edited

Loading