Repository navigation
Remove obsolete Hermes cron docs and translations - #28877
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
288 commits landed on main between 9c113ed and 67fe1e1, and all six catalogs and en-runtime-required.json conflicted. They are taken from main and the prune is recomputed in one pass: 1,475 keys. Four Hermes keys left the set because stablyai#28877 deleted them from main, and two Jira keys joined it after stablyai#28590 and stablyai#28612 stopped reading them. en.json goes from 16,098 entries to 14,623; en-runtime-required.json keeps 558 of them. stablyai#28669 deleted ko-ui-semantic-mistranslations.test.ts, technical-literal-catalog-values.test.ts and zh-technical-literal-mistranslations.test.ts from main. This branch only removed the entries of pruned keys from them, so the deletion is taken.
Just to plan my next steps, why is it being deprecated? |
Problem
The app still had leftover text about Hermes cron jobs: a docs sentence, UI labels, and translations in several languages. Hermes is no longer supported, so this text is stale and could confuse people.
Solution
This removes the stale Hermes text from the docs, the English and translated UI strings, and the translation override scripts. The docs also drop one sentence about SSH-hosted automations still showing up when a host is disconnected.
ELI5
We deleted old notes about a tool we no longer support, so the app and its docs stop mentioning it.
What Changed
docs/site/content/docs/cli/automations.mdx, removed the sentence saying SSH-hosted automations can be deleted while the host is disconnected. Reviewers should confirm this claim is no longer true before this lands.Why
Hermes is being deprecated, so keeping its strings and docs adds noise and misleading guidance. Removing them is simpler than maintaining translations for a feature that no longer exists.
Linked Issue
No linked issue. This PR does not fix an issue.
Visual Proof
TODO: The UI labels for Hermes automations are removed, so before and after screenshots of the automations list and the source-connect prompt are needed.
Testing
TODO: No test evidence in the diff. Run
pnpm tc, the locale checks, andpnpm testfor i18n.AI Disclosure
TODO
Review
Agent skill upstream boundary
Notes
Ensure no issues in: Security, Cross-platform support (Linux, Windows, Mac), Remote SSH, Mobile, general backwards compatibility, performance.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)