Skip to content

Remove obsolete Hermes cron docs and translations - #28877

Merged
AmethystLiang merged 1 commit into
mainfrom
hermes-deprecation-docs
Oct 14, 2026
Merged

AmethystLiang merged 1 commit into
mainfrom
hermes-deprecation-docs

Conversation

@AmethystLiang

@AmethystLiang AmethystLiang commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 10 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3 $\color{#cf222e}{\Huge{\mathbf{−}}}$​48 $\color{#cf222e}{\Huge{\mathbf{−}}}$​45

Problem

The app still had leftover text about Hermes cron jobs: a docs sentence, UI labels, and translations in several languages. Hermes is no longer supported, so this text is stale and could confuse people.

Solution

This removes the stale Hermes text from the docs, the English and translated UI strings, and the translation override scripts. The docs also drop one sentence about SSH-hosted automations still showing up when a host is disconnected.

ELI5

We deleted old notes about a tool we no longer support, so the app and its docs stop mentioning it.

What Changed

  • Removed the Hermes-related strings from the English, Spanish, French, Japanese, Korean, and Chinese locale files, and from the English runtime-required list.
  • Removed the Hermes-specific override entries from the Japanese and Korean translation scripts.
  • Removed the "HermesCronOutputView" translation block.
  • In docs/site/content/docs/cli/automations.mdx, removed the sentence saying SSH-hosted automations can be deleted while the host is disconnected. Reviewers should confirm this claim is no longer true before this lands.

Why

Hermes is being deprecated, so keeping its strings and docs adds noise and misleading guidance. Removing them is simpler than maintaining translations for a feature that no longer exists.

Linked Issue

No linked issue. This PR does not fix an issue.

Visual Proof

TODO: The UI labels for Hermes automations are removed, so before and after screenshots of the automations list and the source-connect prompt are needed.

Testing

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

TODO: No test evidence in the diff. Run pnpm tc, the locale checks, and pnpm test for i18n.

AI Disclosure

TODO

Review

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Ensure no issues in: Security, Cross-platform support (Linux, Windows, Mac), Remote SSH, Mobile, general backwards compatibility, performance.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 042f9164-8d47-424d-8aaf-f5a47aff7020
📥 Commits

Reviewing files that changed from the base of the PR and between 7244bf3 and d010aac.

📒 Files selected for processing: 10
  • config/scripts/locale-ja-value-overrides.mjs
  • config/scripts/locale-ko-value-overrides.mjs
  • docs/site/content/docs/cli/automations.mdx
  • src/renderer/src/i18n/en-runtime-required.json
  • src/renderer/src/i18n/locales/en.json
  • src/renderer/src/i18n/locales/es.json
  • src/renderer/src/i18n/locales/fr.json
  • src/renderer/src/i18n/locales/ja.json
  • src/renderer/src/i18n/locales/ko.json
  • src/renderer/src/i18n/locales/zh.json
💤 Files with no reviewable changes: 7
  • config/scripts/locale-ja-value-overrides.mjs
  • src/renderer/src/i18n/locales/es.json
  • src/renderer/src/i18n/locales/ko.json
  • src/renderer/src/i18n/locales/ja.json
  • src/renderer/src/i18n/locales/zh.json
  • src/renderer/src/i18n/locales/fr.json
  • src/renderer/src/i18n/locales/en.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The change removes Hermes automation labels, remote-profile guidance, and cron output labels from English, Spanish, French, Japanese, Korean, and Chinese translations. It also removes related Japanese and Korean value overrides. The CLI automation documentation no longer states that automations on disconnected SSH hosts remain visible and deletable without an active SSH session. Search guidance remains.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to d010a

No actionable issue is established by the Hermes reference cleanup. Normal localization and test checks remain appropriate before merging.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the problem and changes, but it is incomplete. It provides no linked issue, leaves visual proof and testing as TODOs, and does not confirm the SSH behavior change or required … Add a valid linked issue or explain the maintainer exception. Replace the visual-proof TODO with N/A and a reason if there is no interaction change, or attach before-and-after evidence. Document completed testing and results. Confirm whethe…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly summarizes the primary changes: removing obsolete Hermes cron documentation and translations.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem and changes, but it is incomplete. It provides no linked issue, leaves visual proof and testing as TODOs, and does not confirm the SSH behavior change or required validation.

Resolution

Add a valid linked issue or explain the maintainer exception. Replace the visual-proof TODO with N/A and a reason if there is no interaction change, or attach before-and-after evidence. Document completed testing and results. Confirm whether disconnected SSH-hosted automations remain deletable, and complete the remaining checklist items or explain why they are not applicable.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AmethystLiang
AmethystLiang merged commit 232f604 into main Oct 14, 2026
33 checks passed
smwbev added a commit to smwbev/orca that referenced this pull request Oct 15, 2026
288 commits landed on main between 9c113ed and 67fe1e1, and all six catalogs and en-runtime-required.json conflicted. They are taken from main and the prune is recomputed in one pass: 1,475 keys. Four Hermes keys left the set because stablyai#28877 deleted them from main, and two Jira keys joined it after stablyai#28590 and stablyai#28612 stopped reading them. en.json goes from 16,098 entries to 14,623; en-runtime-required.json keeps 558 of them.

stablyai#28669 deleted ko-ui-semantic-mistranslations.test.ts, technical-literal-catalog-values.test.ts and zh-technical-literal-mistranslations.test.ts from main. This branch only removed the entries of pruned keys from them, so the deletion is taken.
@alanjds

alanjds commented Oct 18, 2026

Copy link
Copy Markdown

Hermes is no longer supported...

Just to plan my next steps, why is it being deprecated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants