Skip to content

Repair Jira integration tests and storage inventory - #28743

Merged
nwparker merged 1 commit into
mainfrom
nwparker/jira-integration-ci-repair
Oct 14, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/jira-integration-ci-repair

Conversation

@nwparker

@nwparker nwparker commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 4 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​17 $\color{#cf222e}{\Huge{\mathbf{−}}}$​7 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​10
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​25 $\color{#cf222e}{\Huge{\mathbf{−}}}$​4 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​21

ELI5

Keep the test suite working with the Jira features that have just landed. There is no visible app change.

What Changed

The host-picker test now expects the host-qualified selection the parent already accepts. The startup fixture provides Electron's protocol handler and verifies that ready installs the Jira image scheme. Jira edit tests use exported wrappers with module-local setters that are cleared on unmount, preserving the issue/source switch tests without the banned mutable function export.

The WSL storage inventory classifies Jira list columns, linked-view choice and prompt templates as device preferences, matching their keys and the existing Linear policy. Skill-guide tests check the actual generated discovery projection rather than assuming it is shorter than every full guide or uses one fixed phrase. The cache test follows the headless workflow's deliberate removal of its push trigger; cache-warmer checks remain intact.

Why

Final CI found six stale integration assumptions after the Jira batch. Updating the fixtures and inventory preserves the landed behavior and the underlying checks. Changing production code, padding the Jira guide, or restoring an intentionally removed workflow trigger would change the product to satisfy incorrect test assumptions.

Linked Issue

Follow-up to #28622, #28631 and #28592. The existing headless trigger policy was introduced in #28664.

Visual Proof

N/A — tests, test fixtures and storage inventory declarations only; no visual or interaction change.

Testing

  • Automated tests updated.
  • 196 focused tests across nine files pass on macOS, covering every failed shard assertion, fixture consumers and the headless workflow policy.
  • Node and web typechecks pass; all seven changed-code quality stages, formatting and diff checks pass.
  • Reproduced five failing assertions in startup/export/storage tests and the skill projection failure before the repairs. The host-picker owner also reproduced the stale selection failure before correcting it.
  • Final full CI will run on this PR. The prior Ubuntu 22.04 persistence job crashed in the native watcher build before persistence tests ran; this change does not claim a Linux release, live Jira or real SSH pass.

Review

Independent source review found no issues; all six reviewed file hashes and the complete diff match committed head aa703eb50147ba95646cb82f10b6d86b4f890fc4. Risk: low. No authentication, network, protocol implementation, workflow, renderer behavior, remote messages or migration rewrite logic changes.

Agent skill upstream boundary

  • Not applicable; no upstream skill-installer source or artifacts copied.

Notes

The three storage keys contain device-level preferences, without workspace paths or identifiers. Tests preserve host disambiguation and issue/source switching. Platform, SSH and provider behavior remains in the existing implementations.

Checklist

  • Small and focused.
  • Explained the before/after, mechanism and choice of approach.
  • Visual proof marked N/A with a reason.
  • Self-reviewed for correctness and cleanup.
  • Cross-platform and SSH impact considered.
  • Focused tests, types, formatting and quality checks pass; full CI covers the broader build.

@nwparker
nwparker merged commit dd4d0fa into main Oct 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant