[brennanb2025]

Summary

• Import nested repositories as recursive project groups instead of one flat group.
• Support local, runtime RPC, and SSH remote nested scans/imports with validation and sanitized error handling.
• Harden project group persistence/state cleanup, runtime switching, grouped project ordering, and multi-repo worktree hydration.

Design

• Design doc: tmp/folder-setup-design.md.
• Design review completed clean after tightening the plan around SSH support, runtime parity, recursive deletion, and import-time re-scan safety.
• Self-check completed before implementation reconciliation.

Review

• Implementation/completeness pass found and fixed recursive group delete behavior.
• Code-review loop ran until clean.
• Key fixes from review:
  • Fetch worktrees for every imported repo.
  • Disable stale global repo drag ordering when project groups are present.
  • Reject local/runtime relative nested import paths.
  • Pass connectionId through SSH remote add-project nested imports.
  • Sanitize unexpected per-repo import errors.
  • Clear project groups on runtime switch.
  • Sanitize invalid persisted project group updates.

Tests

• pnpm run typecheck
• pnpm run lint
• git diff --check
• pnpm vitest run --config config/vitest.config.ts src/main/ipc/runtime.test.ts src/main/project-groups/nested-repo-discovery.test.ts src/main/project-groups/nested-repo-import.test.ts src/shared/project-groups.test.ts src/main/ipc/repos-remote.test.ts src/main/runtime/rpc/methods/repo.test.ts src/renderer/src/store/slices/repos-project-groups.test.ts src/renderer/src/components/sidebar/worktree-list-groups.test.ts src/renderer/src/components/onboarding/RepoStep.test.tsx
  • 9 files passed, 118 tests.
• pnpm run test:e2e -- tests/e2e/folder-setup.spec.ts
  • 1 passed.

Manual Validation

• Launched the exact PR worktree in Electron dev with CDP and verified identity:
  • Orca: brennanb2025/folder-setup
  • /Users/thebr/orca/workspaces/orca/folder-setup
• Local realistic microservices parent folder under /Users/thebr/source/repos/Stably/orca-setup-script-cases/microservices-platform:
  • Found apps/web, packages/sdk, services/api, services/billing.
  • Skipped a real git repo under node_modules/ignored-git-repo.
  • Imported 4 repos into recursive groups microservices-platform, apps, packages, services with expected project-group ordering.
• Direct git repo selection:
  • Scanning setup-demo-has-orca-setup returned selectedPathKind: git_repo and no nested repo import candidates.
• Import separately flow via IPC:
  • Imported temp admin and worker repos without project-group membership and with no group delta.
• Runtime RPC live path:
  • window.api.runtime.call({ method: 'projectGroup.scanNested' }) found temp gateway and jobs repos.
  • projectGroup.importNested imported both into runtime-platform with orders [0, 1].
• Added focused runtime IPC regression coverage for projectGroup.list through runtime:call.

SSH Validation

• pnpm build:relay
• Used a throwaway Linux Docker SSH target, not ssh localhost.
• Connected Orca to the target via key-based SSH and verified ssh:connect reached connected.
• Remote target shape:
  • Ubuntu 24.04 container
  • installed openssh-server, git, nodejs, npm
  • key-based SSH as root on a host-mapped localhost port
• Remote nested repo fixture:
  • /work/platform/apps/web
  • /work/platform/services/api
  • /work/platform/services/billing
  • /work/platform/node_modules/ignored
  • all initialized as real git repos with committed README files.
• SSH nested scan/import via window.api.projectGroups.scanNested/importNested with connectionId:
  • Found web, api, billing.
  • Skipped the real git repo under /work/platform/node_modules/ignored.
  • Imported 3 SSH repos with the same connectionId into recursive groups remote-platform, apps, services and expected orders [0], [0, 1].
• Remote backing proof:
  • find /work/platform -maxdepth 4 -name .git showed all remote fixture repos, including the ignored repo.
  • git status --short --branch returned ## master for apps/web, services/api, and services/billing.
• Relay/app log evidence:
  • remote platform detected as Linux
  • relay uploaded/installed
  • relay launched successfully
• Cleanup:
  • throwaway container removed
  • temp keys, temp repos, temp user-data, and dev app processes removed

Gaps

• No known blocking validation gaps.