Repository navigation
Clear agent selections in workspace creation and settings - #28543
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 27 files. (6 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly and concisely describes the main change: allowing users to clear agent selections during workspace creation and in settings. Description check The description is complete and aligned with the template. It explains the user-facing behavior, implementation changes, motivation, linked issues, visual proof, testing, compatibility considerations,…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 27 files. (6 skipped: 6 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
279a2aa1-da66-42e7-a207-e7f5cd8cd85a
📒 Files selected for processing: 37
src/main/runtime/runtime-client-agent-launch-settings-durability.test.tssrc/main/runtime/runtime-client-agent-launch-settings.test.tssrc/main/runtime/runtime-client-settings.tssrc/main/runtime/runtime-worktree-terminal-provisioning.test.tssrc/main/runtime/runtime-worktree-terminal-provisioning.tssrc/renderer/src/components/NewWorkspaceComposerCard.tsxsrc/renderer/src/components/NewWorkspaceComposerModal.tsxsrc/renderer/src/components/agent/AgentCombobox.test.tsxsrc/renderer/src/components/agent/AgentCombobox.tsxsrc/renderer/src/components/automations/AutomationEditorDialog.tsxsrc/renderer/src/components/automations/AutomationEditorSettingsSidebar.test.tsxsrc/renderer/src/components/automations/AutomationEditorSettingsSidebar.tsxsrc/renderer/src/components/automations/AutomationExtraAgentArgsField.tsxsrc/renderer/src/components/automations/AutomationsPage.agent-clear.test.tsxsrc/renderer/src/components/automations/automation-draft-model.tssrc/renderer/src/components/automations/automation-orca-save.tssrc/renderer/src/components/automations/automation-save-action.tssrc/renderer/src/components/new-workspace/NewWorkspaceComposerAgentSection.test.tsxsrc/renderer/src/components/new-workspace/NewWorkspaceComposerAgentSection.tsxsrc/renderer/src/components/new-workspace/new-workspace-composer-card-props.tssrc/renderer/src/components/settings/AgentDefaultSetting.tsxsrc/renderer/src/components/settings/AgentLaunchSettingsCatalog.tsxsrc/renderer/src/hooks/ipc-events/worktree-event-runtime.tssrc/renderer/src/i18n/locales/en.jsonsrc/renderer/src/i18n/locales/es.jsonsrc/renderer/src/i18n/locales/fr.jsonsrc/renderer/src/i18n/locales/ja.jsonsrc/renderer/src/i18n/locales/ko.jsonsrc/renderer/src/i18n/locales/zh.jsonsrc/renderer/src/lib/agent-picker-search.test.tssrc/renderer/src/lib/agent-picker-search.tssrc/shared/agent-launch-settings.tssrc/shared/default-agent-settings.test.tssrc/shared/default-agent-settings.tssrc/shared/global-settings-types.tssrc/shared/new-workspace-setup-only.test.tssrc/shared/new-workspace-setup-only.ts
💤 Files with no reviewable changes: 6
- src/renderer/src/hooks/ipc-events/worktree-event-runtime.ts
- src/renderer/src/components/new-workspace/NewWorkspaceComposerAgentSection.test.tsx
- src/shared/new-workspace-setup-only.ts
- src/renderer/src/lib/agent-picker-search.test.ts
- src/shared/new-workspace-setup-only.test.ts
- src/renderer/src/lib/agent-picker-search.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.
nwparker
changed the title
nwparker
changed the title
nwparker
enabled auto-merge (squash)
October 14, 2026 05:41
nwparker
disabled auto-merge
October 14, 2026 05:45
nwparker
force-pushed
the
feat/workspace-agent-clear
branch
from
October 14, 2026 05:53
5753f78 to
5290fb2
Compare
1 task done
10 tasks done
Contributor
Author
|
Follow-up #28607 removes translated None keys added on main after this branch began and gives Mobile verify a unique check name. GitHub auto-merged this PR when the mobile check named verify passed before the full PR gate completed. The full gate subsequently reported stale catalog entries; typecheck itself passed. The follow-up includes a regression test reserving verify for the full PR workflow and will be merged only after all its checks finish. |
Jinwoo-H
added a commit
that referenced
this pull request
Oct 14, 2026
#28543 reads settings before creating default tabs (setup-only skips them), so a storeless runtime now fails provisioning with runtime_unavailable.
8 of 9 tasks
Jinwoo-H
added a commit
that referenced
this pull request
Oct 14, 2026
left red (#28603) * fix(i18n): drop the setup-only keys #28543 removed from en.json Main's localization catalog check fails on these three stale keys in es/fr/ja/ko/zh. * test(runtime): give the default-tab agent fixture a store #28543 reads settings before creating default tabs (setup-only skips them), so a storeless runtime now fails provisioning with runtime_unavailable. * fix(native-chat): restore the option write's clock both crossing fixes removed #28543 and #28599 each dropped one of the duplicate now keys, leaving none.
11 tasks done
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Click X beside the chosen agent to create a workspace without starting an agent. In Settings → Agents, click the selected option again to clear the saved default, leaving nothing selected.
What Changed
Why
Clearing a selection expresses no agent directly, without another None option beside Blank Terminal. X makes that choice for one workspace; toggling the selected settings option makes it the saved default. Auto remains an explicit choice.
Linked Issue
Follow-up to #25617; related to #25247.
Visual Proof
Captured from the hidden Electron renderer on macOS, using an isolated fixture profile. Before shows the merged #25617 design. All affected surfaces are shown below.
Settings → Agents
Settings: click the selected agent again to clear it
Create dialog → Configure agents
Git workspace creation
Agent dropdown
Cleared states and folder workspace creation
Git workspace with agent cleared
Folder workspace with selected agent
Folder workspace with agent cleared
Created Git workspace: setup completed, only the Setup tab
Cleared creation with configured default tabs
Two default tabs with commands are configured in the fixture. Clearing the agent and creating the workspace runs setup and leaves only Setup; neither template command launches.
Testing
ORCA_BACKGROUND_LAUNCH=1: both settings surfaces, clicking the selected agent to clear it, keyboard toggling Auto, persistence after reopening settings, Git/folder create, selected/cleared/dropdown states, keyboard clear and focus return, setup-only creation, explicit Blank Terminal plus setup, skipped setup shell fallback.pnpm tc, changed-code quality, localization checks, and Electron production build passed on the latest revision. The full desktop build also passed before the automation changes were removed. Full repository test/lint suites run in CI.Review
Reviewed clear versus Blank Terminal, saved-default isolation, no-agent versus Auto semantics, saved-default toggling, old-client requests, setup recovery, remote ownership, folder creation, and keyboard access. X is a sibling button, so there is no nested interactive element.
Agent skill upstream boundary
Notes
Final CI exposed a duplicate
nowkey already present in the updated base agent-session module. This PR removes the redundant, overwritten entry so the combined branch passes static analysis. No session behavior changes.This reuses the existing per-create setup flag and host provisioning path. An empty saved default uses the existing
blankhost value;nullstill means Auto. No new remote request field or opcode is introduced.Checklist