Repository navigation
chore(i18n): translate 259 new keys to es/fr/ja/ko/zh - #28486
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies the main change: adding translations for the five target locales. The key count does not match the description, but the title remains relevant and specific. Description check The description is complete and covers the change, rationale, testing, visual proof, scope, and checklist. It omits some template headings, but the missing sections are non-critical for this internal,… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 2
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
e66e1e8f-0768-4903-87a7-57883a027dda
📒 Files selected for processing: 6
config/update-translation.txtsrc/renderer/src/i18n/locales/es.jsonsrc/renderer/src/i18n/locales/fr.jsonsrc/renderer/src/i18n/locales/ja.jsonsrc/renderer/src/i18n/locales/ko.jsonsrc/renderer/src/i18n/locales/zh.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
e6b87ab to
f29a880
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
8e1d476c-280f-4f7c-a761-a24c8e2cd429
📒 Files selected for processing: 1
config/scripts/apply-translation-delta.mjs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Scan 2026-10-13: fill target-locale coverage for PRs merged since the 2026-10-07 scan. Adds the missing keys (es 295, fr 294, ja 295, ko 271, zh 283), fixes stale/mistranslated existing values, and leaves the 11 pinned provider-credit-balance keys plus 3 pinned Chat UI keys as English fallback by design. Also commits the apply-translation-delta helper referenced by the scan tracker.
b48e480 to
9c77818
Compare
Scan 2026-10-14: fill target-locale coverage for PRs merged since the 2026-10-13 scan (#28486). Adds the missing keys (es 98, fr/ja/ko/zh 125 each), updates the two changed WorktreeJumpPalette strings, and fixes pre-existing mistranslations: the ZCode missing-TUI notice (English in all five locales), fr settings search keywords (procuration/indigene), zh workspace-cleanup browse MT, 6 zh keys that still used Latin "Agent", and the zh AccountsPane credential-help cluster (leftover English and a mangled __Host-console_session token). Leaves the 11 pinned provider-credit-balance keys plus the 3 pinned Chat UI keys as English fallback by design. Records the scan in config/update-translation.txt.
Scan 2026-10-14: fill target-locale coverage for PRs merged since the 2026-10-13 scan (#28486). Adds the missing keys (es 98, fr/ja/ko/zh 125 each), updates the two changed WorktreeJumpPalette strings, and fixes pre-existing mistranslations: the ZCode missing-TUI notice (English in all five locales), fr settings search keywords (procuration/indigene), zh workspace-cleanup browse MT, 6 zh keys that still used Latin "Agent", and the zh AccountsPane credential-help cluster (leftover English and a mangled __Host-console_session token). Leaves the 11 pinned provider-credit-balance keys plus the 3 pinned Chat UI keys as English fallback by design. Records the scan in config/update-translation.txt.
ELI5
The app speaks English, Spanish, French, Japanese, Korean and Simplified Chinese. When developers add new English text, the other languages lag behind. This PR catches those five languages up with everything added since the last translation pass.
What Changed
Before: PRs merged since the last translation scan (2026-10-07,
de4ee59cba) added new English UI strings, and the es/fr/ja/ko/zh catalogs were missing them — so those screens fell back to English. A handful of already-translated strings were also stale (the English they were keyed to had changed) or mistranslated.After:
settings.terminal.windows.*).settings.chat.description("get their names" → "behave") in all five; esTerminalRemoteRuntimeReconnectBanner.retryingBodystill in English; es/fr/jaZcodePlanAccountsSection.usingCliHelpstill naming the removed~/.zcode/cli/config.jsonpath; and 9 zh strings using 代理 for the Agent concept, which the project standardizes as 智能体.provider-credit-balance-locales.test.tsand the 3 Chat UI settings keys pinned bynative-chat-locales.test.ts.Mechanism: the missing-key delta was computed by flattening
en.jsonatde4ee59cbavs currentmainand subtracting each target catalog. Values were produced per locale, then applied through the repo'srepairTranslatedValuepipeline (brand-mistranslation fixes, CJK spacing, phrase fixes) with placeholder parity enforced. No source or English copy changed.Why
The catalogs are sparse by design (missing keys fall back to English), so untranslated strings are not broken — but they are invisible regressions in coverage that only accumulate. This is the recurring "scan after a batch of merged PRs" pass. Doing it as a translation-only change keeps it independent of the feature PRs that introduced the copy, so it never blocks them and is cheap to review. The alternative — translating inline in each feature PR — would couple localization to every feature and violate the repo's delta-driven translation model.
Linked Issue
Internal maintenance (recurring translation scan); no issue. Progress is recorded in
config/update-translation.txt.Visual Proof
N/A — catalog-only change, no UI layout or behavior.
Testing
node config/scripts/verify-localization-catalog.mjs→ PASS: all five locales 15937/15951, the 14 omissions are the 11 pinned balance + 3 pinned Chat UI keys.node config/scripts/audit-localization-coverage.mjs --check→ PASS (13 allowlisted; no new unkeyed strings).node config/scripts/verify-localization-extraction.mjs→ PASS (en.json in sync with source).node config/scripts/generate-runtime-required-english-catalog.mjs→ PASS.vitest src/renderer/src/i18n→ 18 files / 215 tests pass (incl. the pinning tests).vitest config/scripts/locale→ 14 files / 79 tests pass.config/update-translation.txt).Platforms: catalog-only, platform-independent.
Notes
config/update-translation.txt+ the five locale JSONs).Checklist