[nwparker]

	Files	Added	Deleted	Net
Test	1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​52	$\color{#cf222e}{\Huge{\mathbf{−}}}$​35	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​17
Prod	3	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​43	$\color{#cf222e}{\Huge{\mathbf{−}}}$​56	$\color{#cf222e}{\Huge{\mathbf{−}}}$​13

ELI5

The chat upgrade dialog now offers a clear primary button to enable chat mode instead of a switch.

What Changed

The switch is removed in every state. When chat mode is on, the dialog shows only Got It. When it is off, it shows Okay and the primary Enable Now button. Okay dismisses without changing the setting; Enable Now saves the setting and then dismisses. A failed save keeps the dialog open for retry.

The actions follow the current Chat UI setting for both upgrade audiences. They reuse the existing dialog actions, button primitives, settings persistence, and dismissal paths.

Why

Enabling chat belongs beside the acknowledgement action. Using the current setting avoids offering an enable action after chat is already on, while removing the switch avoids a separate toggle-and-dismiss step.

Linked Issue

Requested directly by a maintainer; no linked issue.

Visual Proof

Chat mode off — before:

Chat mode off — after:

Chat mode on — before:

Chat mode on — after:

Testing

• Manually tested on macOS through Playwright CDP against this worktree's hidden Electron app with an isolated profile. Inspected dark and light rendering. Exercised Okay, Enable Now, and Got It; verified persisted settings, both upgrade audiences with chat on/off, and an injected save failure that remains open and does not mark the tip seen.
• Updated automated tests for action labels, primary/ghost variants, dismissal callbacks, busy controls, and absence of the switch.
• Passed: ORCA_BACKGROUND_LAUNCH=1 pnpm test src/renderer/src/components/feature-tips/NativeChatUpgradeTipDialog.test.tsx src/renderer/src/components/feature-tips/feature-tip-modal-state.test.ts (15 tests), pnpm tc:web, pnpm run check:code-quality:changed, and git diff --check.
• The Electron dev build completed. Full production build and full-repository checks are left to CI. Linux, Windows, and SSH were not run locally.

Review

Agent skill upstream boundary

• Not applicable; this change copies no upstream skill-installer source or assets.

Notes

This changes renderer dialog actions using the existing global Chat UI setting. It introduces no platform-specific paths, shortcuts, execution-host logic, or remote protocol changes. The dialog still supports folder workspaces and git worktrees.

Checklist

• This PR is small and focused
• I explained what changed and why
• Before/after screenshots attached
• Self-reviewed for correctness, security, and performance
• Cross-platform, SSH/remote, and path/shortcut impact considered
• Full lint, typecheck, test, and production build pass in CI; focused local checks passed as listed above

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 28811f74-8138-403b-95f8-582d12682d2c

📥 Commits

Reviewing files that changed from the base of the PR and between 5e83ca0 and 64bd5b9.

📒 Files selected for processing (4)

• src/renderer/src/components/feature-tips/FeatureTipsModal.tsx
• src/renderer/src/components/feature-tips/NativeChatUpgradeTipDialog.test.tsx
• src/renderer/src/components/feature-tips/NativeChatUpgradeTipDialog.tsx
• src/renderer/src/i18n/locales/en.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

📝 Walkthrough

Walkthrough

The native chat upgrade dialog now bases its offer on the current chat-mode setting and no longer includes a chat-mode switch. Its buttons and English strings reflect whether chat mode is on or off. The modal waits for the settings update before marking the tip seen. If the update fails, it shows an error and leaves the tip and modal open.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 64bd5

No actionable merge-blocking issue remains. A failed attempt to enable chat mode leaves the dialog open for retry.

Pre-merge checks · 4 · 1

Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary change: replacing the chat upgrade switch with an "Enable Now" button.
Description check		The description covers the user-visible changes, rationale, testing, visual proof, scope, and checklist. It states that no issue is linked, but it provides a maintainer-request rationale, and the rema…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}