Skip to content

fix(ci): point the main sync-spawn ratchet at the shared ratchet library - #28054

Merged
OrcaWin merged 1 commit into
mainfrom
OrcaWin/fix-main-sync-spawn-ratchet-imports
Oct 12, 2026
Merged

OrcaWin merged 1 commit into
mainfrom
OrcaWin/fix-main-sync-spawn-ratchet-imports

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator
Files Added Deleted Net
Test 0 0 0 0
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​11 $\color{#cf222e}{\Huge{\mathbf{−}}}$​23 $\color{#cf222e}{\Huge{\mathbf{−}}}$​12

ELI5

A CI lint script that blocks new synchronous program launches crashed on startup, so every PR that merges main fails two required checks. This points the script at the shared library its helper functions moved to, and catches up the list of allowed launches that went stale while the check couldn't run.

What Changed

Why

The import fix alone leaves CI red: once the script runs, it reports the two missing daemon entries and the stale one. Adding the daemon entries records code that was already on main when the ratchet landed, which the baseline header allows for daemon-process files. Moving those calls off runProcessSync belongs in its own change.

Linked Issue

Fixes the main breakage from #27756 + #27788 ("Check main-process sync launches" and "Enforce focused code-quality plugins" failing).

Visual Proof

N/A: CI tooling only.

Testing

  • node config/scripts/check-main-sync-spawn-ratchet.mjs: crashed before the change; now passes, 119 uses in 81 files.

  • --prune rewrites the baseline with no further change.

  • check-main-sync-spawn-ratchet.test.mjs and ratchet-baseline.test.mjs: 63/63 pass.

  • oxlint with config/oxlint-code-quality-native-plugins.json --deny-warnings is clean (it reported the 4 missing imports before), as are anti-slop and oxfmt.

  • I manually tested these changes locally

  • Automated tests added/updated (existing ratchet tests cover the library calls)

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered: CI script and baseline only

#27756's script imported baseline helpers from check-focus-read-ratchet.mjs
after #27788 had moved them into ratchet-baseline.mjs, so it crashed on start
and failed every PR that merges main. Use the library's helpers, and record the
two daemon-process launches from #27769 that the broken check never saw.
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 070ffc98-2f9e-4063-8e50-c032ca8e58f3

📥 Commits

Reviewing files that changed from the base of the PR and between a940929 and 66f536c.


📒 Files selected for processing (2)
  • config/main-sync-spawn-baseline.txt
  • config/scripts/check-main-sync-spawn-ratchet.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.



📝 Walkthrough

Walkthrough

The sync-spawn baseline adds one launch count for each of two PTY process-ceiling files and removes the count for the mobile notification dismissal store. The checker now uses shared helpers to parse and total baseline counts and to prune the baseline.


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 66f53

No actionable issue remains from the reviewed changes; the PR appears ready to merge subject to normal checks.

Pre-merge checks · Passed 4 · Failed 1

Failed Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the primary change: updating the main sync-spawn ratchet to use the shared ratchet library. It is concise and specific.
Description check Passed The description is complete and directly explains the problem, changes, rationale, testing, visual-proof exception, and scope. It omits some template sections and does not provide a direct linked-issu…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)


  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin
OrcaWin merged commit 0ec645f into main Oct 12, 2026
30 checks passed
brennanb2025 pushed a commit that referenced this pull request Oct 12, 2026
…ary (#28054)

#27756's script imported baseline helpers from check-focus-read-ratchet.mjs
after #27788 had moved them into ratchet-baseline.mjs, so it crashed on start
and failed every PR that merges main. Use the library's helpers, and record the
two daemon-process launches from #27769 that the broken check never saw.

Co-authored-by: Orca Worker <orca-worker@localhost>
brennanb2025 added a commit that referenced this pull request Oct 12, 2026
…27875)

* fix(browser): annotation card and outline follow the selected element

The grab overlay keeps re-measuring the picked element after the click
(scroll in any box, resize, element size changes), and the isolated
viewport bridge reports that live box so the pending card follows it,
including page zoom. The card's side pick uses its measured height.

* fix(browser): bind annotation card to selected element

* fix(browser): keep document annotation card on selection

* fix(ci): point the main sync-spawn ratchet at the shared ratchet library (#28054)

#27756's script imported baseline helpers from check-focus-read-ratchet.mjs
after #27788 had moved them into ratchet-baseline.mjs, so it crashed on start
and failed every PR that merges main. Use the library's helpers, and record the
two daemon-process launches from #27769 that the broken check never saw.

Co-authored-by: Orca Worker <orca-worker@localhost>

* fix(browser): follow selected element outer-box size

* refactor(chat): give the start-refusal resumable table its own module (#28085)

#27946 and #26684 together put agent-session-failure-words.ts at 304 lines,
over max-lines, which fails lint and the pre-commit hook on every merge of
main. The refusal-code table is standalone with one reader, so it moves out.

Co-authored-by: Orca Worker <orca-worker@localhost>

---------

Co-authored-by: OrcaWin <alpha-eng@stably.ai>
Co-authored-by: Orca Worker <orca-worker@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant