Repository navigation
fix(ci): point the main sync-spawn ratchet at the shared ratchet library - #28054
Conversation
#27756's script imported baseline helpers from check-focus-read-ratchet.mjs after #27788 had moved them into ratchet-baseline.mjs, so it crashed on start and failed every PR that merges main. Use the library's helpers, and record the two daemon-process launches from #27769 that the broken check never saw.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to No actionable issue remains from the reviewed changes; the PR appears ready to merge subject to normal checks. Pre-merge checks ·
|
…ary (#28054) #27756's script imported baseline helpers from check-focus-read-ratchet.mjs after #27788 had moved them into ratchet-baseline.mjs, so it crashed on start and failed every PR that merges main. Use the library's helpers, and record the two daemon-process launches from #27769 that the broken check never saw. Co-authored-by: Orca Worker <orca-worker@localhost>
…27875) * fix(browser): annotation card and outline follow the selected element The grab overlay keeps re-measuring the picked element after the click (scroll in any box, resize, element size changes), and the isolated viewport bridge reports that live box so the pending card follows it, including page zoom. The card's side pick uses its measured height. * fix(browser): bind annotation card to selected element * fix(browser): keep document annotation card on selection * fix(ci): point the main sync-spawn ratchet at the shared ratchet library (#28054) #27756's script imported baseline helpers from check-focus-read-ratchet.mjs after #27788 had moved them into ratchet-baseline.mjs, so it crashed on start and failed every PR that merges main. Use the library's helpers, and record the two daemon-process launches from #27769 that the broken check never saw. Co-authored-by: Orca Worker <orca-worker@localhost> * fix(browser): follow selected element outer-box size * refactor(chat): give the start-refusal resumable table its own module (#28085) #27946 and #26684 together put agent-session-failure-words.ts at 304 lines, over max-lines, which fails lint and the pre-commit hook on every merge of main. The refusal-code table is standalone with one reader, so it moves out. Co-authored-by: Orca Worker <orca-worker@localhost> --------- Co-authored-by: OrcaWin <alpha-eng@stably.ai> Co-authored-by: Orca Worker <orca-worker@localhost>
ELI5
A CI lint script that blocks new synchronous program launches crashed on startup, so every PR that merges main fails two required checks. This points the script at the shared library its helper functions moved to, and catches up the list of allowed launches that went stale while the check couldn't run.
What Changed
config/scripts/check-main-sync-spawn-ratchet.mjs(ci: stop new main-process code from freezing Orca with synchronous launches #27756) importeddiffCounts,formatBaseline,parseBaselineandparseBaselineNotesfromcheck-focus-read-ratchet.mjs. chore(ratchet): one ratchet baseline library #27788 had already moved those helpers intoratchet-baseline.mjs, three of them under new names, so the script threwSyntaxError: Export named 'diffCounts' not foundand oxlint reported four missing imports.diffCounts,parseCountBaseline,pruneCountBaselineandtotalCountfromratchet-baseline.mjs. Its hand-written--pruneandtotalduplicatedpruneCountBaselineandtotalCount, so they now call the library, the same way the focus-read and layout-writer ratchets do.config/main-sync-spawn-baseline.txt:src/main/daemon/pty-process-ceiling-runtime.tsandsrc/main/daemon/pty-process-ceiling.ts(1 each). Both run Linux-onlysystemctlin the terminal daemon process. They landed in feat(daemon): opt-in OS ceiling on terminal processes, reported per host #27769 before ci: stop new main-process code from freezing Orca with synchronous launches #27756's baseline was recorded, and the broken script never got to flag them.src/main/runtime/mobile-notification-dismissal-store.ts, whose launch is gone (--prune).Why
The import fix alone leaves CI red: once the script runs, it reports the two missing daemon entries and the stale one. Adding the daemon entries records code that was already on main when the ratchet landed, which the baseline header allows for daemon-process files. Moving those calls off
runProcessSyncbelongs in its own change.Linked Issue
Fixes the
mainbreakage from #27756 + #27788 ("Check main-process sync launches" and "Enforce focused code-quality plugins" failing).Visual Proof
N/A: CI tooling only.
Testing
node config/scripts/check-main-sync-spawn-ratchet.mjs: crashed before the change; now passes, 119 uses in 81 files.--prunerewrites the baseline with no further change.check-main-sync-spawn-ratchet.test.mjsandratchet-baseline.test.mjs: 63/63 pass.oxlint with
config/oxlint-code-quality-native-plugins.json --deny-warningsis clean (it reported the 4 missing imports before), as are anti-slop and oxfmt.I manually tested these changes locally
Automated tests added/updated (existing ratchet tests cover the library calls)
Checklist
N/Awith reason