Repository navigation
refactor(renderer): name target converters by meaning; drop re-export shims - #27992
Merged
Merged
Conversation
LINDECKER-Charles
added a commit
to LINDECKER-Charles/orca
that referenced
this pull request
Oct 15, 2026
Upstream renamed runtimeTargetForOwnerHostId to ipcOrRuntimeTargetForHostId and dropped the RuntimeClientTarget re-export (stablyai#27992), so createProjectGroup and the shared createOnTarget helper use the new name and import the type from shared. ProjectGroupingModel moved to shared/project-section-grouping (stablyai#28850). Locale conflicts were sibling additions; both sides are kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Two renderer helpers turn a host id into "where to send this request", and they differ only in how they treat an SSH host. One sends SSH rows to this app's IPC, which refuses them. The other returns no target for SSH. Their names didn't say that. This PR renames them for what they do, moves a third converter next to them, and removes the remaining re-export shims in the renderer's routing code.
What Changed
Users see no difference. Function bodies are unchanged.
runtimeTargetForOwnerHostIdis renamedipcOrRuntimeTargetForHostId: a server's runtime, or this app for local andssh:rows.runtimeTargetForExecutionHostIdis renamedruntimeRpcTargetForAuthorityKey: a runtime RPC target for an authority key, with no target for direct SSH.getRuntimeTargetHostIdmoves fromstore/runtime-target-host.ts(deleted) intoruntime/runtime-client-target.ts, beside the other converters.RuntimeClientTargetis imported fromshared/runtime-client-target.runtime-client-target.tsandruntime-rpc-client.tsno longer re-export it.hasRuntimeRpcErrorCode,RuntimeRpcCallErrorandunwrapRuntimeRpcResultare imported fromruntime-rpc-result.WorktreeRuntimeOwnerStateandgetRuntimeSessionMirrorEnvironmentIdsare imported from their own modules, not viaworktree-runtime-owner.resolveExplicitWorktreeOperationRouteResultis imported fromworktree-operation-catalog-route.runtime-rpc-clientno longer provide a fakeRuntimeRpcCallErrororhasRuntimeRpcErrorCode. The code under test now imports those fromruntime-rpc-result, so the real class and matcher run.Net: production −67 (+459/−526), tests −110.
Why
Phase 3.99 / AGENTS.md rule: no barrels and no re-export shims. With direct imports, each import line names the module a file really depends on, and each test mocks the module the code under test actually calls. One barrel per PR keeps every review mechanical.
Linked Issue
N/A, internal Phase 3.99 cleanup (PR 3.6).
Visual Proof
N/A, no UI or behaviour change.
Testing
rgfinds no old converter names and no import of a removed re-export through its old path insrc tests mobile config docs(@ts-nocheckfiles included).All 111 changed test files pass (1224 tests). The full
src/renderersuite passes too, apart from two load-related timeouts that pass when run alone.pnpm tc,pnpm lintandpnpm run check:code-quality:changed(0 findings) pass on the whole barrel stack.I manually tested these changes locally
Automated tests added/updated, or explained why not below
Review
P0/P1 review: my own review plus an independent reviewer.
Agent skill upstream boundary
Notes
Renderer-only import changes. SSH, wire, mobile and platforms are not affected.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)