Repository navigation
Fix RC PTY regression from agent hook build output collision - #2788
Merged
Merged
Conversation
Co-authored-by: Orca <help@stably.ai>
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
…i#2788) Co-authored-by: Orca <help@stably.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
out/main/agent-hooks/managed-agent-hook-controls.jsandbuild:clioverwriting that file afterwardbuild:clibeforebuild:electron-viteso the final packagedout/mainfile is the Electron/Rollup versionorca agent hooks ...available after Electron dev/build output cleansout/mainRoot Cause
PR #2778 added an Electron main entry for
managed-agent-hook-controlsso the CLI import path survived Electron output cleanup. In the release script order,build:electron-viteproduced anout/main/index.jsthat required that side-entry and expected Rollup-generated exports such asclaudeHookService. Thenbuild:clioverwrote the same path with the tsc-generated CLI module, which does not export those Rollup-hoisted values. At runtime PTY env construction calledclaudeHookService.buildPtyEnv()through an undefined export, producingTypeError: Cannot read properties of undefined (reading 'buildPtyEnv').\n\n## Verification\n-pnpm run build:cli\n-pnpm run build:electron-vite\n- verified finalout/main/agent-hooks/managed-agent-hook-controls.jsexportsclaudeHookService,getSpawnArgsForWindows,grantDirAcl, andisAgentStatusHooksEnabled\n- verifiedout/cli/index.js agent hooks status --jsonstill works after the reordered build sequence\n-pnpm run typecheck:node\n-pnpm run typecheck:cli\n-pnpm vitest run --config config/vitest.config.ts src/main/ipc/pty.test.ts src/main/providers/provider-dispatch.test.ts --reporter=dot\n\nNote: the focused vitest run still logs the existingrenameSyncfs mock warning inprovider-dispatch.test.ts, but the suite passes.Made with Orca 🐋